Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved] Bounding boxes [1.7.2]

larsgerrits

By larsgerrits
in Modder Support

 Share

Recommended Posts

larsgerrits Reality Controller

larsgerrits

Posted
Posted

Hello, i made a block with a custom model and it's larger then a standard block. When i made the bounding boxes larger, the collision boees weren't right. To solve that issue, i did a trick which sets some blocks above it, with the same type, but with a different metadata. It then created another problem: the bounding boxes weren't right any more. All the blocks have the same bounding boxes, but i wan't them to be differently based on metadata.

 

To summary, all the blocks have a bounding box of 1x7x1, instead of the block above, that should have a bounding box, which is like 1 block down.

 

Code:

[spoiler=BlockStreetlight]

package larsg310.mods.moderncities.block;

import larsg310.mods.moderncities.ModernCities;
import larsg310.mods.moderncities.lib.Names;
import larsg310.mods.moderncities.lib.RenderIds;
import larsg310.mods.moderncities.tileentity.TileEntityStreetlight;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.init.Blocks;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class BlockStreetlight extends Block
{
public BlockStreetlight()
{
	super(Material.iron);
	this.setCreativeTab(ModernCities.CREATIVE_TAB);
	this.setBlockName(Names.STREETLIGHT);
}

public TileEntity createTileEntity(World world, int meta)
{
	if (meta <= 5) return new TileEntityStreetlight();
	return null;
}

public boolean hasTileEntity(int meta)
{
	if (meta <= 5) return true;
	return false;
}

private void setDefaultDirection(World world, int x, int y, int z)
{
	if (!world.isRemote)
	{
		Block block = world.getBlock(x, y, z - 1);
		Block block1 = world.getBlock(x, y, z + 1);
		Block block2 = world.getBlock(x - 1, y, z);
		Block block3 = world.getBlock(x + 1, y, z);
		byte b0 = 3;

		if (block.func_149730_j() && !block1.func_149730_j())
		{
			b0 = 3;
		}

		if (block1.func_149730_j() && !block.func_149730_j())
		{
			b0 = 2;
		}

		if (block2.func_149730_j() && !block3.func_149730_j())
		{
			b0 = 5;
		}

		if (block3.func_149730_j() && !block2.func_149730_j())
		{
			b0 = 4;
		}

		world.setBlockMetadataWithNotify(x, y, z, b0, 2);
	}
}

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack itemstack)
{
	int l = MathHelper.floor_double((double) (player.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

	if (l == 0)
	{
		world.setBlockMetadataWithNotify(x, y, z, 2, 2);
	}

	if (l == 1)
	{
		world.setBlockMetadataWithNotify(x, y, z, 5, 2);
	}

	if (l == 2)
	{
		world.setBlockMetadataWithNotify(x, y, z, 3, 2);
	}

	if (l == 3)
	{
		world.setBlockMetadataWithNotify(x, y, z, 4, 2);
	}
	world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	super.onBlockAdded(world, x, y, z);
	this.setDefaultDirection(world, x, y, z);
}

public boolean renderAsNormalBlock()
{
	return false;
}

public boolean isOpaqueCube()
{
	return false;
}

public int getRenderId()
{
	return RenderIds.STREETLIGHT;
}

public boolean shouldSideBeRendered(IBlockAccess world, int x, int y, int z, int side)
{
	return false;
}

public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
{
	int meta = world.getBlockMetadata(x, y, z);
	if (meta <= 5) this.setBlockBounds(0, 0, 0, 1, 7, 1);
	if (meta == 6) this.setBlockBounds(0, -1, 0, 1, 6, 1);
	if (meta == 7) this.setBlockBounds(0, -2, 0, 1, 5, 1);
	if (meta ==  this.setBlockBounds(0, -3, 0, 1, 4, 1);
	if (meta == 9) this.setBlockBounds(0, -4, 0, 1, 3, 1);
	if (meta == 10) this.setBlockBounds(0, -5, 0, 1, 2, 1);
	if (meta == 11) this.setBlockBounds(0, -6, 0, 1, 1, 1);
}

public void breakBlock(World world, int x, int y, int z, Block block, int field)
{
	Block blockAbove = world.getBlock(x, y + 1, z);
	Block blockBelow = world.getBlock(x, y - 1, z);

	world.setBlock(x, y, z, Blocks.air);
	super.breakBlock(world, x, y, z, block, field);
	if (blockAbove == this) blockAbove.breakBlock(world, x, y + 1, z, block, field);
	if (blockBelow == this) blockBelow.breakBlock(world, x, y - 1, z, block, field);
}
}

 

 

 

If you need more code or information, i'll be happy to provide it.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Bedrock_Miner Dragon Slayer

Bedrock_Miner

Posted
Posted

Use 

setBlockBoundBasedOnState()

. You'll get a world object and the position with this method, so you can find out the metadata.

 

Here is an example of this method: (Used in my SignCraft-Mod)

 

@Override
public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
    {
    	int meta = world.getBlockMetadata(x, y, z);
    	float p0 = 0.0F;
    	float p16 = 1.0F;
    	float p2 = 0.125F;
    	this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
    	
    	if (meta == 0)
    	{
    		this.setBlockBounds(p0, p0, p0, p16, p16, p2);
    	}

    	if (meta == 3)
    	{
    		this.setBlockBounds(p0, p0, p0, p2, p16, p16);
    	}
    	
    	if (meta == 2)
    	{
    		this.setBlockBounds(p0, p0, p16 - p2, p16, p16, p16);
    	}
    	
    	if (meta == 1)
    	{
    		this.setBlockBounds(p16, p0, p0, p16 - p2, p16, p16);
    	}
    }

 

width=356 height=100http://i.imgur.com/wNvtGZw.png[/img]

MODS and MODDING TUTORIALS

larsgerrits Reality Controller

larsgerrits

Posted
  • Author
Posted

Use 

setBlockBoundBasedOnState()

. You'll get a world object and the position with this method, so you can find out the metadata.

 

Here is an example of this method: (Used in my SignCraft-Mod)

 

@Override
public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
    {
    	int meta = world.getBlockMetadata(x, y, z);
    	float p0 = 0.0F;
    	float p16 = 1.0F;
    	float p2 = 0.125F;
    	this.setBlockBounds(0.0F, 0.0F, 0.0F, 1.0F, 1.0F, 1.0F);
    	
    	if (meta == 0)
    	{
    		this.setBlockBounds(p0, p0, p0, p16, p16, p2);
    	}

    	if (meta == 3)
    	{
    		this.setBlockBounds(p0, p0, p0, p2, p16, p16);
    	}
    	
    	if (meta == 2)
    	{
    		this.setBlockBounds(p0, p0, p16 - p2, p16, p16, p16);
    	}
    	
    	if (meta == 1)
    	{
    		this.setBlockBounds(p16, p0, p0, p16 - p2, p16, p16);
    	}
    }

 

Ughh Ughh...

public void setBlockBoundsBasedOnState(IBlockAccess world, int x, int y, int z)
{
	int meta = world.getBlockMetadata(x, y, z);
	if (meta <= 5) this.setBlockBounds(0, 0, 0, 1, 7, 1);
	if (meta == 6) this.setBlockBounds(0, -1, 0, 1, 6, 1);
	if (meta == 7) this.setBlockBounds(0, -2, 0, 1, 5, 1);
	if (meta ==  this.setBlockBounds(0, -3, 0, 1, 4, 1);
	if (meta == 9) this.setBlockBounds(0, -4, 0, 1, 3, 1);
	if (meta == 10) this.setBlockBounds(0, -5, 0, 1, 2, 1);
	if (meta == 11) this.setBlockBounds(0, -6, 0, 1, 1, 1);
}

But that doesn't work. Anyone know why?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

larsgerrits Reality Controller

larsgerrits

Posted
  • Author
Posted

After some research, i found out that it takes the first "this.setBlockBounds()" method, and not doing the rest. Anyone know why?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

larsgerrits Reality Controller

larsgerrits

Posted
  • Author
Posted

Hi

 

So, you mean that meta is always <= 5?

 

Or that (eg) this.setBlockBounds(0, -1, 0, 1, 6, 1); doesn't set the bounds to what you expect?

 

-TGG

Yes, they all get the bounding box of meta <= 5. But i don't know why. I use this code:

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack itemstack)
{
	int l = MathHelper.floor_double((double) (player.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

	if (l == 0)
	{
		world.setBlockMetadataWithNotify(x, y, z, 2, 2);
	}

	if (l == 1)
	{
		world.setBlockMetadataWithNotify(x, y, z, 5, 2);
	}

	if (l == 2)
	{
		world.setBlockMetadataWithNotify(x, y, z, 3, 2);
	}

	if (l == 3)
	{
		world.setBlockMetadataWithNotify(x, y, z, 4, 2);
	}
	world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);
}

to set the bottom block to a different metadata based on direction, and i set all blocks above it to a different meta, so it should never be the same meta. Any guesses why thy all get the same bounding box?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

larsgerrits Reality Controller

larsgerrits

Posted
  • Author
Posted

I figured it out! When the block is placed, it calls this code:

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack itemstack)
{
	int l = MathHelper.floor_double((double) (player.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

	if (l == 0)
	{
		world.setBlockMetadataWithNotify(x, y, z, 2, 2);
	}

	if (l == 1)
	{
		world.setBlockMetadataWithNotify(x, y, z, 5, 2);
	}

	if (l == 2)
	{
		world.setBlockMetadataWithNotify(x, y, z, 3, 2);
	}

	if (l == 3)
	{
		world.setBlockMetadataWithNotify(x, y, z, 4, 2);
	}
	world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);
}

When the blocks above it were placed, that block wasn't placed by the player, so it calls the onBlockAdded method, which sets the metadata to 2,3,4 or 5. And that was the problem. I solved it by replacing:

world.setBlock(x, y + 1, z, ModBlocks.STREETLIGHT, 6, 3);
	world.setBlock(x, y + 2, z, ModBlocks.STREETLIGHT, 7, 3);
	world.setBlock(x, y + 3, z, ModBlocks.STREETLIGHT, 8, 3);
	world.setBlock(x, y + 4, z, ModBlocks.STREETLIGHT, 9, 3);
	world.setBlock(x, y + 5, z, ModBlocks.STREETLIGHT, 10, 3);
	world.setBlock(x, y + 6, z, ModBlocks.STREETLIGHT, 11, 3);

by:

for(int i = 1; i < 7; i++)
	{
		world.setBlock(x, y + i, z, ModBlocks.STREETLIGHT, 0, 3);
		world.setBlockMetadataWithNotify(x, y+i, z, 5+i, 3);
	}

which just set's the metadata to the appropriate value, after the onBlockAdded method sets it to 2,3,4 or 5.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept