Jump to content

Recommended Posts

Posted

I'm new to modding, and after having made my first block and such, I decided to try out basic world generation. For my first attempt, I'm trying to get the overworld to be a void. My mod compiles, Minecraft loads, but when I try to generate a new world it crashes...  :(

 

 

crash report:

https://gist.github.com/anonymous/1613a3baceb82c1670be

 

relevent parts of my mod class:

https://gist.github.com/anonymous/36a6b786e60cbb8c23e6

 

complete mod class:

https://gist.github.com/anonymous/74181edcbb615935b727

 

and SkyblockGenerator class:

https://gist.github.com/anonymous/1e9c7e16457af4f3f2a1

 

any insight to what I'm doing wrong would be greatly appreciated.

(also, is there a more efficient way to make a chunk void?)

Posted

not sure if it is important, but I discovered that if I change my world generator class to clear a specific chunk (rather than the one minecraft is actually generating), new worlds generate just fine... until that chunk is loaded.

 

new skyblock generator class:

https://gist.github.com/anonymous/d3ec08c85d1e16f50c0a

 

latest crash report:

https://gist.github.com/anonymous/7ad878d1e5b0dce20c83

 

I also noticed that in this latest crash report, none of my classes are mentioned in the stacktrace...

 

again, any assistance would be appreciated.

Posted

Haven't messed around with chunks.

 

It could be that the chunk you are trying to "remove" blocks in, hasn't been "generated".

Still really not sure, I'll check around and see if I can help you.

 

Good luck ;)

Posted

Thanks for the reply coolboy4531,

I've been messing around with my code and you were right, one of my (many) problems was that the code tried to remove blocks from adjacent chunks, forcing those chunks to generate and then repeating that process infinity.

 

but it still crashes when I try to generate a world...

 

my latest mod class:

https://gist.github.com/anonymous/446ad3072b132fd63bed

 

and the generator class:

https://gist.github.com/anonymous/903da7919ed1dde12d79

 

crash report:

https://gist.github.com/anonymous/a9612af3b09b2ee64477

 

 

I've tried several thing to figure out what's going wrong including:

--making a block that calls the destroyChunk method when it is right clicked, and it works perfectly

--it doesn't matter if I do setBlock (x, y, z, Blocks.air); or setBlockToAir (x, y, z); both crash

--I have it print out what block it destroys, and for a while there was a pattern, the first (~5) times it crashed when it started destroying a new x coordinate. but then it crashed on the last x a couple times... and just now it crashed half way through... so idk what's going on there.

 

I'm out of ideas on what could be going wrong with this, it's likely that I'm missing something because I'm new to modding...

thanks for taking the time to read this everyone.

Posted

You could use ChunkDataEvent.Load getting the data of the chunk at (x, z) -- also checking if its null before proceeding.

 

This could cause issues with - whatever you are using - because it requires the chunk to be loaded.

Posted

--it doesn't matter if I do setBlock (x, y, z, Blocks.air); or setBlockToAir (x, y, z); both crash

 

There is another method with additional parameters:

setBlock(x, y, z, block, meta, flag)

 

you can use 0 as meta as there're no subtypes of the air block

flag determines how the method should behave:

1 - cause block update

2 - changes get sent to client

4 - prevents re-rendering

 

The methods w/o the flag parameter always use 3 as a flag (which means 1 | 2 or "cause block update" and "changes get sent to client")

Try to use 2 as the flag, like:

setBlock(x, y, z, Blocks.air, 0, 2)

 

and see if it still crashes

 

or

 

use the DecorateBiomeEvent.Post event to delete all blocks, since I've seen it's related to the BiomeDecorator

or the Decorate event and check if it should decorate (it shouldn't if the chunk is "empty"). For the latter: set the result to DENY if it shouldn't generate at all (also don't check for the EventType here)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Minecraft 1.21.4 requires a new model definition file for each item, which you don't have. These can be created through Data Generation, specifically the ModelProvider, BlockModelGenerators and ItemModelGenerators classes.
    • Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.