[1.6.4] - [Solved]Crafting with a damaged item.

Atheera · April 3, 2014

Hey! I have a problem when crafting with a damaged item. I have it so my chisel takes damage when it's undamaged but after it's damaged I can no longer use it for crafting.

I basically want to craft with a damaged item but I can't.

Here's my Item code.

package net.be.mods.item;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import net.be.mods.MainModBE;

import net.minecraft.client.renderer.texture.IconRegister;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

public class toolJewelChisel extends Item

{

private ItemStack emptyItem = null;

private static int maxDamage = 64;

public toolJewelChisel(int id)

{

super(id);

setMaxDamage(64);

this.setMaxStackSize(1);

this.setCreativeTab(MainModBE.BETab);

this.setNoRepair();

}

@Override

public boolean hasContainerItem() {

return true;

}

public void setEmptyItem(ItemStack ei) {

this.emptyItem = ei;

}

public boolean doesContainerItemLeaveCraftingGrid(ItemStack par1ItemStack) {

return false;

}

@Override

public ItemStack getContainerItemStack(ItemStack stack) {

int dmg = stack.getItemDamage();

if (dmg == maxDamage) {

return new ItemStack(stack.getItem(), 0, maxDamage);

}

ItemStack tr = copyStack(stack, 1);

tr.setItemDamage(dmg + 1);

return tr;

}

public static ItemStack copyStack(ItemStack stack, int n) {

return new ItemStack(stack.itemID, n, stack.getItemDamage());

}

@SideOnly(Side.CLIENT)

public void registerIcons(IconRegister iconRegister)

{

this.itemIcon = iconRegister.registerIcon(MainModBE.modid + ":" + this.getUnlocalizedName().substring(5));

}

Atheera · April 3, 2014

Use OreDictionary.WILDCARD_VALUE as the damage value for your ItemStack when registering the recipe

Thank you!

But now there is a new problem...

The item does not dissapear when used to 0, it has 0 uses left and I can still use it infinitly.

I'm kind of new but I understand most of what is going on but this has me rendered helpless...

Some help would be awesome:)

Atheera · April 3, 2014

a) You should use .copy() on the ItemStack instead of your custom method, because otherwise NBT data will not be transferred (enchantments, custom names, etc. will be lost)

b) Instead of returning a 0-size ItemStack when reaching max-damage, return null.

I fixed the second issue, I hope. I can now craft and it takes damage but when it reaches 0, my client crashes.

I didn't really understand which ItemStack that I should use .copy() on.

Sorry to bother you so much but I really want to learn this

package net.be.mods.item;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

import net.be.mods.MainModBE;

import net.minecraft.client.renderer.texture.IconRegister;

import net.minecraft.creativetab.CreativeTabs;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

public class toolJewelChisel extends Item

{

private ItemStack emptyItem = null;

private static int maxDamage = 64;

public toolJewelChisel(int id)

{

super(id);

setMaxDamage(64);

this.setMaxStackSize(1);

this.setCreativeTab(MainModBE.BETab);

this.setNoRepair();

}

@Override

public boolean hasContainerItem() {

return true;

}

public void setEmptyItem(ItemStack ei) {

this.emptyItem = ei;

}

public boolean doesContainerItemLeaveCraftingGrid(ItemStack par1ItemStack) {

return false;

}

@Override

public ItemStack getContainerItemStack(ItemStack stack) {

int dmg = stack.getItemDamage();

if (dmg == maxDamage) {

return null;

}

ItemStack tr = copyStack(stack, 1);

tr.setItemDamage(dmg + 1);

return tr;

}

public static ItemStack copyStack(ItemStack stack, int n) {

return new ItemStack(stack.itemID, n, stack.getItemDamage());

}

@SideOnly(Side.CLIENT)

public void registerIcons(IconRegister iconRegister)

{

this.itemIcon = iconRegister.registerIcon(MainModBE.modid + ":" + this.getUnlocalizedName().substring(5));

}

Atheera · April 3, 2014

---- Minecraft Crash Report ----

// Would you like a cupcake?

Time: 2014-04-03 17:38

Description: Updating screen events

java.lang.NullPointerException

at net.minecraft.inventory.SlotCrafting.onPickupFromSlot(SlotCrafting.java:133)

at net.minecraft.inventory.ContainerWorkbench.transferStackInSlot(ContainerWorkbench.java:143)

at net.minecraft.inventory.Container.slotClick(Container.java:282)

at net.minecraft.inventory.Container.retrySlotClick(Container.java:520)

at net.minecraft.inventory.Container.slotClick(Container.java:291)

at net.minecraft.inventory.Container.retrySlotClick(Container.java:520)

at net.minecraft.inventory.Container.slotClick(Container.java:291)

at net.minecraft.inventory.Container.retrySlotClick(Container.java:520)

at net.minecraft.inventory.Container.slotClick(Container.java:291)

at net.minecraft.client.multiplayer.PlayerControllerMP.windowClick(PlayerControllerMP.java:477)

at net.minecraft.client.gui.inventory.GuiContainer.handleMouseClick(GuiContainer.java:820)

at net.minecraft.client.gui.inventory.GuiContainer.mouseClicked(GuiContainer.java:559)

at net.minecraft.client.gui.GuiScreen.handleMouseInput(GuiScreen.java:208)

at net.minecraft.client.gui.GuiScreen.handleInput(GuiScreen.java:176)

at net.minecraft.client.Minecraft.runTick(Minecraft.java:1565)

at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:910)

at net.minecraft.client.Minecraft.run(Minecraft.java:839)

at net.minecraft.client.main.Main.main(Main.java:93)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:131)

at net.minecraft.launchwrapper.Launch.main(Launch.java:27)

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

-- Head --

Stacktrace: