[1.7.2]GameRegistry from custom classes

[lorizz]

Hi guys, I'm starting to think that this forge is bad (for me eh)

When I was modding in 1.5.2 and 1.6.4, I had custom classes and custom registers, called each one in each proxy, example:

 

BlockRegistry:

package it.edennetwork.crystalia.module;

import it.edennetwork.crystalia.extender.BlockDecorativeExtendedRotatable;
import it.edennetwork.crystalia.extender.BlockExtender;
import net.minecraft.block.Block;

public class BlocksDecorative {

public static Block lightBlueMagicLeaves;
public static Block lightOrangeMagicLeaves;

public static Block magicWood;
public static Block whiteMagicWood;

public static Block whiteRock;
public static Block blueRock;

public static void onLoad() {
	lightBlueMagicLeaves = new BlockExtender("FoglieMagicheAzzurre",
			CryTabs.crystaliaDecorativeTab).setHardness(0.2F).setStepSound(
			Block.soundTypeGrass);
	lightOrangeMagicLeaves = new BlockExtender(
			"FoglieMagicheArancioni", CryTabs.crystaliaDecorativeTab)
			.setHardness(0.2F).setStepSound(Block.soundTypeGrass);
	magicWood = new BlockDecorativeExtendedRotatable("LegnoMagico",
			"LegnoMagicoTop");
	whiteMagicWood = new BlockDecorativeExtendedRotatable(
			"LegnoMagicoChiaro", "LegnoMagicoChiaroTop");
	whiteRock = new BlockExtender("RocciaBianca",
			CryTabs.crystaliaDecorativeTab);
	blueRock = new BlockExtender("RocciaBlu",
			CryTabs.crystaliaDecorativeTab);
}
}

 

Then I called the "onLoad" method in the Client/ServerProxy in the preInit function:

 

BlocksDecorative.onLoad();

 

But the problem is that the game registers the blocks but doesn't show them in the CreativeTabs! I can only get it by using the "/give" command, it does even not show them in the "Search Tab".

Why? The custom blocks extend to a class which has a constructor that call this at the end:

 

GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));

 

Can someone help me with this? They doesn't show up even using the normal forge method, only for another blocks different from the ones coming from the 1.5.2/1.6.4 version.

[jabelar]

I'm not at my computer with code so I can't confirm, but I'm pretty sure I put a setCreativeTabs() method in the block class constructor, or at least for items I do that.

[SanAndreaP]

Hi guys, I'm starting to think that this forge is bad (for me eh)

When I was modding in 1.5.2 and 1.6.4, I had custom classes and custom registers, called each one in each proxy, example:

 

BlockRegistry:

package it.edennetwork.crystalia.module;

import it.edennetwork.crystalia.extender.BlockDecorativeExtendedRotatable;
import it.edennetwork.crystalia.extender.BlockExtender;
import net.minecraft.block.Block;

public class BlocksDecorative {

public static Block lightBlueMagicLeaves;
public static Block lightOrangeMagicLeaves;

public static Block magicWood;
public static Block whiteMagicWood;

public static Block whiteRock;
public static Block blueRock;

public static void onLoad() {
	lightBlueMagicLeaves = new BlockExtender("FoglieMagicheAzzurre",
			CryTabs.crystaliaDecorativeTab).setHardness(0.2F).setStepSound(
			Block.soundTypeGrass);
	lightOrangeMagicLeaves = new BlockExtender(
			"FoglieMagicheArancioni", CryTabs.crystaliaDecorativeTab)
			.setHardness(0.2F).setStepSound(Block.soundTypeGrass);
	magicWood = new BlockDecorativeExtendedRotatable("LegnoMagico",
			"LegnoMagicoTop");
	whiteMagicWood = new BlockDecorativeExtendedRotatable(
			"LegnoMagicoChiaro", "LegnoMagicoChiaroTop");
	whiteRock = new BlockExtender("RocciaBianca",
			CryTabs.crystaliaDecorativeTab);
	blueRock = new BlockExtender("RocciaBlu",
			CryTabs.crystaliaDecorativeTab);
}
}

 

Then I called the "onLoad" method in the Client/ServerProxy in the preInit function:

 

BlocksDecorative.onLoad();

 

But the problem is that the game registers the blocks but doesn't show them in the CreativeTabs! I can only get it by using the "/give" command, it does even not show them in the "Search Tab".

Why? The custom blocks extend to a class which has a constructor that call this at the end:

 

GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));

 

Can someone help me with this? They doesn't show up even using the normal forge method, only for another blocks different from the ones coming from the 1.5.2/1.6.4 version.

Your mod class? An example block class?

[Bishamonten]

I'm not sure if it's changed in 1.7, but when you

lightBlueMagicLeaves = new BlockExtender("FoglieMagicheAzzurre", CryTabs.crystaliaDecorativeTab).setHardness(0.2F).setStepSound(Block.soundTypeGrass);

 

I don't know what your BlockExtender class looks like and why your setting the customTab as a part of the constructor.

In 1.6 mine would look something like this

oreCopper = new BlockRE(oreCopperID, Material.rock).setUnlocalizedName("oreCopper");

 

and my BlockRE would be like

public BlockRE(int id, Material material) {
	super(id, material);
	this.setCreativeTab(RegistryRE.tabRE);
}

 

Also, are you registering the name in the language registry? I know its different in 1.7, but i know you still have to do it a certain way.

[coolboy4531]

We need to see your BlockExtender class - to make sure you are applying correct and functional code.

[lorizz]

Here's the class extender:

 

package it.edennetwork.crystalia.extender;

import it.edennetwork.crystalia.Crystalia;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import cpw.mods.fml.common.registry.GameRegistry;

public class BlockExtender extends Block {
    public final String textureName;
    public final int droppedItemID;
    public final int quantityDrop;

    public BlockExtender(String texture, CreativeTabs tab)
    {
        super(Material.rock);
        textureName = texture;
        setCreativeTab(tab);
        this.setHarvestLevel("pickaxe", 0);
        setBlockName(texture);
        setStepSound(Block.soundTypeStone);
        droppedItemID = this.getIdFromBlock(this);
        quantityDrop = 1;
        GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));
    }

    @Override
    public void registerBlockIcons(IIconRegister iconRegister)
    {
        blockIcon = iconRegister.registerIcon(Crystalia.modid + ":" + textureName);
    }

    @Deprecated // Removed in 1.7.2
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return droppedItemID;
    }

    @Deprecated // Removed in 1.7.2
    public int quantityDropped(Random random)
    {
        return quantityDrop;
    }
}

[coolboy4531]

y u haz to b so lazy

 

- from what I remember I don't think Forge checks for that crap (idk really) but what I think is that GameRegistry is only read during preInit.

[Abastro]

Please show your CryTabs class.

there might be the problem.

[sequituri]

Here's the class extender:

 

    public BlockExtender(String texture, CreativeTabs tab)
    {
        droppedItemID = this.getIdFromBlock(this);
...
        GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));
    }

    @Deprecated // Removed in 1.7.2
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return droppedItemID;
    }

    @Deprecated // Removed in 1.7.2
    public int quantityDropped(Random random)
    {
        return quantityDrop;
    }
}

 

This may not be your main problem, but your code cannot work as written with IDs. Even if you registered your block before trying to use its ID (which you cannot), you are using deprecated methods which have no purpose in 1.7.2. Using the

@deprecated

annotation is the same as saying ignore this error. But, there is no reason to cheat like that.

 

[lorizz]

Here's the class extender:

 

    public BlockExtender(String texture, CreativeTabs tab)
    {
        droppedItemID = this.getIdFromBlock(this);
...
        GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));
    }

    @Deprecated // Removed in 1.7.2
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return droppedItemID;
    }

    @Deprecated // Removed in 1.7.2
    public int quantityDropped(Random random)
    {
        return quantityDrop;
    }
}

 

This may not be your main problem, but your code cannot work as written with IDs. Even if you registered your block before trying to use its ID (which you cannot), you are using deprecated methods which have no purpose in 1.7.2. Using the

@deprecated

annotation is the same as saying ignore this error. But, there is no reason to cheat like that.

 

I know, those method also are not being called because they doesn't override nothing, just only for purpose.

Anyway I removed them, still not working.

 

@coolboy

The registry is called in the "preInit" method, even if I try to call it outside the class, doesn't work.

I tried making a "testBlock" directly in the preinit method and registered it with a custom creative tabs, IT WORKS! But I don't know why forge doesn't check this extender...

Expecially the "setCreativeTab(tab)"....

[coolboy4531]

We need some real verification from Forge.

 

From what I think (in my perspective) I don't think Forge checks for (GameRegistry.#) in custom classes - they only check for it in the PreInit method like I said below.

 

And for the .setCreativeTab(#) - I really don't know.

Like said, above, could be something with your CryTabs class (please show us it).

[lorizz]

I got it, I called the Tabs AFTER the game has registered the blocks/items. Now I need only to make a different "GameRegistry" function that will register the blocks/items AFTER the tables has been loaded and AFTER the blocks/items have been initialized!

Thanks for all to pointing to the tabs! It helped me very much, thanks!