Jump to content

[1.7.2] Simple bug in EnumHelper


acid1103

Recommended Posts

In

net.minecraftforge.common.util.EnumHelper

, there's at lease one bug in

Class[][] CommonTypes

.

{EnumCreatureType.class, Class.class, int.class, Material.class, boolean.class}

needs to be

{EnumCreatureType.class, Class.class, int.class, Material.class, boolean.class, boolean.class}

because the constructor in EnumCreatureType.class is as follows:

private EnumCreatureType(Class par3Class, int par4, Material par5Material, boolean par6, boolean par7)
{
    this.creatureClass = par3Class;
    this.maxNumberOfCreature = par4;
    this.creatureMaterial = par5Material;
    this.isPeacefulCreature = par6;
    this.isAnimal = par7;
}

 

As for now, modders have to use the

public static <T extends Enum<? >> T addEnum(Class<T> enumType, String enumName, Class<?>[] paramTypes, Object[] paramValues)

method in

EnumHelper

, which is obviously not the intent of this class.

Also, just as some evidence that this is an issue, I spent over two hours trying to figure out how to do this using Reflection because I didn't read the error very well last night when I first stumbled upon it. The error is one of those where it's like

Exception blahblah
stacktrace
stacktrace
stacktrace
stacktrace
...
caused by Exception blahblah
stacktrace
stacktrace
...
caused by Exception blahblah
stacktrace
stacktrace
...

and I only saw the first exception..

 

Anyway, I hope this gets fixed (though, of course, it's certainly of low priority, albeit a simple fix..)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.