Saved tile entity data makes all tile entitys have the same data

[robertcars]

I am trying to save the password that someone entered every time you save it though all the tile entitys in the world have the same one. So if tile entity A has the password 123 all the other tile entitys of the same type have the same password 123.

 

Can someone please help me thanks alot.

 

package com.techmod.client.tileentity;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;

public class TileEntityKeyPad extends TileEntity {

public static String pass;
public static int pa;

    public void readFromNBT(NBTTagCompound p_145839_1_) {
        super.readFromNBT(p_145839_1_);

        TileEntityKeyPad.pass = p_145839_1_.getString("Pass");

    }

    public void writeToNBT(NBTTagCompound p_145841_1_)
    {
        super.writeToNBT(p_145841_1_);
        p_145841_1_.setString("Pass", TileEntityKeyPad.pass);
    }



}

[brandon3055]

Remove the "TileEntityKeyPad." that if im not mistaken is setting the default value fore the TileEntityKeyPad class.

[robertcars]

Thanks for the respond I'm at school right now so ill try it when I get home.

[larsgerrits]

You're making it a static value, which is the same for all TileEntities of that type. You should make it a non-static value and instead of using TileEntityKeyPad.*, use world.getTileEntity(x,y,z) to get the TileEntity at that location, and check if the TileEntity is an instanceof TileEntityKeyPad, then cast it to the appropriate type and then set the value in that.

[robertcars]

Could you please explain a little more on where and how to use the world.getTileEntity(x,y,z). Would I use it in the TileEntityClass or somewhere else?

[SanAndreaP]

Could you please explain a little more on where and how to use the world.getTileEntity(x,y,z). Would I use it in the TileEntityClass or somewhere else?

 

If you make a field non-static, it means every instance of this class has its own copy of that field (basic java)

If you want to access such fields, within the class use this.fieldName (you can actually omit the this., but it's better for code-readabiliy to have it) (basic java)

For accessing it outside of the class, you need an instance of said class and access it with this instance with instanceName.fieldName (again, basic java)

 

To get such an instance of a TileEntity, you need to use world.getTileEntity(x,y,z)