[1.7.2][build 1085][FIXED]World generation taking really long

[theOriginalByte]

Hi,

I'm new to modding and am not sure how to fix the world taking 10 minutes to generate. Here is the code I have.

Full repo here https://github.com/KaminoCoding/JAMOA/tree/master/src/main/java/com/endergriefer/jamoa/world

 

package com.endergriefer.jamoa.world;

import com.endergriefer.jamoa.blocks.ModBlocks;
import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;

import java.util.Random;

/**
* Created by noah on 5/14/14.
*/
public class WorldGenjamoa implements IWorldGenerator
{
    public void generate(Random rand, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider)
    {
        switch(world.provider.dimensionId)
        {
            case -1:
                generateNether(world, rand, chunkX * 16, chunkZ * 16);
            case 0:
                generateSurface(world, rand, chunkX*16, chunkZ*16);
        }
    }

    private void generateSurface(World world, Random rand, int chunkX, int chunkZ)
    {
        for(int i = 0; i < 10; i++) {
            int randPosX = chunkX + rand.nextInt(16);
            int randPosY = rand.nextInt(40);
            int randPosZ = chunkZ + rand.nextInt(16);

            (new WorldGenMinable(ModBlocks.superbiumOre, 5)).generate(world, rand, randPosX, randPosY, randPosZ);
        }

        for (int j = 0; j < 25; j++) {
            int randPosX = chunkX + rand.nextInt(12);
            int randPosY = rand.nextInt(80);
            int randPosZ = chunkZ + rand.nextInt(12);

            (new WorldGenMinable(ModBlocks.aradactiteOre, ).generate(world, rand, randPosX, randPosY, randPosZ);
        }
    }


    private void generateNether(World world, Random rand, int i, int j)
    {

    }

}

[theOriginalByte]

can someone please help?

[theOriginalByte]

Bump:

Does anyone know what I coded wrong?

[Sear_Heat]

Well, this really depends on the computer, but when you start up the world it tries to generate Aradactite Ore 24 times per chunk (I believe), and there are a crapload of chunks in Minecraft. I would lower it to something more reasonable like 10.

[theOriginalByte]

I fixed it... the third paramater in

(new OreGenMinable(par1, par2, par3) etc.

I didn't have a par3 and i added it as the same as block in par1 and it doen't take forever to generate