[1.7.2]Create new horse armor

[Hackbaellchen]

Hey,

I want to create new horse armor. I had a look into the vanilla code and found something in the EntityHorse, but I won't edit that. Are there any ways to bypass it?

[ShaneCraft]

The container slot for the armor of a horse only accepts items which are defined in the horse's class. (func_146085_a in 1.7.2).

You could create a new entity class and make it extend EntityHorse and override that one function.

 

They should've created a new item class called ItemHorseArmor and let the armorslot check if the item the player tries to enter into it is an instance of ItemHorseArmor.

It saves some unnecessary checks in both entityhorse and containerhorseinventory.

[SanAndreaP]

The container slot for the armor of a horse only accepts items which are defined in the horse's class. (func_146085_a in 1.7.2).

You could create a new entity class and make it extend EntityHorse and override that one function.

 

They should've created a new item class called ItemHorseArmor and let the armorslot check if the item the player tries to enter into it is an instance of ItemHorseArmor.

It saves some unnecessary checks in both entityhorse and containerhorseinventory.

 

I've included a hook in my coremod. I will do a PR however when I get time (by the way, it's a PITA to recode the horse armor stuff for horses, EVERYTHING is hardcoded in there).

For anyone who's interested:

 

Item class:

https://github.com/SanAndreasP/SAPManagerPack/blob/master/java/de/sanandrew/core/manpack/util/ItemHorseArmor.java

Transformer:

https://github.com/SanAndreasP/SAPManagerPack/blob/master/java/de/sanandrew/core/manpack/transformer/TransformHorseArmor.java

[Hackbaellchen]

Thanks. I'll try it

[jeffryfisher]

They should've created a new item class called ItemHorseArmor and let the armorslot check if the item the player tries to enter into it is an instance of ItemHorseArmor.

 

Agreed.

 

it's a PITA to recode the horse armor stuff for horses, EVERYTHING is hardcoded in there

 

If we forge it, then maybe we can fix that.

 

Also: If something is currently kludged in vanilla code, then it is prone to being "fixed" in a future Minecraft update.

 

I need to learn about transformers. They look like fun.

[jeffryfisher]

With 1.8 released (and Microsoft's acquisition likely to end all development that gamers would ever care about), can we see where vanilla horse armor coding will land? Knowing what we're stuck with, can someone more knowledgeable than I now do the "pull request"?

 

In the mean time, for fun and as a Java exercise, I am going to attempt to subclass EntityHorse in a way that separates all horse armor from it. If I have my way, then my mod horses will wear armor defined in a subclass of ItemArmor. Horse-armor will simply become another piece following helm, chest, leg & boots. In other words, while a helmet goes on a humanoid head, horse-armor goes on a whole horse. I hope I can bring together both vanilla and mod armors 

 

Please let me know ASAP if progress has been made in this area so I don't reinvent too many wheels!