[1.7.2] Looping through players inventory to check for best item.

[Shamboozle]

I wondering if anyone can help me...

 

Here's my code

private Minecraft mc = Minecraft.getMinecraft();
private List<ItemStack> playerItems = new ArrayList<ItemStack>();

@SideOnly(Side.CLIENT)
@SubscribeEvent
public void onPlayerRender(RenderPlayerEvent.Specials.Post event) {
	if (event.isCanceled())
		return;

	ItemStack stackToRender = getSelectItem(event.entityPlayer.inventory);

	if (stackToRender != null && stackToRender != event.entityPlayer.getCurrentEquippedItem()) {
		System.out.println(stackToRender.getDisplayName());
		renderItemIn3D(stackToRender);
	}

}

private ItemStack getSelectItem(InventoryPlayer inventory){

	ItemStack selectedItem = null;

	for(int i = 0; i < inventory.getSizeInventory(); i++){
		ItemStack curStack = inventory.getStackInSlot(i);

		if (curStack != null) {
			if ((curStack.getItem() instanceof ItemSword) && !(playerItems.contains(curStack))) {
				playerItems.add(curStack);
			}
		}
	}

	for(int j = 0; j < playerItems.size(); j++){

		ItemStack currItem = playerItems.get(j);

		if(currItem.getItem() == Items.wooden_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.stone_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.iron_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.stone_sword){
			selectedItem = currItem;
			return selectedItem;
		} else if(currItem.getItem() == Items.wooden_sword){
			selectedItem = currItem;
			return selectedItem;
		}

	}

	return selectedItem;
}

 

I am trying to get it so I can render the best Sword on the players inventory, but it only renders a wooden sword even though I check for all the swords and It should render the diamond one if that is the best in the inventory, then gold, then iron etc. But it doesn't work so can some one point me in the right direction. (I have tried the if statements the other way round starting with the diamond sword btw)

[TheGoldSun]

Hi!

 

I can't see in the code (but I'm not so expert with FML, so I just trying to give you an idea) the point where it should check the inventory. You should execute, I think, three checks:

 

1) if the player has got any sword.

 

2) check each sword and value.

 

3) the best value obtained will determinate the stack to render.

 

 

About the 2nd point, I wonder.... How do you "know" the value of the item? May I suggest a check variable, eg. "maxValuable"?

If wood = 1, gold = 2, iron = 3, diamond = 4 (just samples), on every item check, if the item value is better than maxValuable value (that start with 0 = not rendering anything) so update maxValuable. At the end, check maxValuable and render what is appropriate.

 

Hope this could help you!

[Shamboozle]

OK I will give that a try, thanks for the reply I appreciate it

[jabelar]

I think the problem is that you're returning from the method as soon as you find a match, and worse you're checking for wooden first.  I think the way you've got it coded will probably return the first sword of any type (not the best).

 

If you're trying to find the best one, you need to loop through the whole inventory only looking for the best sword, and then loop through the whole inventory again looking for the next best, and so on.

 

[Shamboozle]

ok, I noticed that I was looking for wooden first just after I posted it, so I changed it to diamond but it still didn't work, I am trying a different way now.

[sequituri]

"Best" with weapons is a very subjective assessment. Most damage? (against what? Arthropods?) Most enchantable? Most durable? Most undamaged?

 

Yeah, so... you have to decide on a guideline that makes sense. And, what about mod swords from other mods? Some of those are uber!