HELP! Weird Entity behaviour with setPositionAndRotation

[Bedrock_Miner]

Heyho guys!

 

I created an Entity which adjusts its position to its owner's position (normally the player). Now I encountered a small problem:

The Entity's y position is not updated correctly. I have one line of code which is called in onUpdate on server side to update the entities position:

this.setPositionAndRotation(this.owner.posX, this.owner.posY + 10.0F, this.owner.posZ, this.owner.rotationYaw, this.owner.rotationPitch);

 

On the server, the Entity is at the right position ten blocks above the player but on the client, the entity is just at the player's origin point.

The problem is that basically everything works, if the player moves, the entity moves too. I tried to set the height of the entity to a constant value like this:

this.setPositionAndRotation(this.owner.posX, 70.0F, this.owner.posZ, this.owner.rotationYaw, this.owner.rotationPitch);

On the server side, the entity is at this position but on the client side its rendered at the height I spawned it, no matter if this was 70 or maybe 90.

 

I'll post some code here, but I'm really not sure which code you'll need so please write if you need more.

 

Entity Base class:

package com.bedrockminer.magicum.entity.magic;

import io.netty.buffer.ByteBuf;

import java.util.HashMap;
import java.util.List;
import java.util.Map.Entry;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.command.IEntitySelector;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.world.World;

import com.bedrockminer.magicum.damage.DamageSourceMagic;
import com.bedrockminer.magicum.element.Elements;
import com.bedrockminer.magicum.util.elements.ElementMagicHelper;

import cpw.mods.fml.common.registry.IEntityAdditionalSpawnData;

public abstract class EntityMagic extends Entity implements IEntityAdditionalSpawnData {

protected EntityLivingBase owner;
protected boolean isInGround;
protected int tileX;
protected int tileY;
protected int tileZ;

public EntityMagic(World par1World) {
	super(par1World);
	this.setSize(1.0F, 1.0F);
}

public EntityMagic(World par1World, EntityLivingBase owner) {
	this(par1World);
	this.owner = owner;
}

public void onCollideWithBlock(World world, int x, int y, int z) {
}

public void onCollideWithEntity(Entity e) {
	this.performMagicEffect(e);
}

@Override
public void onUpdate() {
	super.onUpdate();
	if (!this.worldObj.isRemote && (this.elements == null || this.mainElement == null)) {
		this.setDead(); //Kill the entity if it has no data. This is only for startup, it happens never in normal gameplay
		return;
	}

	if (!this.worldObj.isRemote && !this.isDead) {
		this.checkForBlockCollisions();
		this.checkForEntityCollisions();
	}
}

protected void checkForBlockCollisions() {
	this.isInGround = false;
	Block block = this.worldObj.getBlock(this.tileX = (int) this.posX, this.tileY = (int) this.posY, this.tileZ = (int) this.posZ);
        if (block.getMaterial() != Material.air) {
            block.setBlockBoundsBasedOnState(this.worldObj, this.tileX, this.tileY, this.tileZ);
            AxisAlignedBB axisalignedbb = block.getCollisionBoundingBoxFromPool(this.worldObj, this.tileX, this.tileY, this.tileZ);
            if (axisalignedbb != null && axisalignedbb.intersectsWith(this.boundingBox)) {
            	this.isInGround = true;
            	this.onCollideWithBlock(this.worldObj, this.tileX, this.tileY, this.tileZ);
            }
        }
}

protected void checkForEntityCollisions() {
	List<?> entities = this.worldObj.getEntitiesWithinAABBExcludingEntity(this, this.boundingBox, new EntitySelector(this.owner));
	if (entities.size() > 0) {
		for (Object e : entities)
			this.onCollideWithEntity((Entity)e);
	}
}

@Override
protected void entityInit() {
}

@Override
protected void readEntityFromNBT(NBTTagCompound var1) {
}

@Override
protected void writeEntityToNBT(NBTTagCompound var1) {
}

private static class EntitySelector implements IEntitySelector {

	private EntityLivingBase owner;

	private EntitySelector (EntityLivingBase owner) {
		this.owner = owner;
	}

	@Override
	public boolean isEntityApplicable(Entity entity) {
		return !(entity instanceof EntityMagic || entity == this.owner);
	}
}
}

 

Special Entity Class:

package com.bedrockminer.magicum.entity.magic;

import io.netty.buffer.ByteBuf;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.world.World;

import com.bedrockminer.magicum.Main;
import com.bedrockminer.magicum.client.particle.ParticleEffect;
import com.bedrockminer.magicum.util.entity.PositionUtil;

public class EntityMagicBeam extends EntityMagic {

protected EntityMagicBeam childMagic;
protected EntityMagicBeam parentMagic;
protected int childCount = 1;
public boolean isMainMagic;

public EntityMagicBeam(World world) {
	super(world);
	this.width = 0.5F;
	this.height = 0.5F;
}

public EntityMagicBeam(World world, EntityLivingBase owner) {
	super(world, owner);
	this.width = 0.5F;
	this.height = 0.5F;
}

@Override
public void onUpdate() {
	super.onUpdate();
	if (!this.worldObj.isRemote) {
		if (!this.isMainMagic && this.parentMagic == null) { //Kills the Entity if it has no data
			this.setDead();
			return;
		}

		if (!this.isInGround && this.childCount < this.getMaxLength() && this.childMagic == null) { //To test the basic behaviour i disabled the children
			this.childMagic = new EntityMagicBeam(this.worldObj, this.getOwner());
			this.childMagic.childCount = this.childCount + 1;
			this.childMagic.parentMagic = this;
			this.updateChildPosition();
			this.worldObj.spawnEntityInWorld(this.childMagic);
		}

		if (this.isMainMagic && this.owner != null) { //On the server it does its work correctly!
			Main.log("Old Position:" + this.posX + "," + this.posY + "," + this.posZ);
			this.setPositionAndRotation(this.owner.posX, 70.0F, this.owner.posZ, this.owner.rotationYaw, this.owner.rotationPitch);
			Main.log("Called! new position:" + this.posX + "," + this.posY + "," + this.posZ);
		}

		if (this.childMagic != null) {
			this.updateChildPosition();
		}
	}

	if (this.worldObj.isRemote) {
		this.doParticleEffects();
	}
}

protected void doParticleEffects() { //Actually only a control for the entities position
	ParticleEffect.spawnElementParticle(Elements.Fire, this.posX, this.posY, this.posZ, 0, 0, 0);
}

@Override
public void setDead() {
	super.setDead();
	if (this.childMagic != null) //Used to clear the complete beam after an obstacle
		this.childMagic.setDead();
}

protected void updateChildPosition() {
	PositionUtil.adjustEntityPositionToOwnerRotation(this.childMagic, this, 1.0D, 0.0F);
}
}

 

The entity is spawned with this method on Server side:

this.controlledEntity = new EntityMagicBeam(this.world, this.source);
this.controlledEntity.isMainMagic = true;
this.controlledEntity.setPositionAndRotation(this.source.posX, this.source.posY, this.source.posZ, this.source.rotationYaw, this.source.rotationPitch);
//The Entity position is set to the owners position directly in Order to let it spawn in a loaded chunk. After this, the position is set via the onUpdate method.
this.source.worldObj.spawnEntityInWorld(this.controlledEntity);

 

Registration:

EntityRegistry.registerModEntity(EntityMagicBeam.class, "magic_beam", 0, Main.instance, 128, 1, true);

(I'm actually not quite sure if I registered the entity properly because I read some tutorials which were quite different)

 

 

I hope anybody understands what the problem is or give me at least a hint what may cause problems with this.

Thanks in advance!

[Kwibble]

Have you tried using the different ways of registering entities to see if it makes any difference? The way I register is lime so (semi-pseudo code):

int entityId = EntityRefistry.findSomethingOrOtherId();
EntityRegistry.registerGlobalEntityId(params);
EntityRegistry.registerMidEntity(params);

Wherever I am I am asked to use the id, I use that entityId (I have this in a creatEntity method, so entityId is changed for each entity).

[Bedrock_Miner]

I have created some other mods which just use registerModEntity and this worked but this were Entities which were not controlled by the player.

I think, the Entity itself works... (I think...)

 

EDIT:

Actually the same issue occurs if I change the registration... I have no idea what can cause this because its such a weird behaviour. I checked the posX...posZ vars of the Entity: They have the right values on server but wrong on client. Maybe a sync error? How could I fix this with Entities?

[jabelar]

Is the actual collision box of the entity up in the air, or just the rendered model?  If you really want to visually check where the entity is on the client side you should press F3+B while playing the game -- this will show you the bounding box of the entity.  I recommend doing that with all custom entities.

 

Anyway, I'm suggesting that your entity might actually be in proper position but your model might be rendering in wrong position.  If that is the case, you'll see the bounding box isn't on the entity when you view it.  To fix that you'd have to check whether your model has correct rotation points, or you can also just translate the model during rendering.

[Bedrock_Miner]

Well, at this stage of Entity development I don't use a special renderer, so the Entity is actually a white box which is perfectly aligned with the bounding box.

 

I checked posX, posY and posZ and on client side they DO have wrong values.

I really can't understand this, because I searched for every access to methods or variables which change the position but there is nothing which can cause the error.

 

[jabelar]

The built-in fields for entities should be automatically synced between client and server.  You only have to worry about syncing when you add custom fields. 

 

So assuming you're using built-in posX type fields, then they should be synced.  Note that perhaps you have a typo or perhaps you have accidently declared local variables that are actually being accessed.  In Eclipse you should hover over the posX variables and see what Eclipse says about where they are declared.  You want to confirm that they are the ones you inherited from the Entity class, not something you declared yourself.

 

[Bedrock_Miner]

The corresponding variables are all the default ones, they are not overridden in any way, neither the used methods are.

[Bedrock_Miner]

Maybe this helps:

If I output the values every Tick I get this result:

[15:22:17] [server thread/INFO] [FML]: Position:(10.936262235862642|76.0|12.26463907810521)
[15:22:17] [Client thread/INFO] [FML]: Position:(10.90625|66.0|12.25)

The entity should be 10 blocks above the player who us standing at 10.9|66|12.3.

 

 

 

If I set the height to a constant value (80) and add this line to the client-side only code

this.posY = 80;

I see the Entity still at the player's position but it is placed at y=80 everytime a player moves; and afterwards (1 Tick later) it's set back to the players position.

 

 

This seems to be affected only by the setPosition method, all the other code is ok: I created a new Entity which only adjusts its position to the player's one (with an offset) and this shows the same behaviour.

package com.bedrockminer.magicum.entity.magic;

import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;

import com.bedrockminer.lib.util.render.Vertex;
import com.bedrockminer.magicum.Main;

public class EntityMagicTest extends Entity {

private EntityLivingBase owner;

public EntityMagicTest(World par1World) {
	super(par1World);
}

public EntityMagicTest(World par1World, EntityLivingBase owner) {
	super(par1World);
	this.owner = owner;
	this.copyLocationAndAnglesFrom(owner);
}

@Override
public void onUpdate() {
	super.onUpdate();
	if (!this.worldObj.isRemote && this.owner == null) {
		this.setDead();
		return;
	}
	if (!this.worldObj.isRemote) {
		this.setLocationAndAngles(this.owner.posX, this.owner.posY + 1, this.owner.posZ, 0, 0); //Or setPosition? I think they are similar to each other
		Main.log("OwnerY:" + this.owner.posY + ", thisY:" + this.posY);
	}
	Main.log("Position:" + new Vertex(this.posX,this.posY,this.posZ));
}

@Override
protected void entityInit() {
}

@Override
protected void readEntityFromNBT(NBTTagCompound var1) {
}

@Override
protected void writeEntityToNBT(NBTTagCompound var1) {
}

}

[Kwibble]

Sounds like the server is some how missing the fact it should be at the point you have said. Are you sure there are no syncing issues?

[Bedrock_Miner]

Not sure.

 

And I have no Idea how to find this out or even fix it 

[Bedrock_Miner]

I experimented a bit and encountered the following:

 

-x, y and z value show this behaviour

-The position of the value is the position that was set before spawning the entity, as if the method there was called several times (its only called once, I checked it). If I set the before spawn method to (owner.posX + 5, ...) the Entity is always five blocks away from the owner, no matter how I try to replace it. But the method is in the constructor and only called once, I only use it to ensure the Entity doesn't spawn in an empty chunk!

-The values on client side are slightly different from the once on the server side. Is this normal? (0.0 on Server -> 0.34375 or -0.40625 on client)

[david476]

I use something like:

 

if (!world.isRemote) {

sEntity = new EntityController(world);

sEntity.setPosition(x + 0.5, y + 1, z + 0.5);

float fYaw = DEBClasses_v1.fourRotations(entity.rotationYaw);

sEntity.rotationYaw = fYaw;

sEntity.sX = x;

sEntity.sY = y;

sEntity.sZ = z;

world.spawnEntityInWorld(sEntity);

}

 

might help, definitly works for me with setPosition

[Bedrock_Miner]

I really don't know WHY this bug happens but now I solved it!

If i call the method for updating the position from a tick handler which runs along with the lifetime of the entity it works. Obviously, the entity has somehow no access to itself via the this token. Don't know why, but now its running