[Solved] [1.7.2] Custom Combat - Better alternative to entity.setHealth()? - Modder Support

Posted July 4, 201411 yr

So I have been working on a mod that adds lots of stuff that I randomly think up or that gets suggested to me. Anyway I have started work on adding Dungeons and Dragons type skills. The problem is when I use them for combat it is really buggy. For example I am an Elf who is level 1 with 1 Constitution, 2 Strength, and 3 Dexterity. IN my code i have some equations to calculate the resulting damage. Then I use entity.setHealth(calcHealth); (float health = entity.getHealth(); float calcHealth = health - getTotal(a, d); ) which looks good on the outside but when the entity "dies" it sometimes does a spazzy death animation and keeps fighting.

Sorry if this is confusing, and thanks in advance.

Quote

July 4, 201411 yr

Use 'entity.attackEntityFrom(DamageSource, float amount)' instead of setHealth. EntityLivingBase#damageEntity also has some interesting stuff going on in it, but usually you don't need to mess with that one.

http://i.imgur.com/NdrFdld.png[/img]

Quote

July 4, 201411 yr

Author

I've tried that but it crashes and im not sure why. I have the special combat stuff called in LivingAttackEvent if that would mess things up.

Quote

July 4, 201411 yr

Usually (read: almost always), the crash log will be helpful in figuring out why it crashes.

Usually (read: always), the crash log should be accompanying reports of crashes on the forums.\

Please either use [ spoiler ] tags, or paste your crashlog somewhere meaningful, such as http://gist.github.com/.

Quote

July 4, 201411 yr

Author

Usually (read: almost always), the crash log will be helpful in figuring out why it crashes.

Usually (read: always), the crash log should be accompanying reports of crashes on the forums.\

Please either use [ spoiler ] tags, or paste your crashlog somewhere meaningful, such as http://gist.github.com/.

---- Minecraft Crash Report ----

// I let you down. Sorry

Time: 7/4/14 2:36 PM

Description: Unexpected error

java.lang.StackOverflowError: Unexpected error

at net.minecraftforge.event.entity.living.LivingAttackEvent.setup(LivingAttackEvent.java)

at cpw.mods.fml.common.eventhandler.Event.<init>(Event.java:39)

at net.minecraftforge.event.entity.EntityEvent.<init>(EntityEvent.java:11)

at net.minecraftforge.event.entity.living.LivingEvent.<init>(LivingEvent.java:12)

at net.minecraftforge.event.entity.living.LivingAttackEvent.<init>(LivingAttackEvent.java:14)

at net.minecraftforge.common.ForgeHooks.onLivingAttack(ForgeHooks.java:278)

at net.minecraft.entity.EntityLivingBase.attackEntityFrom(EntityLivingBase.java:832)

at net.minecraft.entity.monster.EntityMob.attackEntityFrom(EntityMob.java:84)

at net.minecraft.entity.monster.EntityZombie.attackEntityFrom(EntityZombie.java:244)

at com.sirniloc.sirs.events.SirPlayerEvent.onCombat(SirPlayerEvent.java:86)

at cpw.mods.fml.common.eventhandler.ASMEventHandler_7_SirPlayerEvent_onCombat_LivingAttackEvent.invoke(.dynamic)

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)