Jump to content

[1.7.2] Custom Block texture won't render properly


Electrobob99

Recommended Posts

Basically, with the current mod I am trying to port, which is "Rise of the Automatons", I've hit a bit of a snag. Basically one of the blocks added won't render properly. Based on the old code it seems he was able to render it within one class, but it doesn't seem to work. Ironically I utilized similar processes for another block and it rendered exactly. Here is the unported code, and current code. I know some of the current code may be redundant, but It shall be cleaned up.

Unported:

 

public class AM_BlockGlow extends Block
{

    protected AM_BlockGlow(int i, int j)
    {
        super(i, j, Material.glass);
  float f = 0.1875F;
float f2 = 1F-f;
this.setBlockBounds(f,0,f,f2,1F-0.5F,f2);
if(j==AutomatonLogger.glowy){
loadSprites1();
}else{
loadSprites2();
}
       
    }
/*public int idDropped(int i, Random random)
{
return Item.energy.shiftedIndex;
}*/


    public int D[];
//public static int E[]={1,1};
public void loadSprites1(){

D=new int[2];
D[0]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/crystal1.png");
D[1]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/crystal2.png");
blockIndexInTexture=D[0];


/*E=new int[2];
E[0]=D[0];
E[1]=D[1];*/
}
public void loadSprites2(){
D=new int[2];
D[0]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/glowy1.png");
D[1]=AutomatonUniversal.modOverride("/terrain.png", "/automatons/glowy2.png");
blockIndexInTexture=D[0];


}

    public AxisAlignedBB getCollisionBoundingBoxFromPool(World world, int i, int j, int k)
    {
        float f = 0.25F;
        return AxisAlignedBB.getBoundingBoxFromPool((float)i + f, j, (float)k + f, (float)(i + 1) - f, (float)(j + 0.5F), (float)(k + 1) - f);
    }

    public AxisAlignedBB getSelectedBoundingBoxFromPool(World world, int i, int j, int k)
    {
        float f = 0.25F;
        return AxisAlignedBB.getBoundingBoxFromPool((float)i + f, j, (float)k + f, (float)(i + 1) - f, (float)(j + 0.5F), (float)(k + 1) - f);
    }


    public int getBlockTextureFromSide(int i)
    {


if(i <=1 )
        {
            return D[1];
        } else
        {
            return D[0];
        }

        
    }


    public boolean renderAsNormalBlock()
    {
        return false;
    }

    public boolean isOpaqueCube()
    {
        return false;
    }

    public int getRenderType()
    {
        return 13;
    }

    public boolean canPlaceBlockAt(World world, int i, int j, int k)
    {
        if(!super.canPlaceBlockAt(world, i, j, k))
        {
            return false;
     } else
      {
         return canBlockStay(world, i, j, k);
     }
  }


    public boolean canBlockStay(World world, int i, int j, int k)
    {

        if(world.getBlockMaterial(i, j-1, k ).isSolid())
        {
            return true;
        } else
        {
            return false;
        }
    }

}

 

 

Current:

 

public class AM_Shard extends Block {


@SideOnly(Side.CLIENT)
private IIcon[] texture;

public static String block1;
public static String block2;
public static String block3;
public static String block4;
public int D[] = {27, 28};

final static String[] subBlocks = new String[] {block1, block2};

public AM_Shard(String name1, String name2) {
	super(Material.rock);
	block1 = name1;
	block2 = name2;
	this.setCreativeTab(AM_CreativeTabs.tabBlock);
	this.setHarvestLevel("pickaxe", 2);
	this.setHardness(4.5F);
	this.setStepSound(Block.soundTypeStone);
	float f = 0.1875F;
	float f2 = 1F - f;
	this.setBlockBounds(f, 0F, f, f2, 1-0.5F, f2);
	this.loadSprites(27, 28);

}

@Override
public boolean renderAsNormalBlock() {
	return false;
}

@Override
public int getRenderType() {
	return 13;
}

public Block loadSprites(int i, int j) {
	this.D[0] = i;
	this.D[1] = j;
	return this;
}

@Override
public AxisAlignedBB getSelectedBoundingBoxFromPool(World par1World, int i, int j, int k) {

	float f = 0.25F;
	return AxisAlignedBB.getBoundingBox((float) i + f, j, (float) k + f, (float) (i + 1) - f, (float) (j + 0.5F), (float) (k + 1) - f);
}

@Override
public AxisAlignedBB getCollisionBoundingBoxFromPool(World par1World, int i, int j, int k) {

	float f = 0.25F;
	return AxisAlignedBB.getBoundingBox((float) i + f, j, (float) k + f, (float) (i + 1) - f, (float) (j + 0.5F), (float) (k + 1) - f);
}

@Override
public boolean isOpaqueCube() {
	return false;
}


@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister){
	texture = new IIcon[subBlocks.length];

	for(int i = 0; i < subBlocks.length; i++){
		texture[0] = iconRegister.registerIcon(Strings.MODID + ":" + "crystal2");
		texture[1] = iconRegister.registerIcon(Strings.MODID + ":" + "crystal1");


	}
}

@SideOnly(Side.CLIENT)
public void getSubBlocks(Item block, CreativeTabs creativeTabs, List list){

	for(int i = 0; i < subBlocks.length; i++){
		list.add(new ItemStack(this, 1, i));
	}
}

@SideOnly(Side.CLIENT)
@Override
public IIcon getIcon(int side, int meta){
	{
		if(side == 0 || side == 1){
			return texture[1];
		}
		else{
			return texture[0];
		}
	}
}

public int damageDropped(int meta){
	return meta;
}


}

 

So any help here on why it's not rendering correctly?

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

First of all remove that "loadSprites" stuff (and everything related to it). It's from the old ModLoader days. Please define what you mean by "don't render properly".

Ok, the loadsprites stuff I mentioned as "Redundant". But on the topic of what I mean is this:

 

 

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

Well, I'm trying to keep it similar to the old code, besides I have no idea what one would work, since the ones I've tested before still give the same results as the cactus one.

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

If you don't override getRenderType at all, what does it look like?

Ok I completely removed getRenderType, and it now looks like how it looked with a render type :( I even saved and double checked

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

Hrm, that is weird. Are you sure you didn't screw up the texture?

Hmm, I didn't think so, because I've been using code and textures that were used before by the original modder. I can bring up it's old github repository, linked below.

https://github.com/Aninon/Automatons

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

Oh god, that's ... a mess. "Let me just include allll the files in this repo..." Yay.

Again: I really can't see anything in your code that would cause this, except a broken texture (or maybe your block bounds).

Hmm, I'd assume that I either adjust the pixel locations in the texture file until it reads it correctly, or change the block bounds.

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

Ok I feel stupid now, found the problem, throughout the coding process I seemed to have misnamed the textures, and used the top texture as the side texture. *facepalm That's why it messed up xD

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • version used : minecraft forge 1.20.1 Logs : https://bytebin.lucko.me/rtG4EA0vfb hi! so when i try to create a new minecraft world in single player, it just crashes?? does anyone has an idea what could be causing this ?
    • Hey today I was trying to play in 1.21 modpack that I made on fabric (my version of fabric is in 0.16.0) with this list of mods : - Entity Model Features (by traben_0) - Entity Texture Features (by traben_0) - Advanced Chat (by Wesley8081) - Ambient Environment (by Jaredlll08) - Ambient Souds 6 (by CreativeMD) - Animatica (by FoundationGames) - Armor Statues (by Fuzs) - Auto HUD (by Crendgrim) - Bad Packets (by badasintended) - Balm (by BlayTheNinth) - Better Beds (by Motschen) - Better Chunk Loading (by someaddon) - Better Compatibility Checker (by Gaz-) - Better FPS [Render Distance] (by someaddon) - Better Ping Display (by Quintinity) - Better Statistics Screen (by TheCSDev) - Better Armor HUD (by efekos) - Better F3 ( by cominixo) - Blur + (by Motschen) - Bobby (by Johni0702) - Cat Jam (by shmove) - Catalogue (by MrCrayfish) - Chat Heads (by dzwdz) - Cherished Worlds (by TheIllusiveC4) - Chunk Sending (by someaddon) - Chunks Fade In (by kerudion) - Chunky (by pop4959) - Cloth Config (by shedaniel) - Clumps (by Jaredlll08) - Cobweb (CrystalSpider) - Collective (by Serilum) - Configured (by MrCrayfish) - Connectivity (by someaddon) - Continuity (by Pepper_Bell) - Creative Core (by CreativeMD) - Cupboard (by someaddon) - Cut Through (by Fuzs) - Dark Loading Screen (by Neecko5b84) - Debugify (by XanderIsDev) - Double Doors (by Serilum) - Dynamic FPS (by juliand665) - Dynamic Lights (by Tschipcraft) - Easy Anvils (by Fuzs) - Easy Magic (by Fuzs) - Easy Shulker Boxes (by Fuzs) - Eating Animation (by theone-ss) - Enhanced Attack Indicator (by Mineash) - Enhanced Block Entities (by FoundationGames) - Enhanced Visuals (by CreativeMD) - Entity Culling (by tr7zw) - Environmental Water (by AgentMindStorm) - Essential (by SparkUniverse_) - Extra Thicc Packets (by JaselUmena) - Fabric (by modmuss50) - Fabric Language Kotlin (by modmuss50) - Falling Leaves (by RandomMcSomethin) - Fancy Block Particles (by Hantonik) - Fancy Health Bar (by efekos) - Farsight (by someaddon) - Fast IP Ping (by Fallen_Breath) - Ferrite Core (by  malte0811) - Fish On The Line (by Serilum) - Fix GPU Memory Leak  (by someaddon) - Forge Config API Port (by Fuzs) - FPS Reducer (by bre2el) - Freecam (by hashalite) - Fzzy Config (by fzzyhmstrs) - Get It Together (by bl4ckscor3) - Global Packs (by JTK222) - Harvest With Ease (by CrystalSpider) - Ichuntil Util (by iChun) - Immediately Fast (by RaphilMC) - Immersive UI (by SSKirillSS) - Indium (by comp500) - Inventory HUD+ (by dmitrylovin) - Iris Shaders (by coderbot) - Item Physic Full (by CreativeMD) - Jade (by Snownee) - Journey Map (by techbrew) - Just Enough Breeding (by Christofmeg) - Just Enough Items (by mezz) - Just Enough Professions (by Mrbysco) - Language Reload (by Jerozgen) - Leaves Be Gone (by Fuzs) - Let Me Despawn (by frikinjay) - Let Sleeping Dogs Lie (by iChun) - Lithium (by JellySquid) - Loading Backgrounds (by Lupin) - Mineblock's Repeated Utilities (by itsmineblock11) - Menulogue (by MrCrayfish) - Mob Plaques (by Fuzs) - Mod Menu (by Prospector) - Model Gap Fix (by MehVahdJukaar) - Mouse Tweaks (by YaLTeR) - Nether Portal Fix (by BlayTheNinth) - Nicer Skies (by ztereohype) - Noisium (by Steveplays28) - Not Enough Animations (by tr7zw) - Opti GUI (by opekope2) - Packet Fixer (by TonimatasDEV) - Particle Core (by fzzyhmstrs) - Passive Shields (by Serilum) - Pick Up Notifier (by Fuzs) - Ping Wheel (by LukenSkyne) - Puzzle (by Motschen) - Puzzles LIB (by Fuzs) - Reese's Sodium Options (by FlashyReese) - Resource Pack Overrides (by Fuzs) - Server Country Flags (by khajiitos) - Server Performance (by someaddon) - Skin Layer 3D (by tr7zw) - Sodium (by JellySquid) - Sodium Extra (by FlashyReese) - Sodium Shadowy Path Blocks (by Rynnavinx) - Sound Physics Remastered (by henkelmax) - Sounds (by itsmineblock11) - Spark (by lucko) - Stack Refill (by Serilum) - Structure Essentials (by someaddon) - TCD Commons API (by TheCSDev) - Text Placeholder API (by Patbox) - Villager Names (by Serilum) - Visual Overhaul (by Motschen) - Visual Workbench (by Fuzs) - Visuality (by PinkGoosik) - Wakes (by Goby56) - Wavey Capes (by tr7zw) - YDM'S Weapon Master  (by YourDailyModderx) - Yet Another Config LIB (by XanderIsDev) - Zoomify (by XanderIsDev) And When I load it it work, I can create a world and even let him open forever at least I didn't move cause if so the game just crash and tell me this message :   Encountered an unexpected exception net.minecraft.class_148: Ticking entity at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1025) at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:912) at net.minecraft.class_1132.method_3748(class_1132.java:114) at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:697) at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) at java.base/java.lang.Thread.run(Thread.java:1583) Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_4706.isEmpty()" because "tickets" is null at net.minecraft.class_3204.canNoneExpire(class_3204.java:1034) at net.minecraft.class_3204.handler$dln000$lithium$unregisterExpiringTicket(class_3204.java:1075) at net.minecraft.class_3204.method_17645(class_3204.java:172) at net.minecraft.class_3204.method_17292(class_3204.java:194) at net.minecraft.class_3215.method_17300(class_3215.java:443) at com.betterchunkloading.chunk.PlayerChunkData.checkPrediction(PlayerChunkData.java:406) at com.betterchunkloading.chunk.PlayerChunkData.checkDirection(PlayerChunkData.java:353) at com.betterchunkloading.chunk.PlayerChunkData.trackPlayerMovement(PlayerChunkData.java:177) at com.betterchunkloading.chunk.PlayerChunkData.onChunkChanged(PlayerChunkData.java:130) at com.betterchunkloading.event.EventHandler.onPlayerTick(EventHandler.java:200) at net.minecraft.class_3222.handler$zed000$betterchunkloading$onPlayerTick(class_3222.java:2618) at net.minecraft.class_3222.method_5773(class_3222.java:564) at net.minecraft.class_3218.mixinextras$bridge$method_5773$202(class_3218.java) at net.minecraft.class_3218.wrapOperation$eei000$puzzleslib$tickNonPassenger(class_3218.java:7797) at net.minecraft.class_3218.method_18762(class_3218.java:770) at net.minecraft.class_1937.method_18472(class_1937.java:498) at net.minecraft.class_3218.method_31420(class_3218.java:408) at net.minecraft.class_5574.method_31791(class_5574.java:54) at net.minecraft.class_3218.method_18765(class_3218.java:372) at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1021) ... 5 more Sorry guys if it obvious but actually I'm an old player of Minecraft but I'm new in modding so yup. But Thanks everyone by advance to help me with this.
    • These forums are for Minecraft Forge, not Fabric. You would probably be better served posting this question wherever fabric support is given, most likely their discord server.
    • Add the new latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here
    • Update: I tried to reproduce the bug and found out that if I place a flare on a block and then dismantle it with the pickarang (Quark), the flare gets no NBT Tag after getting assigned an empty one through the offhand.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.