[1.7.2] [SOLVED]Problem with giving items on first join

[RedEnergy]

Hello everyone. I need to give player items on their first join. I am using event (code below)

@SubscribeEvent
   public void firstJoin(PlayerLoggedInEvent event) {
      EntityPlayer player = event.player;
      NBTTagCompound entityData = player.getEntityData();
      if(entityData.getBoolean("firstJoin")) {
         entityData.setBoolean("firstJoin", false);
         player.inventory.addItemStackToInventory(new ItemStack(Items.compass));
      }
   }

but it's do nothing. Where did I go wrong?

 

P.S. Sorry for my bad english. Its not my native language.

[shieldbug1]

Your getBoolean is always returning false, unless you set it elsewhere.

 

Try using !entitydata.getBoolean("firstJoin") and then set it true.

[jabelar]

You should try to trace the code to see if it is behaving as expected.  For example, put some console statements at certain points.  Like you should print out the value retrieved for the entityData.getBoolean("firstJoin") to see if it is actually true. 

 

Now I think it won't work because you don't show any code that creates the firstJoin tag.  Therefore, the first time it tests for it, there will not be any tag and in the case of getBoolean() that will return a false.  So it is going to return false always as far as I can tell.

 

I think you really want to flip the logic because first join will return false.  Instead maybe try this way:

@SubscribeEvent
   public void firstJoin(PlayerLoggedInEvent event) {
      EntityPlayer player = event.player;
      NBTTagCompound entityData = player.getEntityData();
      if(!entityData.getBoolean("joinedBefore")) {
         entityData.setBoolean("joinedBefore", true);
         player.inventory.addItemStackToInventory(new ItemStack(Items.compass));
      }
   }

 

[RedEnergy]

Really thanks