Adding an new SkyProvider

[micdoodle8]

Hey,

 

I've tried creating a new instance of my SkyProvider by adding:

 

this.setSkyProvider(new CustomSkyProvider());

 

into the constructor. Inside the render method in the sky provider I added a log output to see if the method was called, and nothing happens. Is this feature broken in the latest builds, or do you set the Sky Provider some other way?

 

Using build #269

 

Thanks.

 

Edit: After further investigation, the sky renderer works the first time you join the dimension, but after leaving and joining again it goes back to the old sky.

[LexManos]

Worlds are destroyed every time you move from them.

[micdoodle8]

So... SkyProvider is useless most of the time.

 

Wouldn't there be a way to fix that?

 

Edit: Found the problem,

FMLClientHandler.instance().getClient().theWorld instanceof CustomWorldProvider

returns true when you join the world for the first time, but after logging back in again, returns false.

[LexManos]

How are you setting the world provider?

Either way, if you're doing it based off that then thats the issue, but there are World.Load events that you can use to register things.

[micdoodle8]

I thought you just had to register the provider and providertype, since the provider is set through the WorldClient on client-side, which gets the provider from DimensionManager.

 

Edit: In the for loop on line 230 of MinecraftServer.java, is DimensionManager.getIDs() supposed to have a length of zero? That's where I traced the problem back to.

 

Edit2: Nevermind, the problem was WorldProvider.setDimension(id) was setting the wrong variable, submitted a pull request.