Change Entity.boundingBox to use getter/setter

[Vinther]

I'm sorry if this isn't possible for whatever reason I just don't realize, but it bugs me that boundingBox is currently a 'final' field, and I think it would be much better and more flexible if it was changed to use getter/setter methods.

 

What made me think of this is that I recently had a cool (in my opinion at least ) idea, involving a custom collider class extending AxisAlignedBB, which would allow a much more complex hitbox for my large, animated entity.

 

What do you guys think?

[Vinther]

Hmm. I was afraid it would turn out to be more complex than I thought. To me it seems like you could just do a simple find&replace from 'boundingBox' to 'getBoundingBox()'. Since the field is final it can never be assigned anywhere, so you wouldn't even need to check for that.

 

Guess there's more to it, huh?

[Vinther]

Haha! I guess I am a bit lazy, although the specific thing I had in mind cannot really be done with multiple entities, and it would actually allow for more complex colliders than AABB's, which I think would be beneficial for everyone. Also I was thinking this could be done in the process of upgrading to 1.8, at which point everyone will need to update anyway.

 

But yea, it might be a bit much of a hassle.

[Vinther]

Ok, I hear you. But hey! Could we just make the field non-final then? That might actually work as well, and wouldn't break anything, would it?

[Vinther]

I have no idea how that kind of stuff works, though. The whole process is a bit intimidating to me. But I'll look into it.

[LexManos]

This can be done without any base edits, you can do it yourself So most likely it will not be accepted unless you provide a good reason.

[Vinther]

What do you mean? I can make Entity.boundingBox not be final, without base edits? Or are you saying I could do what I'm asking even when it is final? I don't think so.

 

I'll try to clarify. What I'm trying to do is to write a custom collider class that extends AxisAlignedBB and overrides some of its methods, and assign it as the boundingBox of my entity. This way I could for example use boolean operations with intersecting bounding boxes, to create complex collider shapes.

 

How would I do this without editing base classes, when boundingBox is final?

[LexManos]

I can make Entity.boundingBox not be final, without base edits?

Yes

Or are you saying I could do what I'm asking even when it is final?

Yes

 

Nothing you are wanting to do requires base edits.

Please do some research and try to solve your own problems. Its actually rather simple and is done quite often in Minecraft. There is a plethora of ways to deal with it.

[Vinther]

I'm very curious about how you suppose I would make it non-final, when it is not possible to override member fields in an extending class.

 

And when you say it can be done anyway, I must say I think you don't understand what I'm saying. Maybe I'm not explaining well enough. I am not trying to add different boxes together to form a multi-part shape. I want to "subtract" parts of the bounding box, making a raytrace pass through it.

 

I have certainly made a fair bit of research already, but if you know of something that I've missed, please point me in the right direction.

[LexManos]

I know exactly what you want to do.

And I know you can do it without editing base classes

You have reflection

You have ATs

You have many alternatives.

 

[Vinther]

Okay, cool! I have not yet learned what those are, and wouldn't have thought to do so any time soon. I will look into them right away.

 

Thanks for the help!