Jump to content

Recommended Posts

Posted

Ok what I ask is simple, how would I go about using an ENUM file listing to be used successfully with making blocks with subBlocks? I ask this because I have gotten it to work with items, (added almost 32 subitems), but for blocks I am a bit lost? How can I get it to work? Probably a stupid mistake.

 

Here is my working item's files:

 

 

public enum EnumCraftSetType {
LENS("lens", "Lens"),
EYEPIECE("eyePiece", "Eye Piece"),
STONECOG("stonecog", "Stone Cog"),
LOOP("loop", "Metal Ring"),
CHAIN("chain", "Chain"),
SPROCKET("sprocket", "Sprocket"),
JOINT("joint","Joint"),
SHARP("sharp", "Sharpened Point"),
SMALLPLATE("smallPlate", "Small Plate"),
CYLINDER("cylinder", "Cylinder"),
ROD("rod", "Rod"),
PISTON("piston", "Tiny Piston"),
ACTUATOR("actuator", "Soul Actuator"),
CANVAS("canvas", "Canvas"),
WING("wing", "Wing"),
PASSIVE("passive", "Controller (Passive)"),
AGGRESSIVE("aggressive", "Controller (Aggressive)"),
JAW("jaw", "Jaw"),
SENSOR("sensor", "NVS"),
DRILL("drill", "Pickaxe Module"),
ROLLERCHAIN("rollerChain", "Roller Chain"),
SMALLHEAD("wHead", "Small Head"),
SMALLBODY("smallBod", "Small Body"),
TOTEHEAD("totehead", "Tote Head"),
MIDBODY("medBod", "Greater Body"),
SMALLLEG("smallLeg", "Small Leg"),
SENTRYHEAD("sHead", "Sentry Head"),
SALT("salt", "Salt"),
SURF("sulf", "Sulf"),
FACTOTUMHEAD("factotumhead", "Factotum Head"),
FACTOTUMCHUNK("furnaceChunk", "Factotum Chunk"),
BLUECORE("automatonCore", "Blue Core"),
REDCORE("superCore", "Red Core"),
PLANTMATTER("planty", "Plant Matter"),
PARTICULATE("bitty", "Cybernetic Particulate"),
BIONICCONGLOMERATE("ABC", "Adaptive Bionic Conglomerate");

public final String name;
public final String fullname;

EnumCraftSetType(String par1, String par2) {
	this.name = par1; //png name
	this.fullname = par2;
}

 

public class ItemCraftSet extends Item{

private IIcon icons[];

public ItemCraftSet(){
	super();
	this.setHasSubtypes(true);
	this.setMaxDamage(0);
	this.setUnlocalizedName("am:craftset");
	this.setCreativeTab(AM_CreativeTabs.tabItem);

}

@Override
public IIcon getIconFromDamage(int par1){
	int i = MathHelper.clamp_int(par1, 0, EnumCraftSetType.values().length-1);
	return icons[i];
}

@Override
@SideOnly(Side.CLIENT)
public void registerIcons(IIconRegister iconregister){
	icons = new IIcon[EnumCraftSetType.values().length];
	for(int var4 = 0; var4 < EnumCraftSetType.values().length; var4++){
		icons[var4] = iconregister.registerIcon("am:"+EnumCraftSetType.values()[var4].name);
	}
}

@Override
public void getSubItems(Item par1, CreativeTabs creativeTabs,
		List list){
	for(int var4 = 0;var4 < EnumCraftSetType.values().length; var4++){
		list.add(new ItemStack(par1, 1, var4));
	}
}

@Override
public String getUnlocalizedName(ItemStack itemStack){
	return super.getUnlocalizedName(itemStack) + "."
			+ EnumCraftSetType.values()[itemStack.getItemDamage()].name;
}
}

 

 

 

Here is the non working subBlock files:

 

 

public enum EnumCropType {

WHEAT("wheat", "Wheat"),
POTATOES("potatos","Potatoes"),
CARROTS("carrots","Carrots"),
MELON("melon","Melon"),
PUMPKIN("pumpkin","Pumpkin"),
NETHERWART("nether_wart","Nether Wart"),
MUSHROOMR("mush_wred","Mushroom"),
MUSHROOMBR("mush_brown","Mushroom"),
SUGARCANE("sugar_cane","Sugar Cane"),

;



public final String name;
public final String fullname;

EnumCropType(String par1, String par2){
	this.name = par1; //png name
	this.fullname = par2;
}
}

 

public class BlockCropage extends Block {

@SideOnly(Side.CLIENT)
private IIcon[] icons;

public BlockCropage(){
	super(Material.plants);
	this.setTickRandomly(true);
	float f = 0.5F;
	this.setBlockBounds(0.5F - f, 0.0F, 0.5F - f, 0.5F + f, 0.25F, 0.5F + f);
	this.setCreativeTab(CreativeTabsPLM.tabBlock);
	this.setHardness(0.0F);
	this.setStepSound(soundTypeGrass);
	this.disableStats();
	//this.setBlockName(name);
}

@Override
public boolean isOpaqueCube(){
	return false;
}

public int getRenderType()
    {
        return 6;
    }

@Override
public boolean renderAsNormalBlock() {
	return false;
}

@SideOnly(Side.CLIENT)
public void getSubBlocks(Item block, CreativeTabs creativeTabs, List list){

	for(int i = 0; i < EnumCropType.values().length; i++){
		list.add(new ItemStack(block, 1, i));
	}
}


@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister){
	//icons = new IIcon[15];
	icons = new IIcon[EnumCropType.values().length];
	icons[0] = iconRegister.registerIcon("plantmo" + ":" + "carrots_stage_0");	
	icons[1] = iconRegister.registerIcon("plantmo" + ":" + "template_stage_7");
	for(int pun = 0; pun < EnumCropType.values().length; pun++){
	  icons[pun] = iconRegister.registerIcon("plantmo:"+EnumCropType.values()[pun].name);
	}		
}	

@SideOnly(Side.CLIENT)
@Override
public IIcon getIcon(int side, int meta){
 switch(meta){
	case 0:
		return icons[1];
	default:
		return icons[0];

	}
}


}

 

public class ItemblockCropage extends ItemBlockWithMetadata{

public ItemblockCropage(Block block) {
	super(block, block);
	this.setHasSubtypes(true);
}

public String getUnlocalizedName(ItemStack itemstack){
	int i =  itemstack.getItemDamage();
	if (i < 0 || i >= EnumCropType.values().length){
		i = 0;
	}
	return getUnlocalizedName() + "." + EnumCropType.values().length;
}

public int getMetaData(int damageValue){
	return damageValue;
}


}

 

 

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

You say it does not work. What does not work? What happens? What did you expect to happen instead?

Well for one I get a terminated console/minecraft instance (with the codes I provided), said that a block was already initialized. I expected it to load blocks equal to the amounts in the ENUM file. I probably adjusted the block files with the wrong data, but for the life of me I can't figure out what that data could be, one reason why I displayed the code I used, so I could get help finding what code is wrong in it. :( Because I technically adjusted metadata block code with code I knew worked with the "Enum" items, with adjustments seen in the code in the OP.

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Posted

Ok, so figured out my dumb mistake, seems I Imported the wrong item class from minecraft *facepalm

But now I have another problem, aswell as a question. The problem I am having, is that while the correct number of them are created i.e 9 of them, they all have the same basic name of: tile.PlanterBlocks.9.name. Any idea on this, will look into get unlocalized name methods, probably the issue to be honest, since from the looks of it, I had it set to "return getUnlocalizedName() + "." + EnumCropType.values(). Which would explain why it was giving the total in the name. Also how would I be able to decide what icon/texture it needs easily? Just the getUnlocalizedName is needed to be resolved :)

 

Strike that, so simple to fix, all I had to do was make the getUnlocalizedName method return "getUnlocalizedName() + "." + ENUMFILENAME.values()..name"  "i" being "itemstack.getItemDamage()" and "name" being set in the ENUM file :) Yay I am learning :)

Member of Aerotech Networks, a Multi-Gaming server.

Also Currently porting the "Rise of the Automatons" minecraft mod

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.