[Solved][1.7.10] Packet Memory Leakage?

[Mecblader]

I had a packet handling system that worked when I updated from 1.7.2 to 1.7.10, but a message started to appear, saying:

 

Detected ongoing potential memory leak. 100 packets have leaked. Top offenders

[07:50:36] [server thread/ERROR] [FML]: packetCageData : 100

 

So i googled a solution and I found this thread : http://www.minecraftforge.net/forum/index.php?topic=20567.0

 

It turns out I did follow the tutorial that Jabelar had posted a link to saying that this method of packetHandling causes memory leaks. So I used the other link posted in his post and I followed the tutorial, but I still end up with the message saying the same exact message. I'm not too good with this packet stuff, so I don't really know how to fix it. I would appreciate if someone can tell me what I am doing wrong. All help is appreciated, Thank You!

 

PacketCode:

 

package mod.xtronius.htsm.packet;

import java.io.IOException;

import cpw.mods.fml.common.network.ByteBufUtils;
import cpw.mods.fml.common.network.simpleimpl.IMessage;
import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;
import cpw.mods.fml.common.network.simpleimpl.MessageContext;
import io.netty.buffer.ByteBuf;
import mod.xtronius.htsm.tileEntity.TileEntityCage;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.EntityList;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;

public class PacketCageData implements IMessage{

String entityID;
int x;
int y;
int z;

public PacketCageData(){}
    
    public PacketCageData(String entityID, int x, int y, int z) {
        this.entityID = entityID;
        this.x = x;
        this.y = y;
        this.z = z;
    }

@Override
public void fromBytes(ByteBuf bytes) {
	this.entityID = ByteBufUtils.readUTF8String(bytes);
	this.x = bytes.readInt();
	this.y = bytes.readInt();
	this.z = bytes.readInt();
}

@Override
public void toBytes(ByteBuf bytes) {
	ByteBufUtils.writeUTF8String(bytes, this.entityID);
	bytes.writeInt(this.x);
    bytes.writeInt(this.y);
	bytes.writeInt(this.z);
}

public static class Handler implements IMessageHandler<PacketCageData, IMessage> {
        
        @Override
        public IMessage onMessage(PacketCageData message, MessageContext ctx) {
        	
        	TileEntityCage tileEntity = (TileEntityCage) Minecraft.getMinecraft().theWorld.getTileEntity(message.x, message.y, message.z);
        	if(tileEntity != null && message.entityID != null) {
        		tileEntity.targetEntityID = message.entityID;
        	} else System.out.println("FAILED!!!");
            return message;
        }
    }
}

 

 

Channel Init Code (is being called in the pre init event):

 

network = NetworkRegistry.INSTANCE.newSimpleChannel("packetCageData");
	 network.registerMessage(PacketCageData.Handler.class, PacketCageData.class, 0, Side.CLIENT);

 

 

The Code That Sends The Data:

 

HTSM.network.sendToAll(new PacketCageData(this.entityData.getString("id"), this.xCoord, this.yCoord, this.zCoord));

 

[Mecblader]

I am using Forge Version 1.7.10-10.13.0.1208.

[Mecblader]

This is the only packet I have in the mod. Could this be a bug in forge or do you think I am doing something stupid?

[Mecblader]

Then do you know of any open source mod that have an implementation of this so I can compare their code to mine to see what I am doing wrong?

[Mecblader]

Oh, I just realized why it was giving me the message. For some reason when you return the message in the onMessage method it gives that message.

[dfmsguitar]

Apologies for replying to a post that's 2 years old, but I ran into this same error earlier using the SimpleNetworkWrapper method, and somebody else might stumble across this thread who's trying to debug this issue.  If you attempt to send Packets to Client Side from the server, but your PacketHandler class calls registerMessage with the wrong Handler side, you will also see this error without much of a helpful explanation.

 

// below is wrong and will cause this Packet Leak error.
// PacketHandler class
this.INSTANCE.registerMessage(PacketAddCraftingSkill.Handler.class, PacketAddCraftingSkill.class, 6, Side.SERVER);

// Sending function
ModName.INSTANCE.sendTo(new PacketAddCraftingSkill(1), (EntityPlayerMP)this.player);