Jump to content

[1.7.10] onEntityCollidedWithBlock does not get triggered [solved]


Recommended Posts

Posted

Hey Guys,

 

i need your help. I started to mod Minecraft using Forge some days ago. Now i would like to make a Block that gives LivingEntites and Players a potion effect if they collide with it. I looked it up in the tutorial section and i tried to implement it the same way they did. It won't work. So i started to check if the method is called with System.out.println("onEntityColliedWithBlock triggered"). I dont get the console message that at least the method has been called. Please help me ;).

 

Here is my code:

package skrillor.basemod.common;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.item.Item;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.world.World;

public class BasicOre extends Block {

public BasicOre(Material material) {
	super(material);

	setHardness(4.0F);
	setStepSound(Block.soundTypeStone);
	setBlockName("basicOre");
	setCreativeTab(CreativeTabs.tabBlock);
}

@Override 
public Item getItemDropped(int metadata, Random random, int fortune) {
	return Item.getItemById(57);
}

public void onEntityCollidedWithBlock(World par1World, int par2, int par3, int par4, Entity par5Entity) {
	System.out.println("onEntityCollidedWithBlock passed");

	par1World.setBlockToAir(par2, par3, par4);
}

}

 

If you need anything else to help me i'll show it to you. Thanks

 

Edit: Solved

Posted

This function is called when entity is inside block. It is not possible if your block is full-sized cube. Set custom bounds for your block.

 

Thanks, now i got it right. I set custom bounds that the Y-bound is just 0.99 and not 1. So u go into the block and the method is triggered.

Here is my solution

	@Override
public AxisAlignedBB getCollisionBoundingBoxFromPool(World par1World, int x, int y, int z) {
	return AxisAlignedBB.getBoundingBox(x, y, z, x+1, (double) y + 0.99 , z+1);
}

 

Posted

Just use setBlockBounds(...) in block constructor.

 

Like Eternaldoom said, this affects the Rendering, this means if i set the Y-Bounds to 2.0F u will get a block that is 2 blocks high and seems to be bugged when you still using normal textures.

Posted

Just use setBlockBounds(...) in block constructor.

 

Like Eternaldoom said, this affects the Rendering, this means if i set the Y-Bounds to 2.0F u will get a block that is 2 blocks high and seems to be bugged when you still using normal textures.

 

Are you guys sure about that?  If you follow the code the only relationship to rendering seems to be that if you have a side that has width 0 it won't render the side, and the selection box (the thin black box when your mouse goes over a block) will be affected though, but that is sort of the point because it shows you where you can hit the block.

 

Also, I thought the original question above was to enable colliding with the block.  In that case you should be making the bounds smaller, not larger.  Why are you trying to make the bounds 2.0 high?

 

Anyway, if you want a more flexible way of controlling the collision box, @Override the getSelectedBoundingBoxFromPool() and possibly the addCollisionBoxesToList() methods.  The latter is interesting because you can do things like change the collision box depending on the entity type (because entity is passes as parameter).  These definitely do NOT affect rendering.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Back then there was a number which determined the tier of an item and block. If the block tier is lower or equal to the item number, the block would be mined. this however, has changed and now it goes by "needs_netherite_tool" which is fine, until you realized that some mods had items and blocks that exceeded these values. You can make you own "needs_mod_tool" but I feel that this is more limiting(and just more work) than before. So is there anyway to use something similar to the old tier system while also still being compatible with a lot of other mod tools?
    • Well, when I log in to the server, sometimes within an hour, sometimes within a minute, the server closes and informs me that there was a Ticking entity error. Below is the crash report
    • Try switching to Windowed or Borderless Window mode in Minecraft. These modes make it easier for the recorder to capture gameplay, as it still has access to the display without the game taking up all of the graphics resources.
    • This forum is for Forge, not NeoForge. Please go to them for support.
    • Forge version: 55.0.0 Minecraft version: 1.21.5 Downloads: As this is the start of a new version, it is recommended that you check the downloads page and use the latest version to receive any bug fixes. Downloads page Intro: Good evening! Today, we have released our initial build of Forge 55.0 for Minecraft 1.21.5. 1.21.5 is the newest member of the 1.21 family of versions, which was released yesterday on March 25, 2025. As a reminder, the first minor (X.0) of a Forge version is a beta. Forge betas are marked as such on the bottom left of the title screen and are candidates for any breaking changes. Additionally, there are a couple of important things to note about this update, which I've made sure to mention in this post as well. Feel free to chat with us about bugs or these implementation changes on GitHub and in our Discord server. As always, we will continue to keep all versions of 1.21 and 1.20 in active support as covered by our tiered support policy. Cheers, happy modding, and good luck porting! Rendering Refactor For those who tuned in to Minecraft Live on March 22, 2025, you may already know that Mojang have announced their intention to bring their new Vibrant Visuals overhaul to Java in the future. They've taken the first steps toward this by refactoring how rendering pipelines and render types are handled internally. This has, in turn, made many of Forge's rendering APIs that have existed for years obsolete, as they (for the most part) can be done directly in vanilla. If there was a rendering API that was provided by Forge which you believe should be re-implemented, we're happy to discuss on GitHub through an issue or a pull request. Deprecation of weapon-like ToolActions In 1.21.5, Minecraft added new data components for defining the characteristics of weapons in data. This includes attack speed, block tags which define efficient blocks, and more. As such, we will begin marking our ToolActions solution for this as deprecated. ToolActions were originally added to address the problem of creating modded tools that needed to perform the same actions as vanilla tools. There are still a few tool actions that will continue to be used, such as the shears tool action for example. There are some existing Forge tool actions that are currently obsolete and have no effect given the way the new data components are implemented. We will continue to work on these deprecations and invite you to chat with us on GitHub or Discord if you have any questions.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.