Removing XP From Player

[elfin8er]

I'm attempting to remove XP from a player using player.addExperience(-1) (player being an EntityPlayer), however it doesn't quite work properly. When XP reaches below the current level, the XP bar begins to stay empty, and the level stays the same.

 

I've also tried player.experienceTotal = player.experienceTotal - 1; with no luck.\

 

Anybody have any suggestions for removing XP from the player?

[Draco18s]

Here's some code from 1.6.4, not sure how valid it still is, but it did work at the time.

 

	                            	if(player.experience > 0 && player.experienceLevel > 0) {
                                	player.experienceTotal--;
                            		player.experience -= 1F/player.xpBarCap();
                            	}
                            	else if(player.experienceLevel > 0) {
                                	player.experienceTotal--;
                            		player.experienceLevel--;
                            		player.experience = (float)(player.xpBarCap()-1)/player.xpBarCap();
                            		if(player.experienceLevel == 0)
                            			player.experience = 0;
                            	}

[elfin8er]

if(player.experienceTotal >= 10){
        System.out.println("Removing XP");
player.experienceTotal = player.experienceTotal - 1;
}

Isn't working In fact, it's not doing anything (except printing "Removing XP"). Replacing it with player.addExperience(-1); does work however (with the reported issues).

[Draco18s]

Well, you should use

if(player.experience > 0 && player.experienceLevel > 0)

not

if(player.experienceTotal >= 10)

 

As your exact issue is what the second half of the code I posted is for.

[elfin8er]

Ah, my bad. My apologizes. It seems to be working with what you posted. Thank you very much

 

EDIT: Having a really hard time using values other than -1. I'm sure I'll get it eventually though

public static void removeXP(EntityPlayer player, int amt){
	if(player.experience > amt && player.experienceLevel > 0) {
    	player.experienceTotal = player.experienceTotal - amt;
		player.experience -= 1F/player.xpBarCap();
	}
	else if(player.experienceLevel > 0) {
		player.experienceTotal = player.experienceTotal - amt;
		player.experienceLevel--;
		player.experience = (float)(player.xpBarCap()-1)/player.xpBarCap();
		if(player.experienceLevel == 0)
			player.experience = 0;
	}
}

[Draco18s]

Well for starters, you should do player.experience >= amt

 

Second the 1F/player.xpBarCap(); adjusts the bar...by 1 point of exp, you should use amt/player.xpBarCap().

 

Third, you'll have to similarly adjust the second block.

 

Fourth, what if the player has less than that amount of exp and no levels?

[elfin8er]

Hmm...

 

public static void removeXP(EntityPlayer player, int amt){
	if(player.experience >= amt && player.experienceLevel == 0) {
    	player.experienceTotal = player.experienceTotal - amt;
		player.experience -= amt/player.xpBarCap();
	}else if(player.experienceLevel > 0 && player.experience >= amt) {
		player.experienceTotal = player.experienceTotal - amt;
		player.experienceLevel--;
		player.experience = (float)(player.xpBarCap()-amt)/player.xpBarCap();
		if(player.experienceLevel == 0)
			player.experience = 0;
	}
}

Thanks for the help so far.

[Draco18s]

what happens when...

amt = 10
player.experience = 5
player.experienceLevel = 2

..?

[AntonBespoiasov]

/** Decreases player's experience properly */
public static void decreaseExp(EntityPlayer player, float amount)
{
        if (player.experienceTotal - amount <= 0)
        {
            player.experienceLevel = 0;
            player.experience = 0;
            player.experienceTotal = 0;
            return;
        }
        
        player.experienceTotal -= amount;

        if (player.experience * (float)player.xpBarCap() <= amount)
        {
        	amount -= player.experience * (float)player.xpBarCap();
        	player.experience = 1.0f;
        	player.experienceLevel--;
        }

        while (player.xpBarCap() < amount)
        {
        	amount -= player.xpBarCap();
            player.experienceLevel--;
        }
        
        player.experience -= amount / (float)player.xpBarCap();
}

1.12.2

 

Edited December 11, 2019 by AntonBespoiasov