Jump to content

Recommended Posts

Posted

OK so I am working on a feature and I have the base of it somewhat functional. Currently whenever the player crafts an item it will display who owns it.

However I am having a few problems which include

 

1)information will only display whenever a single item is selected it will not add if you shift click an item from the crafting slot

2)even through repeating this process similarly for smelting and EntityItemPickups they do not show the information .

 

item pickup Event

@SubscribeEvent
   public void ItemPickup(EntityItemPickupEvent event)
   {

      System.out.println("pick up called");
      if(event.item.getEntityItem().stackTagCompound == null)
      {
         event.item.getEntityItem().stackTagCompound=new NBTTagCompound();
      }

      if(event.item.getEntityItem().stackTagCompound.getString("Owner")== null)
      {
         event.item.getEntityItem().stackTagCompound.setString("Owner", event.entityPlayer.getDisplayName());

      }
   }

 

Smelting event

  @SubscribeEvent
   public void onSmelting(PlayerEvent.ItemSmeltedEvent event)
   {      
      if(event.smelting.stackTagCompound==null)
      {
         event.smelting.setTagCompound(new NBTTagCompound());
      }
      if(event.smelting.stackTagCompound.getString("Owner")== null)
      {
         event.smelting.stackTagCompound.setString("Owner",event.player.getCommandSenderName());
      }
}

 

crafting handler

   @SubscribeEvent
   public void onPlayerItemCrafted(PlayerEvent.ItemCraftedEvent event)
   {
      if(event.crafting.stackTagCompound==null)
      {
         event.crafting.stackTagCompound=new NBTTagCompound();
      }
      
      if(event.crafting.stackTagCompound.getString("Owner")==null)
      {
         event.crafting.stackTagCompound.setString("Owner", event.player.getCommandSenderName());
      }
}

 

tooltip display code

@SubscribeEvent
   public void ToolTip(ItemTooltipEvent event)
   {

      if(event.itemStack.stackTagCompound==null)
      {
         event.itemStack.setTagCompound(new NBTTagCompound());
      }


      event.toolTip.add("Items owner is: "+ event.itemStack.stackTagCompound.getString("Owner")) ;
   }

 

not sure what the problem is so any help is appreciated.

Thanks

 

Posted

NBT Tags will not work for stacked items, So I think that will cause first problem.

For second, I dont know..

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted
  On 12/7/2014 at 8:25 AM, Abastro said:

NBT Tags will not work for stacked items, So I think that will cause first problem.

For second, I dont know..

 

yeah i had thought that but then when i was able to get a furnace to display its owner when crafted. Then it wouldn't stack with others(as i had expected) but would stack with anotherr one with the same name

Posted

Ah, what tattyseal said is right..

You have to check if there is the key,

For event.smelting.stackTagCompound.getString("Owner") will give "".

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Posted

ok I have pickups and smelting working now, just one problem of shift clicking an item from the furnace and crafting bench, since it'll set the owner if it's a single item takn at a time but not a stack although the single items can then be placed into a stack with others of the same owner.

Any suggestions?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.