Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Particle Problem

laifsjo

By laifsjo
in Modder Support

 Share

Recommended Posts

laifsjo Stone Miner

laifsjo

Posted
Posted

Hello guys, i made a new particle in minecraft, and sometimes when i spawn it in the world using ModLoader.getMinecraftInstance().effectRenderer.addEffect(particleClass); it crashes, sometimes it works fine, but most of the time it crashes. this is the error i get:

2012-10-11 14:44:02 [iNFO] [sTDERR] java.util.ConcurrentModificationException
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at java.util.ArrayList$Itr.next(Unknown Source)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at net.minecraft.src.Entity.moveEntity(Entity.java:680)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at MethyrClient.ParticleHD5.onUpdate(ParticleHD5.java:97)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at net.minecraft.src.EffectRenderer.updateEffects(EffectRenderer.java:67)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1800)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:843)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.run(Minecraft.java:773)
2012-10-11 14:44:02 [iNFO] [sTDERR] 	at java.lang.Thread.run(Unknown Source)
2012-10-11 14:44:12 [iNFO] [sTDOUT] Stopping!

could somebody help me out?

Link to comment
Share on other sites
SanAndreaP World Shaper

SanAndreaP

Posted
Posted

Make sure you're spawning particles only with the client thread! If you have to call this in the server thread (e.g. if the method is only executing on a server), then use packets to handle particle spawning.

To check if it's client side, check if world.isRemote == true.

 

BTW: Use Minecraft.getMinecraft() instead of ModLoader.getMinecraftInstance().

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites
laifsjo Stone Miner

laifsjo

Posted
  • Author
Posted

well, i am already using the (world.isRemote) method, i'll try the minecraft thing but my package is in minecraft.common. maybe that's wrong? could you tell me which classes should be client sided and which classes should be server sided? because i also have a client sided package for rendering stuff like the particles

Link to comment
Share on other sites
laifsjo Stone Miner

laifsjo

Posted
  • Author
Posted

nope that doesn't work either, i even get another error...:

2012-10-11 16:21:21 [iNFO] [sTDERR] java.util.ConcurrentModificationException
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at java.util.ArrayList$Itr.next(Unknown Source)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.Entity.moveEntity(Entity.java:680)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.EntityLiving.moveEntityWithHeading(EntityLiving.java:1356)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.EntityLiving.onLivingUpdate(EntityLiving.java:1578)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.EntityAgeable.onLivingUpdate(EntityAgeable.java:59)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.EntityAnimal.onLivingUpdate(EntityAnimal.java:40)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.EntityLiving.onUpdate(EntityLiving.java:692)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.World.updateEntityWithOptionalForce(World.java:2033)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.WorldServer.updateEntityWithOptionalForce(WorldServer.java:538)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.World.updateEntity(World.java:1998)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.World.updateEntities(World.java:1879)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.WorldServer.updateEntities(WorldServer.java:437)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:629)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:560)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.IntegratedServer.tick(IntegratedServer.java:107)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:466)
2012-10-11 16:21:21 [iNFO] [sTDERR] 	at net.minecraft.src.ThreadServerApplication.run(ThreadServerApplication.java:18)

Link to comment
Share on other sites
battlefield Tree Puncher

battlefield

Posted
Posted

I use such system like minecraft uses, only that it's customized

 

addEffect(ClientProxy) - https://github.com/batlefield/Zoocraftia/blob/master/source/minecraft/net/zoocraftia/dimension/client/ClientProxy.java#L149

addEffect(CommonProxy) - https://github.com/batlefield/Zoocraftia/blob/master/source/common/net/zoocraftia/dimension/CommonProxy.java#L106

particleEntity - https://github.com/batlefield/Zoocraftia/blob/master/source/minecraft/net/zoocraftia/dimension/client/EntityPortalFX.java

 

addEffect call in my portal class - https://github.com/batlefield/Zoocraftia/blob/master/source/common/net/zoocraftia/dimension/BlockPortal.java#L219

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Kaan11
      How to display content of Container

      By Kaan11 · Posted

      0 I have recently started with Java and the implementation of Minecraft mods. I am currently working on a mod for 1.20.4-49.0.31 I'm trying to get the content of each slot in the console to be displayed when the inventory is opened, which works. In addition, I wanted to do the same with chests (in this case containers). However, I get in the output that there is Air at every slot of the chest, even if the chest is filled. Does anyone have experience with similar problems and could help me? package net.kaan.sortingmod; import net.minecraft.client.Minecraft; import net.minecraft.client.gui.screens.Screen; import net.minecraft.client.gui.screens.inventory.AbstractContainerScreen; import net.minecraft.client.gui.screens.inventory.InventoryScreen; import net.minecraft.client.gui.screens.inventory.ContainerScreen; import net.minecraft.client.gui.screens.inventory.FurnaceScreen; import net.minecraft.world.entity.player.Player; import net.minecraft.world.inventory.AbstractContainerMenu; import net.minecraft.world.inventory.InventoryMenu; import net.minecraft.world.item.ItemStack; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.client.event.ScreenEvent; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; @Mod(SortingMod.MODID) public class SortingMod { public static final String MODID = "sortingmod"; public SortingMod() { // Register the client setup method FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff); // Register this class for Forge events MinecraftForge.EVENT_BUS.register(this); } private void doClientStuff(final FMLClientSetupEvent event) { // Any client-side setup can be done here } @SubscribeEvent public void onScreenOpen(ScreenEvent.Opening event) { Screen screen = event.getScreen(); if (screen instanceof InventoryScreen) { System.out.println("Player opened their inventory."); assert Minecraft.getInstance().player != null; printInventoryItems(Minecraft.getInstance().player); } else if (screen instanceof ContainerScreen) { System.out.println("Player opened a chest."); printContainerItems((ContainerScreen) screen); } } private void printInventoryItems(Player player) { AbstractContainerMenu menu = player.inventoryMenu; for (int i = 0; i < menu.slots.size(); i++) { ItemStack stack = menu.getSlot(i).getItem(); if (!stack.isEmpty()) { System.out.println("Slot " + i + ": " + stack.getCount() + "x " + stack.getHoverName().getString()); } } } private void printContainerItems(ContainerScreen screen) { AbstractContainerMenu menu = screen.getMenu(); System.out.println(menu.slots.size()); for (int i = 0; i < menu.slots.size(); i++) { ItemStack stack = menu.getSlot(i).getItem(); System.out.println("Slot " + i + ": " + stack.getCount() + "x " + stack.getHoverName().getString()); } } }  
    • DroidCrafter23
      Adding a tool without a recipe

      By DroidCrafter23 · Posted

      I am wanting to add an axe to my mod though I do not want it to have a recipe, the reason for this being that I want you to only be able to find it in a structure. I have looked on both here and elsewhere on the internet and have found nothing... How would this be done?    (Video for reference.)    
    • TileEntity
      Im trying to add server to gfs computer but on her pc its not working

      By TileEntity · Posted

      Make a test without amendments
    • Fenrir
      Im trying to add server to gfs computer but on her pc its not working

      By Fenrir · Posted

      file log:file:///C:/Users/natal/AppData/Roaming/.minecraft/logs/latest.log   Aternos log: https://mclo.gs/kzPaflO
    • neverless012
      1.20.1 Crash on World Creation

      By neverless012 · Posted

      Hi guys, having a bit of trouble finding out which mod causes trouble. My pack was working until I accidentally pressed update all mods on Curseforge. Cant use pastebin atm, my pastes keep going under moderation. paste.ee still waiting for verification email. Crash - https://mclo.gs/UKHjD92 Log - https://mclo.gs/WOXzoL6 64GB RAm Processor 13th Gen Intel(R) Core(TM) i9-13900K, 3000 Mhz, 24 Core(s), 32 Logical Processor(s) Name NVIDIA GeForce RTX 3090

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept