Jump to content

Trouble with for loops for a simple multiblock


turbodiesel4598

Recommended Posts

Hey there,

 

I'm not too experienced with modding, but have been making a mod for the past month or so, and have certainly improved. However, I'm attempting to make my currently extremely crude code more compact and simplified by using for loops to detect whether all of the blocks needed for the multiblock structure are there.

 

However, I am clearly doing something wrong: the block is only caring about 6 of the blocks out of the 150 of the structure, and only searches in those places - here is the block class, where everything important is, and the multiblock detection method is at the bottom, with the commented out section at the beginning of the method being the old system.

 

package com.nr.mod.blocks.tileentities;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.command.ICommandSender;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.IChatComponent;
import net.minecraft.util.IIcon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

import com.nr.mod.NuclearRelativistics;
import com.nr.mod.blocks.NRBlocks;

import cpw.mods.fml.common.network.internal.FMLNetworkHandler;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockFissionReactorGraphite extends BlockContainer
{
private Random rand = new Random();

private final boolean isActive;
public static int MBNumber;

@SideOnly(Side.CLIENT)
private IIcon iconFront;

private static boolean keepInventory;

public BlockFissionReactorGraphite(boolean isActive)
{
super(Material.iron);

this.isActive = isActive;
}

@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister)
{
this.blockIcon = iconRegister.registerIcon("nr:" + "reactorBlock");
this.iconFront = iconRegister.registerIcon("nr:" + "fissionReactorGraphite" + "Front" + (this.isActive ? "Active" : "Idle"));
}

public Item getItemDropped(int par1, Random random, int par3)
{
	return Item.getItemFromBlock(NRBlocks.fissionReactorGraphiteIdle);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	super.onBlockAdded(world, x, y, z);
	this.setDefaultDirection(world, x, y, z);
}

private void setDefaultDirection(World world, int x, int y, int z)
 {
        if (!world.isRemote)
        {
            Block block = world.getBlock(x, y, z - 1);
            Block block1 = world.getBlock(x, y, z + 1);
            Block block2 = world.getBlock(x - 1, y, z);
            Block block3 = world.getBlock(x + 1, y, z);
            byte b0 = 3;

            if (block.func_149730_j() && !block1.func_149730_j())
            {
                b0 = 3;
            }

            if (block1.func_149730_j() && !block.func_149730_j())
            {
                b0 = 2;
            }

            if (block2.func_149730_j() && !block3.func_149730_j())
            {
                b0 = 5;
            }

            if (block3.func_149730_j() && !block2.func_149730_j())
            {
                b0 = 4;
            }

            world.setBlockMetadataWithNotify(x, y, z, b0, 2);
        }
    }

@SideOnly(Side.CLIENT)
 public IIcon getIcon(int side, int metadata) {
	return metadata == 0 && side == 3 ? this.iconFront : (side == metadata ? this.iconFront : this.blockIcon);
    }

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
{
	 if(world.isRemote)
	 {
		 return true; 
	 }
	 else
	 {
		 FMLNetworkHandler.openGui(player, NuclearRelativistics.instance, NuclearRelativistics.guiIdFissionReactorGraphite, world, x, y, z);
	 }
	 return true;
 }

public TileEntity createNewTileEntity(World world, int par1)
{
	return new TileEntityFissionReactorGraphite();
}

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase entityLivingBase, ItemStack itemstack)
{
	 int l = MathHelper.floor_double((double)(entityLivingBase.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            world.setBlockMetadataWithNotify(x, y, z, 2, 2);
        }

        if (l == 1)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 5, 2);
        }

        if (l == 2)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 3, 2);
        }

        if (l == 3)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 4, 2);
        }

        if (itemstack.hasDisplayName())
        {
            ((TileEntityFissionReactorGraphite)world.getTileEntity(x, y, z)).setGuiDisplayName(itemstack.getDisplayName());
        }
        
        //itemstack = new ItemStack(NRItems.book, 1);
    	//player.inventory.addItemStackToInventory(itemstack);
    	
    	IChatComponent localIChatComponent;
    	localIChatComponent = IChatComponent.Serializer.func_150699_a("[{text:\"Click here to see how to build the multiblock reactor\",color:aqua,italic:false,clickEvent:{action:open_url,value:\"https://www.dropbox.com/s/vy7ld0dgd71utxu/fission%20reactor%20setup.bmp?dl=0\"}}]");

    	((ICommandSender) entityLivingBase).addChatMessage(localIChatComponent);
    }

public static void updateFissionReactorGraphiteBlockState(boolean active, World worldObj, int xCoord, int yCoord, int zCoord)
{
	int i = worldObj.getBlockMetadata(xCoord, yCoord, zCoord);

	TileEntity tileentity = worldObj.getTileEntity(xCoord, yCoord, zCoord);
	keepInventory = true;

	if(active)
	{
		worldObj.setBlock(xCoord, yCoord, zCoord, NRBlocks.fissionReactorGraphiteActive);
	}
	else
	{
		worldObj.setBlock(xCoord, yCoord, zCoord, NRBlocks.fissionReactorGraphiteIdle);
	}

	keepInventory = false;

	worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, i, 2);

	if(tileentity != null)
	{
		tileentity.validate();
		worldObj.setTileEntity(xCoord, yCoord, zCoord, tileentity);
	}
}

public void breakBlock(World world, int x, int y, int z, Block oldBlockID, int oldMetadata)
{
	if(!keepInventory)
	{
		TileEntityFissionReactorGraphite tileentity = (TileEntityFissionReactorGraphite) world.getTileEntity(x, y, z);

		if(tileentity != null)
		{
			for(int i = 0; i < tileentity.getSizeInventory(); i++)
			{
				ItemStack itemstack = tileentity.getStackInSlot(i);

				if(itemstack != null)
				{
					float f = this.rand.nextFloat() * 0.8F + 0.1F;
					float f1 = this.rand.nextFloat() * 0.8F + 0.1F;
					float f2 = this.rand.nextFloat() * 0.8F + 0.1F;

					while(itemstack.stackSize > 0)
					{
						int j = this.rand.nextInt(21) + 10;

						if(j > itemstack.stackSize)
						{
							j = itemstack.stackSize;
						}

						itemstack.stackSize -= 	j;
						EntityItem item = new EntityItem(world, (double) ((float) x + f), ((float) y + f1), ((float) z + f2),
						new ItemStack (itemstack.getItem(), j, itemstack.getItemDamage()));

						if(itemstack.hasTagCompound())
						{
							item.getEntityItem().setTagCompound((NBTTagCompound) itemstack.getTagCompound().copy());
						}

						float f3 = 0.05F;
						item.motionX = (double)((float) this.rand.nextGaussian() * f3);
						item.motionY = (double)((float) this.rand.nextGaussian() * f3 + 0.2F);
						item.motionZ = (double)((float) this.rand.nextGaussian() * f3);

						world.spawnEntityInWorld(item);

					}
				}
			}

			world.func_147453_f(x, y, z, oldBlockID);
		}
	}

	super.breakBlock(world, x, y, z, oldBlockID, oldMetadata);
}

public boolean hasComparatorInputOverride()
{
	return true;
}

public int getComparatorInputOverride(World world, int x, int y, int z, int i)
{
	return Container.calcRedstoneFromInventory((IInventory)world.getTileEntity(x, y, z));
}

public Block idPicked(World world, int x, int y, int z)
{
	return NRBlocks.fissionReactorGraphiteIdle;
}

    public static boolean isMultiBlock(World world, int x, int y, int z)
    {
    	/*if (world.getBlock(x-2, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-3, y+1, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x+3, y+1, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+5, z) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+5, z-6) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-3, y, z-1) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-2) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-3) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-4) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-5) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-1) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-2) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-3) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-4) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-5) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-2, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-1, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+1, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+2, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-2, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-1, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+1, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			
    			&& world.getBlock(x-3, y, z-1) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-2) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-3) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-4) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-5) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-1) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-2) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-3) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-4) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-5) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-2, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-1, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+1, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+2, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-2, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-1, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+1, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			
        		)*/
    	for (int i1 = 0; i1 < 5; i1++) {
    		for (int i2 = 0; i2 < 5; i2++) {
    			if (world.getBlock(x-2+i1, y, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+6, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-3, y+1+i1, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x+3, y+1+i1, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+1+i2, z) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+1+i2, z-6) == NRBlocks.reactorBlock) {
    				MBNumber = 1;
    				return true;
    			}
    	
    						/*else if (world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock
    								&& world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock) {
    							MBNumber = 2;
    							return true;
    						}
    						else if (world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive) {
    							MBNumber = 3;
    							return true;
    						}
    						else if (world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive) {
    							MBNumber = 4;
    							return true;
    						}*/

    		}
    	} MBNumber = 0; return false;
    }
}

 

Thanks in advance for anyone better at this than me for noticing why this won't work :)

Link to comment
Share on other sites

Because you return true if the first time the loop runs it finds the blocks.  You didn't let the loop finish.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

loop {
    if(condition == true) {
        //your current return true, commented out
    }
    else {
        return false; //new
    }
    return true; //new
}

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • This is a MacOs related issue: https://bugs.mojang.com/browse/MC-118506     Download this lib: https://libraries.minecraft.net/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0.jar and put it into ~/Library/Application Support/minecraft/libraries/ca/weblite/java-objc-bridge/1.0.0  
    • I use Bisect-Hosting, and I host a relatively modded server.  There is a mod I desperately want to have in a server. https://www.curseforge.com/minecraft/mc-mods/minehoplite This is MineHop. It's a mod that replicates the movement capabilities seen in Source Engine games, such as Half-Life, and such.  https://youtu.be/SbtLo7VbOvk - A video explaining the mod, if anyone is interested.  It is a clientside mod, meaning whoever is using it can change anything about the mod that they want, with no restrictions, even when they join a server with the same mod. They can change it to where they can go infinitely fast, or do some other overpowered thing. I don't want that to happen. So I just want to know if there is some way to force the SERVER'S configuration file, onto whoever is joining.  I'm not very savvy with all this modding stuff. There are two config files: minehop-common.txt, and minehop.txt I don't really know much about how each are different. I just know what the commands relating to acceleration and stuff mean.    
    • My journey into crypto trading began tentatively, with me dipping my toes into the waters by purchasing my first Bitcoin through a seasoned trader. With an initial investment of $5,000, I watched as my investment grew, proving to be both fruitful and lucrative. Encouraged by this success, I decided to increase my investment to $150,000, eager to capitalize on the growing popularity of cryptocurrency, However, as cryptocurrency gained mainstream attention, so too did the number of self-proclaimed "experts" in the field. Suddenly, everyone seemed to be a crypto guru, and more and more people were eager to jump on the bandwagon without fully understanding the intricacies of this complex world. With promises of quick and easy profits, these con artists preyed on the uninformed, luring them into schemes that often ended in disappointment and financial loss. Unfortunately, I fell victim to one such scheme. Seduced by the allure of easy money, I entrusted my hard-earned funds to a dubious trading platform, granting them access to my accounts in the hopes of seeing my investment grow. For a brief period, everything seemed to be going according to plan, with regular withdrawals and promising returns on my investment. However, my hopes were soon dashed when, without warning, communication from the platform ceased, and my Bitcoin holdings vanished into thin air. Feeling helpless and betrayed, I confided in a family member about my predicament. They listened sympathetically and offered a glimmer of hope in the form of a recommendation for Wizard Web Recovery. Intrigued by the possibility of reclaiming what I had lost, I decided to explore this option further. From the moment I reached out to Wizard Web Recovery, I was met with professionalism and empathy. They took the time to understand my situation and reassured me that I was not alone in my plight. With their guidance, I embarked on a journey to reclaim what was rightfully mine. Wizard Web Recovery's expertise and dedication were evident from the start. They meticulously analyzed the details of my case, uncovering crucial evidence that would prove invaluable in our quest for justice. With each step forward, they kept me informed and empowered, instilling in me a newfound sense of hope and determination. Through their tireless efforts and unwavering support, Wizard Web Recovery succeeded in recovering my lost Bitcoin holdings. It was a moment of triumph and relief, knowing that justice had been served and that I could finally put this chapter behind me. In conclusion, My experience with Wizard Web Recovery  was nothing short of transformative. Their professionalism, expertise, and unwavering commitment to their clients set them apart as true leaders in the field of cryptocurrency recovery. I am forever grateful for their assistance and would highly recommend their services to anyone in need of help navigating the treacherous waters of cryptocurrency scams. 
    • Ok so: Two things to note: It got stuck due to my dimension type. It was previously the same as the overworld dimension tpye but after changing it , it didn't freeze during spawn generation. ALSO, APPARENTLY, the way I'm doing things, the game can't have two extremely-rich dimensions or it will make the new chunk generation be veeery VEEERY slow. I'm doing the dimension file genreation all in the data generation step now, so it's all good. Mostly. If anybody has any tips regarding how can i more efficently generate a biome-rich dimension, im all ears.
    • https://mclo.gs/qTo3bUE  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.