Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.7.10] Item NBT Not Working


FlashBash21
 Share

Recommended Posts

PLEASE NOT THAT I'M NEW TO NBT'S AND AM STILL LEARNING IT!

 

Hello! I'm currently attempting to use an NBT to store information in an item I'm using. I want to the item to store a charge in it every time you hit a mob, so for that I'm gonna use an NBT. I want the the charge of the item to be displayed in the lore of the item but it doesn't show up(note that It doesn't store charges when you hit mobs yet I'm adding that later). I don't know much about NBT's so I've found some tutorials but they aren't too great or don't explain NBT's for items. Any help or advice at all would be well appreciated, Thanks!

 

Here is my class:

 

package com.LegendsAndArtifacts.items;



import java.util.List;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ChatComponentText;
import net.minecraft.world.World;

public class AxeInfernal extends ItemSword{

boolean isCharged = false;
int itemCharge = 0;

public AxeInfernal(ToolMaterial p_i45356_1_) {
	super(p_i45356_1_);

}

    @Override
    public void onCreated(ItemStack stack, World world, EntityPlayer player) {
    	 stack.stackTagCompound = new NBTTagCompound();
    	 stack.stackTagCompound.setInteger("currentCharge", itemCharge);
    }

    public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean par4) {
    	 if (stack.stackTagCompound != null) {
             int charge = stack.stackTagCompound.getInteger("currentCharge");
             list.add("Current Charge: " + charge);
     }
    }
}

How do you do?

Link to comment
Share on other sites

First of all - you can'r use global fields in Item class. There is only one instance of item.

 

Note: onCreated is only called when you craft item with workbench. (You are probably pulling it from Creative Tab, thats why it doesn't have NBT)

Everytime you try to do anything with NBT you should access that data directly (inside method, with local fields).

 

That's pretty much all about NBT.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

First of all - you can'r use global fields in Item class. There is only one instance of item.

 

Note: onCreated is only called when you craft item with workbench. (You are probably pulling it from Creative Tab, thats why it doesn't have NBT)

Everytime you try to do anything with NBT you should access that data directly (inside method, with local fields).

 

That's pretty much all about NBT.

Ok so I got the charge to show up so thanks! But how do I update the NBT(I'm testing it with the onItemRightClick method)? I'm guessing I should use the onUpdate method or is there something to do that for me? And if I use onUpdate what do I put in it? here is my class :

 

package com.LegendsAndArtifacts.items;



import java.util.List;

import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ChatComponentText;
import net.minecraft.world.World;

public class AxeInfernal extends ItemSword{

private boolean isCharged = false;
private int itemCharge = 0;

public AxeInfernal(ToolMaterial p_i45356_1_) {
	super(p_i45356_1_);

}

    @Override
    public void onCreated(ItemStack stack, World world, EntityPlayer player) {
    	 stack.stackTagCompound = new NBTTagCompound();
    	 stack.stackTagCompound.setInteger("currentCharge", itemCharge);
    }

    public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean par4) {
    	 if (stack.stackTagCompound != null) {
             int charge = stack.stackTagCompound.getInteger("currentCharge");
             list.add("Current Charge: " + charge);
     }
    }
    
    public void onUpdate(ItemStack stack, World world, Entity entity, int par4, boolean par5) {
    	
    	//?
    }
    public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player){
    	itemCharge++;
    	return stack;
    }
}

 

I think that using itemCharge++ is probably the wrong way to increment it but I'm not sure what the right way is. Again thanks for any help that you might give!

How do you do?

Link to comment
Share on other sites

Hi

 

Here's an example of how an item might use and update NBT.

 

The item is a "gem" that stores your current [x,y,z] location when you shift-click.

 

When you 'use' it, it retrieves those coordinates and teleports there.

 

There should be enough there for you to figure out how to store and retrieve your integer (eg nbtTagCompound.setInteger())

 

MyItem::

  // called when the player starts holding right click;
  // --> if the gem is unbound, store the current location
  //  if the gem is bound, start the charge up sequence
  @Override
  public ItemStack onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn) {
    NBTTagCompound nbtTagCompound = itemStackIn.getTagCompound();

    if (playerIn.isSneaking()) { // shift pressed; save (or overwrite) current location
      if (nbtTagCompound == null) {
        nbtTagCompound = new NBTTagCompound();
        itemStackIn.setTagCompound(nbtTagCompound);
      }
      nbtTagCompound.setBoolean("Bound", true);
      nbtTagCompound.setDouble("X", (int) playerIn.posX);
      nbtTagCompound.setDouble("Y", (int)playerIn.posY);
      nbtTagCompound.setDouble("Z", (int)playerIn.posZ);
    } else { // attempting to use gem teleport
      boolean bound = false;
      if (nbtTagCompound != null && nbtTagCompound.hasKey("Bound")  ) {
        bound = nbtTagCompound.getBoolean("Bound");
      }
      if (bound) {
        playerIn.setItemInUse(itemStackIn, this.getMaxItemUseDuration(itemStackIn)); // start the charge up sequence
      } else {
        if (worldIn.isRemote) {  // only on the client side, else you will get two messages..
          playerIn.addChatComponentMessage(new ChatComponentText("Gem doesn't have a stored location! Shift right click to store your current location"));
        }
      }
    }
    return itemStackIn;
  }

  // called when the player has held down the right click for the full charge-up duration
  // in this case - destroy the item
  @Override
  public ItemStack onItemUseFinish(ItemStack stack, World worldIn, EntityPlayer playerIn)
  {
    NBTTagCompound nbtTagCompound = stack.getTagCompound();
    if (nbtTagCompound == null || !nbtTagCompound.hasKey("Bound") || nbtTagCompound.getBoolean("Bound") != true ) {
      return stack;
    }

    // teleport
    if (!worldIn.isRemote) { // server side only - will automatically update to client
      double x = nbtTagCompound.getDouble("X");  // returns a default if not present
      double y = nbtTagCompound.getDouble("Y");
      double z = nbtTagCompound.getDouble("Z");
      if (playerIn instanceof EntityPlayerMP) { // should be an EntityPlayerMP check first just to be sure to avoid crash
        EntityPlayerMP entityPlayerMP = (EntityPlayerMP) playerIn;

        entityPlayerMP.playerNetServerHandler.setPlayerLocation(x, y, z, entityPlayerMP.rotationYaw, entityPlayerMP.rotationPitch);
        worldIn.playSoundEffect(x, y, z, "mob.endermen.portal", 1.0F, 1.0F);
      }
    }
    return null;
//    for items with multiple count, decrease stack size and return the itemstack, eg
//    stack.stackSize--;
//    return stack;
  }

  // adds 'tooltip' text
  @SideOnly(Side.CLIENT)
  @SuppressWarnings("unchecked")
  @Override
  public void addInformation(ItemStack stack, EntityPlayer playerIn, List tooltip, boolean advanced) {
    NBTTagCompound nbtTagCompound = stack.getTagCompound();
    if (nbtTagCompound != null && nbtTagCompound.hasKey("Bound") && nbtTagCompound.getBoolean("Bound") == true ) {
      tooltip.add("Stored destination=");
      tooltip.add("X: " + nbtTagCompound.getInteger("X"));
      tooltip.add("Y: " + nbtTagCompound.getInteger("Y"));
      tooltip.add("Z: " + nbtTagCompound.getInteger("Z"));
    }
    else
    {
      tooltip.add("Hold down shift and then right click to store your current location");
    }
  }
}

 

-TGG

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello There! In the 73rd episode of Bed Wars we get into a lobby with a guy who had a cool name and for some reason Ben is very impressed with the name and thus the title!  
    • I have been trying to install forge, but I can't even get the installer to run. I'm really not sure what the issue is, first let me make sure I am even using the installer right, I downloaded the forge installer matching my minecraft version (1.19.2), if I double click the .jar from the download then I see a flash of a black window that immediately disappears. If I use a command prompt, I receive the following output: C:\Users\austi> java -jar forge-1.19.2-43.0.19-installer.jar Error: Unable to access jarfile forge-1.19.2-43.0.19-installer.jar   I feel like this is more likely a java issue than a forge issue but I was hoping that people here might be able to help. I've tried a couple versions of java, at first I was using 8 I believe because all of the install guides for forge were a bit older so they linked to the java website rather than oracle. I tried version 18 from the oracle site and received the same result from command prompt. It is also entirely possible that I am doing something else wrong that is blatantly obvious to everyone else.
    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.