Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.8] How do I prevent Mineshaft generation in specific chunks?


utoxin
 Share

Recommended Posts

I'm trying to build my UHC mod, and I have the code that generates the bedrock wall working nearly perfectly. But it seems like somehow some of the chunk population is running after my code, even though I'm running it in the PopulateChunkEvent.Post event handler.

 

Here's the file that's running my actual generation: http://bit.ly/1zdQDvE

 

I've triple-checked that I'm only replacing blocks that are in the current chunk, at least for the wall itself. It's possible that the 'starting area' platform is less well behaved, but that code is all getting replaced soon anyway. Lines 24-72 should be the relevant code. The problem is that lakes and mineshafts have a tendency to punch holes in the bedrock wall, as if they are generating after the wall, even though they should all be executing first.

 

Edit:

 

Well, I've now attempted to reject any terrain decoration in chunks that contain my wall, with no effect (so I'm probably doing it wrong), and giving my event handler the Lowest priority, so it should run last, with no effect.

 

I'm out of ideas, and going to bed for the night.

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

I've now run through this in debug mode, and as far as I can tell, I'm doing this perfectly, which just makes me more confused. Is it possible that feature generation in neighboring chunks is bleeding into one of the chunks I generate stuff in?

 

Edit:

 

Yup. That's what's happening. Time to ponder solutions. Any suggested ways of fixing this?

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

I ran into a similar issue, and though I'm not 100% sure, I believe that lakes at least DO generate across multiple chunks at once.

 

What I did is to deny lake generation if the chunk it is in or any immediate neighbor has my structure in it, and this seems to have solved the problem.

 

I say 'seems' because while it fixed it in the one seed in which I found it, I haven't been able to verify for a fact that it will work in all circumstances. Haven't had an issue reported since, though.

Link to comment
Share on other sites

Yeah, that's sort of what I'm looking into doing. But in my case, I need to worry about mineshafts too, so I may need to go further out than just one chunk. I know they can punch through, but I need to look at their generation to see how it works.

 

Thanks for the source links, they should be very helpful. :)

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

Well, coolAlias' fix solved the issue with lakes and lava lakes. But doesn't help with mineshafts. Is there a decent way to prevent mineshafts from generating through a specific chunk? I've scanned through the code and haven't seen anything that looked helpful, but I hope I missed it.

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
    • Okay, i think i understand but im getting issues, i create another packet to sync entity to another players like this package com.naim.belloto.networking.packet; import com.naim.belloto.networking.handler.ClientSyncHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.FriendlyByteBuf; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.Objects; import java.util.function.Supplier; public class ClientSyncPacket { public ClientSyncPacket() { } public ClientSyncPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { assert Minecraft.getInstance().player != null; int idplayer = Minecraft.getInstance().player.getId(); DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientSyncHandler.handlePacket(ctx, idplayer)); }); return true; } } And in the handler: public class ClientSyncHandler { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx, int idPlayer) { Minecraft.getInstance().level.getEntity(idPlayer); return true; } } But is not working :// 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.