Do I have to do pull-request to Github?

[hide92795]

Hi,

I'm developing Hangable Maps mod.

http://www.minecraftforum.net/topic/1461853-

I got a message on my mod's forum.

 

------------------QUOTE--------------------

You could do a pull request to the forge codebase with your modifications.

-----------------------------------------------

 

Modified class is "ItemMap.java".

Source code is attached.

 

What is the merit to do pull-request?

And, do I have to do pull-request?

 

[LexManos]

1) Don't post mojang classes -.-

2) Submit .path files, do a little reasearch on how to use the git environment.

3) What exactly do you need these base edits for? Could it not be done base clean with your own item?

[hide92795]

I'm sorry. I'll be careful from now on.

 

I tried create .patch file, but I can't setup forge basefiles with MCP for some reason.

Modification point is divided into three major categories:

1, Map can be stacked 64 sheets.

2, The middle of new map is adjusted to the nearest 1024 x,z co-ordinate.

3, Override the method 'onItemUse()'.

 

Thanks

[LexManos]

Why exactly do you need this and why should it be in forge?

Seems to me like you should just make a mod that creates a new type of map item.

[hide92795]

I understand. I'll try the way.

Thank you.