Jump to content

[SOLVED][1.8] Multitextures


Guest

Recommended Posts

So I am making several types of wood for my mod, and I am having a problem with the rendering of the block. The problem is not that I don't get to render the block, but the fact that one of the types of plank are using the wrong texture. Namely the alder plank.  Where it use the texture of the yew plank.  If you look at the code in the class BlockPlank you can see that I have placed in some System.out.println() for checking what values or strings are used. When placing the alderplank, it outputs

 

[11:12:27] [Client thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Alder]
[11:12:27] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Alder]

which it should, but when broken it outputs

[11:14:37] [Client thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16
[11:14:37] [Client thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Yew]
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Yew]
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getStateFromMeta:51]: em:plank[woodtype=Yew]
[11:14:37] [server thread/INFO] [sTDOUT]: [com.tommywithatiger.extendedminecraft.blocks.BlockPlank:getMetaFromState:58]: Yew
16

 

Which now means that the game thinks it is Yew plank. I have been trying to look for why it does this, but havn't really found the error. If someone could help me that would be great

 

 

Code:

 

BlockPlank:

package com.tommywithatiger.extendedminecraft.blocks;

import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

import com.tommywithatiger.extendedminecraft.handler.ExtendedMinecraftCreativeTabHandler;

public class BlockPlank extends Block{

public BlockPlank() {
	super(Material.wood);
	this.setCreativeTab(ExtendedMinecraftCreativeTabHandler.ExtendedMinecraftBlocksTab);
	this.setDefaultState(this.blockState.getBaseState().withProperty(PROPERTYTYPE, BlockPlank.EnumWoodType.ALDER));
}

public static final PropertyEnum PROPERTYTYPE = PropertyEnum.create("woodtype", EnumWoodType.class);


@Override
@SideOnly(Side.CLIENT)
public void getSubBlocks(Item itemIn, CreativeTabs tab, List list){
	for(EnumWoodType type: EnumWoodType.values()){
			list.add(new ItemStack(itemIn, 1, type.getMetadata()));
	}
}

@Override
protected BlockState createBlockState()  {
	return new BlockState(this, new IProperty[] {PROPERTYTYPE});
    }

@Override
public IBlockState getStateFromMeta(int meta){
	EnumWoodType type = EnumWoodType.byMetadata(meta);
	System.out.println(this.getDefaultState().withProperty(PROPERTYTYPE, type));
	return this.getDefaultState().withProperty(PROPERTYTYPE, type);
}

@Override
public int getMetaFromState(IBlockState state){
	EnumWoodType type = (EnumWoodType)state.getValue(PROPERTYTYPE);
	System.out.println(type);
	int typebit = type.getMetadata();
	System.out.println(typebit);
	return typebit;
}

@Override
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing blockFaceClickedOn, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
{
	EnumWoodType type = EnumWoodType.byMetadata(meta);
	System.out.println(this.getDefaultState().withProperty(PROPERTYTYPE, type));
	return this.getDefaultState().withProperty(PROPERTYTYPE, type);
}

public static enum EnumWoodType implements IStringSerializable
{
    ALDER(0,"Alder","alder"),
    ASH(1,"Ash","ash"),
    ASPEN(2,"Aspen","aspen"),
    CEDAR(3,"Cedar","cedar"),
    CHERRY(4,"Cherry","cherry"),
    ELM(5,"Elm","elm"),
    EUCALYPTUS(6,"Eucalyptus","eucalyptus"),
    FIR(7,"Fir","fir"),
    HICKORY(8,"Hickory","hickory"),
    MAHOGANY(9,"Mahogany","mahogany"),
    MAPLE(10,"Maple","maple"),
    PINE(11,"Pine","pine"),
    POPLAR(12,"Poplar","poplar"),
    REDWOOD(13,"Redwood","redwood"),
    TEAK(14,"Teak","teak"),
    WILLOW(15,"Willow","willow"),
    YEW(16,"Yew","yew");
    
    private final int meta;
    private final String name;
    private final String substring;
    private static final EnumWoodType[] META_LOOKUP = new BlockPlank.EnumWoodType[values().length];
    
    private EnumWoodType(int i_meta, String i_name, String i_substring){
    	this.meta = i_meta;
    	this.name = i_name;
    	this.substring = i_substring;
    }
    
    public int getMetadata(){
    	return this.meta;
    }
    
    @Override
    public String toString()
    {
    	return this.name;
    }
    
    public String getSubstring(){
    	return this.substring;
    }
    
    public static EnumWoodType byMetadata(int meta)
    {
    	if (meta < 0 || meta >= META_LOOKUP.length)
    	{
    		meta = 0;
    	}
    	
    	return META_LOOKUP[meta];
    }
    
    public String getName(){
    	return this.name;
    }
    	    
    static
    {
    	for ( EnumWoodType woodType : values()){
    		META_LOOKUP[woodType.getMetadata()] = woodType;
    	}
    }

}

}

 

plank.json:

{
    "variants": {
        "woodtype=alder": { "model": "em:alderplank" },
        "woodtype=ash": {"model": "em:medium_crafting_table"},
        "woodtype=aspen": {"model": "em:medium_crafting_table"},
        "woodtype=cedar": {"model": "em:medium_crafting_table"},
        "woodtype=cherry": {"model": "em:medium_crafting_table"},
        "woodtype=elm": {"model": "em:medium_crafting_table"},
        "woodtype=eucalyptus": {"model": "em:medium_crafting_table"},
        "woodtype=fir": {"model": "em:medium_crafting_table"},
        "woodtype=hickory": {"model": "em:medium_crafting_table"},
        "woodtype=mahogany": {"model": "em:medium_crafting_table"},
        "woodtype=maple": {"model": "em:medium_crafting_table"},
        "woodtype=pine": {"model": "em:medium_crafting_table"},
        "woodtype=poplar": {"model": "em:medium_crafting_table"},
        "woodtype=redwood": {"model": "em:medium_crafting_table"},
        "woodtype=teak": {"model": "em:medium_crafting_table"},
        "woodtype=willow": {"model": "em:medium_crafting_table"},
        "woodtype=yew": {"model": "em:small_crafting_table"}
    }
}

 

 

Link to comment
Share on other sites

You have 17 types. You can only have 16 of those being saved as metadata (metadata is still saved as 4 bits => 0-15).

The world now thinks the block is from the last type when it's actually the first one.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

So what you are saying is that I can only have 16 different types saved in metadata. So if you want more than 16 you have to register several blocks? Or is it possibly to setup another Enum?

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.