[1.8]Entities not spawning with the exact same data

[The_Fireplace]

So, I am making it so mobs are reborn at full health during LivingDropsEvent, and it works, except for some data not remaining the same as the original. Here is the void being called during the LivingDropsEvent:

 

  Reveal hidden contents

 

private void createEntity(LivingDropsEvent event){
NBTTagCompound storedData = event.entityLiving.getEntityData();//As you can see, I am storing the NBT here...
EntityLivingBase entity;
World worldIn = event.entityLiving.worldObj;
int id = EntityList.getEntityID(event.entityLiving);
ItemStack weapon = event.entityLiving.getHeldItem();
entity = (EntityLivingBase) EntityList.createEntityByID(id, worldIn);
    entity.setLocationAndAngles(event.entityLiving.posX, event.entityLiving.posY, event.entityLiving.posZ, MathHelper.wrapAngleTo180_float(worldIn.rand.nextFloat() * 360.0F), 0.0F);
    entity.rotationYawHead = entity.rotationYaw;
    entity.renderYawOffset = entity.rotationYaw;
    ((EntityLivingBase) entity).writeToNBT(storedData);//...and writing it to the new entity here
    entity.setCurrentItemOrArmor(0, weapon);
worldIn.spawnEntityInWorld(entity);
}

 

 

Some of the data not staying the same that I have noticed is:

Villager color always becomes the brown one

Rabbit color always becomes the brown one

Baby villagers become fully grown, probably does that for other animals as well

 

Any help would be appreciated.

[larsgerrits]

You need to use

readFromNBT

on the entity, instead of

writeToNBT

.

[The_Fireplace]

Ok, I hit thank you too soon...

After doing what you said, they don't spawn at all.

[Draco18s]

Probably because the date you inserted into the new entity says that it should be dead (0 health, etc.).

[The_Fireplace]

  On 3/6/2015 at 9:12 PM, Draco18s said:

Probably because the date you inserted into the new entity says that it should be dead (0 health, etc.).

How exactly do I fix this issue? I have tried multiple times, and they all have failed. Here is what I have tried:

private void createEntity(LivingDropsEvent event){
EntityLivingBase entity;
World worldIn = event.entityLiving.worldObj;
int id = EntityList.getEntityID(event.entityLiving);
NBTTagCompound storedData = event.entityLiving.getEntityData();
ItemStack weapon = event.entityLiving.getHeldItem();
entity = (EntityLivingBase) EntityList.createEntityByID(id, worldIn);
    entity.setLocationAndAngles(event.entityLiving.posX, event.entityLiving.posY, event.entityLiving.posZ, MathHelper.wrapAngleTo180_float(worldIn.rand.nextFloat() * 360.0F), 0.0F);
    entity.rotationYawHead = entity.rotationYaw;
    entity.renderYawOffset = entity.rotationYaw;
    storedData.setInteger("health", (int) event.entityLiving.getMaxHealth());
    ((EntityLivingBase) entity).readFromNBT(storedData);
    entity.setCurrentItemOrArmor(0, weapon);
worldIn.spawnEntityInWorld(entity);
}

private void createEntity(LivingDropsEvent event){
EntityLivingBase entity;
World worldIn = event.entityLiving.worldObj;
int id = EntityList.getEntityID(event.entityLiving);
NBTTagCompound storedData = event.entityLiving.getEntityData();
ItemStack weapon = event.entityLiving.getHeldItem();
entity = (EntityLivingBase) EntityList.createEntityByID(id, worldIn);
    entity.setLocationAndAngles(event.entityLiving.posX, event.entityLiving.posY, event.entityLiving.posZ, MathHelper.wrapAngleTo180_float(worldIn.rand.nextFloat() * 360.0F), 0.0F);
    entity.rotationYawHead = entity.rotationYaw;
    entity.renderYawOffset = entity.rotationYaw;
    entity.setHealth(event.entityLiving.getMaxHealth());
    ((EntityLivingBase) entity).readFromNBT(storedData);
    entity.setCurrentItemOrArmor(0, weapon);
worldIn.spawnEntityInWorld(entity);
}

[Ernio]

Have you even looked at NBT methods?

You actually don't need some of what you did at all. Things like rotation are saved inside NBT (print it out and see, or just look at code).

 

Also it's "Health" not "health". There are also FEW health fields (HealF for example). You'd be better off reading callback hierarchy

 

EDIT:

Few things:

1. Not every entity has NBT, NBT is only created for "special" ones. That will be tamed, named with label or mobs with amour (and animals). Rest of them are spawned randomly via world spawner, not saved on disk and loaded later, so 1st check for NBT.

2. Tho I have no idea why it doesn't work - your entity IS being SPAWNED. It's location is 0,0,0 (auto-death) and I honestly have no idea why. Things like setLocationAndAngles seem to not be working.

I only managed to make them work when i put them after spawn-code:

worldIn.spawnEntityInWorld(entity);
	entity.setLocationAndAngles(event.entityLiving.posX, event.entityLiving.posY, event.entityLiving.posZ, MathHelper.wrapAngleTo180_float(worldIn.rand.nextFloat() * 360.0F), 0.0F);
	entity.rotationYawHead = entity.rotationYaw;
	entity.renderYawOffset = entity.rotationYaw;

The entity is being spawned at 0,0,0 and moved to x,y,z desired - that is NOT best way, but still - all happens in one chunk of code so it's literally like you would spawn it in x,y,z.