Register Packet Type

[Torojima]

I have build my network communication on one channel sending different classes of Packets, derived from the Packet250CustomPayload class. In the Packet handler I check for the class of the just received packet, to decide which class should do the handling:

 

 

  Reveal hidden contents

package chococraft.common.network;

import net.minecraft.src.NetworkManager;
import net.minecraft.src.Packet250CustomPayload;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.Player;

public class ChocoboPacketHandler implements IPacketHandler
{    
   public ChocoboPacketHandler()
   {
   }

   @Override
   public void onPacketData(NetworkManager manager, Packet250CustomPayload packet, Player player)
   {
      if (packet instanceof PacketChocoboHealth)
      {
         PacketChocoboHealth.handleUpdate(packet, player);
      }
      else if (packet instanceof PacketChocoboMount)
      {
         PacketChocoboMount.handleUpdate(packet, player);
      }
      else if (packet instanceof PacketChocoboTamed)
      {
         PacketChocoboTamed.handleUpdate(packet, player);
      }
      else if (packet instanceof PacketChocoboAttribute)
      {
         PacketChocoboAttribute.handleUpdate(packet, player);
      }
      else if (packet instanceof PacketChocoboRiderJump)
      {
         PacketChocoboRiderJump.handleUpdate(packet, player);
      }
      else if (packet instanceof PacketChocoboDropSaddleAndBags)
      {
         PacketChocoboDropSaddleAndBags.handleUpdate(packet, player);
      }
   }
}

 

 

this works well on the SSP side. But, as I had to learn just now, crashes when I try to run my mod with an SMP server.

 

The problem is, the Packet class does not know about my new Packet classes, so they produce a NullPointerException.

 

  Reveal hidden contents

 

2012-10-21 18:54:00 [iNFO] [sTDERR] java.lang.NullPointerException

2012-10-21 18:54:00 [iNFO] [sTDERR] at db.k(Packet.java:122)

2012-10-21 18:54:00 [iNFO] [sTDERR] at db.a(Packet.java:176)

2012-10-21 18:54:00 [iNFO] [sTDERR] at bb.h(TcpConnection.java:201)

2012-10-21 18:54:00 [iNFO] [sTDERR] at bb.d(TcpConnection.java:533)

2012-10-21 18:54:00 [iNFO] [sTDERR] at bd.run(SourceFile:114)

 

 

 

The vanilla packets themselve are added statically, hard coded in the Packet class to the list of known Packets. Of course the Packet lists are not protected, but private...

 

from the net.minecraft.src.Packet class:

 

  Reveal hidden contents

/** List of the client's packet IDs. */
private static Set clientPacketIdList = new HashSet();

/** List of the server's packet IDs. */
private static Set serverPacketIdList = new HashSet();

 

 

now there is a static method in the Packet class adding new Packets to the list. In fact it is used in the static part of the Packet class to add the vanilla Packets to the above mentioned lists.

 

 

  Reveal hidden contents

static void addIdClassMapping(int par0, boolean par1, boolean par2, Class par3Class)

 

 

and this time the method has no explicitly declared access modifier and thus it is effectively private (ARGH!!! sloppy programming, but I presume they would have made it private anyway ...).

 

Thus even so, my Packet class is ultimately derived from the Packet class, I can not access the Packet list nor the add method, thus can not use my Packets in SMP (and I wonder how it is working in SSP in the first place).

 

So, my suggestion is, could you have the Forge packet alter the Packet class so that

 

a) the addIdClassMapping will receive the protected access modifier

 

and

 

b) there is a method to get the next free packetId to be used for the next Packet registration?

[LexManos]

Simple, don't add a new packet type, there is no need to and you fuck up compatibility if you do.