1.8 'middle' message problem (Not titles)

[LCastr0]

Hello.

I was playing a game today and I noticed the middle message bar is kinda... 'down'...

I mean, it's not where it should be.

I made some screenshots. One with LiteLoader + Forger (Bugged message), one with LiteLoader only (message is correct) and one with Forge only (Bugged message):

http://imgur.com/zzkHYUq,aStXrLn,GpCFpvy

[LexManos]

Whatever you're using that adds the extra hearts is not using the Forge system.

In our system everything knows the height of everything and adjusts itself accordingly.

[LCastr0]

Uh, i'm not talking about the hearts...

You can see the height of the middle message, it's not where it should be...

I'll even post one more image from the vanilla mc using that middle message.

It's not the item name, it's the 1.8 middle chat message. (It's also not the 1.8 title)

As you can see in this image (http://i.imgur.com/jGlDmZ0.png) the message is above the hearts (Vanilla)

In this one, it's also above the hearts (http://i.imgur.com/zzkHYUq.png) (LiteLoader only)

But in this (http://i.imgur.com/aStXrLn.png) and this (http://i.imgur.com/GpCFpvy.png) ones, they are 'under' the hearts (LiteLoader+Forge and Forge only)

 

So, please, don't say it uses the correct locations for the messages, because as you can see in the images, it doesn't.

(Again, I'm NOT talking about the hearts, but the colored message ABOVE them)

[LCastr0]

I submitted a fix.

It's actually not the jukebox message, but thanks anyway... you did something

That might fix the issue though... I hope.

[LCastr0]

It must be the jukebox message that is being used by some plugin. It's the only type of message that vanilla displays there.

In 1.8, there is 1 more packet that sends different types of messages, i think it's called Action bar

You can see more about the packet here: http://wiki.vg/Protocol#Chat_Message (Note that if you use the '2' byte, it displays above the action bar, but it's not the jukebox message)

[LCastr0]

It's probably the renderChat() method, which also uses the - 48 height...

[LCastr0]

I just looked at the code. If that value 2 is received it just sets the jukebox message. It's not called jukebox message anyways, just "overlay  message" in the code.

Really? Because some times i can see both the 'action bar' and the jukebox text, but ok, thanks anyway

[LCastr0]

Are you sure it's not the tool highlight?

I just checked the code again, jukebox message and the packet you mentioned above (which is used for the "this chest is locked" message, btw.) go through the exact same method.

Well it could be the jukebox, i'm not sure... I only know how it works in Bukkit/Spigot, not in forge

But it's not the tool highlight for sure

[LCastr0]

Bukkit works with vanilla, and Forge does not alter this code at all. So yeah, it must be the jukebox message, because that's the only one that vanilla provides.

Alright, I'll wait for the next build and try again, and if it's still bugged i quote you again

[LCastr0]

No need to wait. It's already out.

Oh I'll test it in a minute!

[LCastr0]

No need to wait. It's already out.

Uh i can't find it in the files.minecraftforge.net list... is there anywhere else i can find it?

[LexManos]

It's there. 1337

[LCastr0]

Alright, it's fixed! Thanks!