Jump to content

[1.8] X, Y, Z coordinates to Blockpos


xwerswoodx

Recommended Posts

Hello All;

 

at 1.7.10 we use this to generate blocks;

 

package net.extend.mod.functions;

import java.util.Random;

import net.extend.mod.blockref;
import net.extend.mod.configref;
import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;

public class generation implements IWorldGenerator {

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

	switch (world.provider.getDimensionId()) {
	case -1:
		generateNether();
		break;
	case 0:
		//generateSurface(world, random, chunkX * 16, chunkZ * 16, blockref.acidOre, 5, 50);
		generateSurface(world, random, chunkX * 16, chunkZ * 16, blockref.blackDiamondOre, 4, 12);
		generateSurface(world, random, chunkX * 16, chunkZ * 16, blockref.nightOre, 3, 10);
		break;
	case 1:
		generateEnd();
		break;
	}
}

//generateSurface(WORLD, RANDOM, CHUNKX * 16, CHUNKY * 16, AcidMod.ore.blockID, AMOUNT, Y)
public void generateSurface(World world, Random random, int chunkX, int chunkZ, Block str, int amount, int chunkY) {
	for (int i=0; i < 20; i++) {
		int oreX = chunkX + random.nextInt(16);
		int oreY = random.nextInt(chunkY);
		int oreZ = chunkZ + random.nextInt(16);
		(new WorldGenMinable(str, amount)).generate(world, random, oreX, oreY, oreZ);
	}
    }

 

But in 1.8 version, we need to use BlockPos, but in here we calculate X, Y and Z's coordinates to place, so how can I update this X, Y, Z to BlockPos?

 

Edit: also when I add new block, what is it's block state? how can I use it?

Link to comment
Share on other sites

Ah yes you true, I fixed it thanks and also my block is extend by Block so how can I replace in this code to IBlockState or how can I get it?

 

I fixed it like

IBlockState state = (IBlockState)str.getBlockState();

 

But I am not sure if it is work or not. Anyway, what is the BlockState holds on? I saw some different code like "world.getBlockState(BlockPos)", can I use this like;

 

if world.getBlockState(BlockPos) == Block.coal_ore

 

These are very different, we need to learn everything in every version uh. Is there any documentations about new functions n 1.8

Link to comment
Share on other sites

It is replacement of metadata in 1.8; So Block#getBlockState() just gives base state of the block, which is fairly wrong.

So you should use World#getBlockState(BlockPos).

And for coal ore, comparing block instance is just fine. Don't compare IBlockState and Block, they are completely different object.

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Link to comment
Share on other sites

Oh, not I mean like this;

 

I have a code like this;

				if (world.getBlock(x1, y1, z1) == Blocks.coal_ore) {
					found.add(new int[] { x1, y1, z1 });
				}

 

But there is no getblock in 1.8 so if I change this to;

 

                                        BlockPos pos1 = new BlockPos(x1, y1, z1);
				if (world.getBlockState(pos1) == Blocks.coal_ore.getBlockState()) {
					found.add(new int[] { x1, y1, z1 });
				}

 

Is it work correctly?

 

And also you said blockstate and Iblockstate is very different so how can I fix my worldminable code

 

public void generateSurface(World world, Random random, int chunkX, int chunkZ, Block str, int amount, int chunkY) {
	for (int i=0; i < 20; i++) {
		int oreX = chunkX + random.nextInt(16);
		int oreY = random.nextInt(chunkY);
		int oreZ = chunkZ + random.nextInt(16);
		BlockPos pos1 = new BlockPos(oreX, oreY, oreZ);
		IBlockState state = (IBlockState)str.getBlockState();
		(new WorldGenMinable(state, amount)).generate(world, random, pos1);
	}
    }

I did something like this

 

		generateSurface(world, random, chunkX * 16, chunkZ * 16, blockref.blackDiamondOre, 4, 12);
		generateSurface(world, random, chunkX * 16, chunkZ * 16, blockref.nightOre, 3, 10);

Link to comment
Share on other sites

                                        BlockPos pos1 = new BlockPos(x1, y1, z1);
				if (world.getBlockState(pos1) == Blocks.coal_ore.getBlockState()) {
					found.add(new int[] { x1, y1, z1 });
				}

 

Not sure if that will work, however I know this will work

 

                                        BlockPos pos1 = new BlockPos(x1, y1, z1);
				if (world.getBlockState(pos1).getBlock() == Blocks.coal_ore) {
					found.add(new int[] { x1, y1, z1 });
				}

 

As for your second issue I don't know world gen, sorry.

Link to comment
Share on other sites

Ah thank you I hope it works, I can try it after I fixed all of my errors because I am trying to update my items from 1.7.10 to 1.8.0 so it little bit hard. What about second question, how can I get IBlockState for custom block.

 

There is a function like getBlockState but it isn't IBlockState so how can I get it?

 

I found a function like this;

 

world.getBlockState(BlockPos) : IBlockState

 

and I tried like this;

 

BlockPos pos1 = new BlockPos(oreX, oreY, oreZ);
(new WorldGenMinable(world.getBlockState(pos1), amount)).generate(world, random, pos1);

 

It works without error, I am not sure but if there is someone stuck about this maybe help them.

 

Thanks for help.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Update: I managed to make the item not disappear after crafting, but it doesn't remove any durability. import net.minecraft.enchantment.EnchantmentHelper; import net.minecraft.enchantment.Enchantments; import net.minecraft.enchantment.UnbreakingEnchantment; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; public class NuggetHammer extends Item { private boolean damage; public NuggetHammer(Properties p_i48487_1_) { super(p_i48487_1_); } @Override public int getMaxDamage(ItemStack stack) { return 54 - 1; } public boolean isBarVisible(ItemStack stack) { return false; } @Override public ItemStack getContainerItem(ItemStack stack) { ItemStack copy = stack.copy(); copy.setCount(1); if (!this.damage) return copy; int unbreaking = EnchantmentHelper.getItemEnchantmentLevel(Enchantments.UNBREAKING, stack); for (int i = 0; i < unbreaking; i++) { if (UnbreakingEnchantment.shouldIgnoreDurabilityDrop(stack, unbreaking, random)) return copy; } copy.setDamageValue(stack.getDamageValue() + 1); if (copy.getDamageValue() > stack.getMaxDamage()) return ItemStack.EMPTY; return copy; } }  
    • I cannot find the answer anywhere public static void onPlayerConsumeXp(PlayerXpEvent.PickupXp event){ if(event.getEntity().getMainHandItem().getAllEnchantments().get(*value i need*) != null){ int shorthand = event.getEntity().getMainHandItem().getAllEnchantments().get(*value i need*); I am trying to get my custom enchant inside that *value i need*, I have tried using strings and Enchantments. does not show my enchantment. This is my enchantment class package net.test.tutorialmod.enchants; import net.minecraft.world.entity.EquipmentSlot; import net.minecraft.world.item.enchantment.Enchantment; import net.minecraft.world.item.enchantment.EnchantmentCategory; public class clever extends Enchantment { public clever(Rarity pRarity, EnchantmentCategory pCategory, EquipmentSlot... pApplicableSlots) { super(pRarity, pCategory, pApplicableSlots); } @Override public int getMaxLevel() { return 10; } @Override public int getMinLevel() { return 1; } }  What am i doing wrong?  
    • I had this same issue, it was one of the mods I had installed, some mods seem to break with certain versions of forge and cause others to break as well, trial and error different mods till you find the broken one.  
    • Hi, I'm asking for your help because I can't figure out how to make it so that when an item is crafted on the Crafting Table, it returns the item to the player's inventory and makes the item lose durability. I've tried looking everywhere without success. Like for the crafting of the cake which returns the empty bucket to the player, but also makes it lose durability.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.