Search the Forums BEFORE making a new post.

[1.8][1.7.10] Discuss about IntCache

Posted April 7, 201510 yr

IntCache is used in GenLayer and its subclasses to cache int arrays. It's reseted in the front of biome-related methods such as getBiomesForGeneration or getBiomeGenAt. Now here comes a problem:

GenLayer.getInt is called in both CLIENT and SERVER sides. It's ok using a dedicated server. However, in intergrated server, CLIENT and SERVER sides are in two thread. So they may call a biome method at same time. That means, IntCache might be reseted in CLIENT thread while SERVER thread is using it! If unlucky, game crashes.

I suffered from the crash for a long time but coundn't find the reason. I got it just now as I put a printing current thread statement in my GenLayer.getInts method. I found out that it was called in both CLIENT and SERVER threads. I realized what was responsible for these crashes. Now I put one crash report fragment here:

---- Minecraft Crash Report ----
// Oops.

Time: 15-4-4 10:05 PM
Description: Getting biome

java.lang.ArrayIndexOutOfBoundsException: 114
at me.herbix.taoland.world.gen.layer.GenLayerByProperty.getInts(GenLayerByProperty.java:65)
at me.herbix.taoland.world.gen.layer.GenLayerZoom.getInts(GenLayerZoom.java:25)
at me.herbix.taoland.world.gen.layer.GenLayerZoom.getInts(GenLayerZoom.java:25)
at me.herbix.taoland.world.gen.layer.GenLayerZoom.getInts(GenLayerZoom.java:25)
at me.herbix.taoland.world.gen.layer.GenLayerZoom.getInts(GenLayerZoom.java:25)
at net.minecraft.world.gen.layer.GenLayerSmooth.getInts(GenLayerSmooth.java:23)
at me.herbix.taoland.world.gen.layer.GenLayerRiverMix.getInts(GenLayerRiverMix.java:18)
at net.minecraft.world.gen.layer.GenLayerVoronoiZoom.getInts(GenLayerVoronoiZoom.java:25)
at net.minecraft.world.biome.WorldChunkManager.getBiomeGenAt(WorldChunkManager.java:199)
at net.minecraft.world.biome.BiomeCache$Block.<init>(BiomeCache.java:106)
at net.minecraft.world.biome.BiomeCache.getBiomeCacheBlock(BiomeCache.java:37)
at net.minecraft.world.biome.BiomeCache.func_180284_a(BiomeCache.java:48)
at net.minecraft.world.biome.WorldChunkManager.func_180300_a(WorldChunkManager.java:75)
at net.minecraft.world.chunk.Chunk.getBiome(Chunk.java:1442)
at net.minecraft.world.World.getBiomeGenForCoordsBody(World.java:196)
at net.minecraft.world.WorldProvider.getBiomeGenForCoords(WorldProvider.java:429)
at net.minecraft.world.World.getBiomeGenForCoords(World.java:185)
at net.minecraftforge.client.ForgeHooksClient.getSkyBlendColour(ForgeHooksClient.java:388)
at net.minecraft.world.World.getSkyColorBody(World.java:1524)
at net.minecraft.world.WorldProvider.getSkyColor(WorldProvider.java:463)
at net.minecraft.world.World.getSkyColor(World.java:1511)
at net.minecraft.client.renderer.EntityRenderer.updateFogColor(EntityRenderer.java:1757)
at net.minecraft.client.renderer.EntityRenderer.renderWorldPass(EntityRenderer.java:1277)
at net.minecraft.client.renderer.EntityRenderer.renderWorld(EntityRenderer.java:1263)
at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1088)
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1107)
at net.minecraft.client.Minecraft.run(Minecraft.java:376)
at net.minecraft.client.main.Main.main(Main.java:117)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)
at GradleStart.main(Unknown Source)

Hmm.. IntCache shall not be access from CLIENT thread I thought, because generating biomes is a SERVER function. There must be some better way to implement ForgeHooksClient.getSkyBlendColour I suppose.

Author of Tao Land Mod.

width=200 height=69 http://taoland.herbix.me/images/1/14/TaoLandLogo.png[/img]

Also, author of RenderTo

----

I'm not an English native speaker. I just try my best.

Quote

April 7, 201510 yr

Author

Oops. I found out that vanilla EntityRenderer.addRainParticles uses World.getBiomeGenForCoords as well.

But I still doubt whether this would cause crash.

Edit: More and more CLIENT side uses found. That's not a mistake of ForgeHooksClient.getSkyBlendColour.

Author of Tao Land Mod.

width=200 height=69 http://taoland.herbix.me/images/1/14/TaoLandLogo.png[/img]

Also, author of RenderTo

----

I'm not an English native speaker. I just try my best.

Quote

April 7, 201510 yr

Actually everything (even other mods) that get the biome for specific coords uses that method.

It seems like one of those examples where Mojang didn't see the necessity (probably unintentional) to make it safe for multithreading...

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Quote

April 7, 201510 yr

Author

It seems like one of those examples where Mojang didn't see the necessity (probably unintentional) to make it safe for multithreading...

The strangest thing is that I didn't feel a vanilla crash caused by getInts. It only happens to my mod. I'm sure it's a multithreading problem, but not sure why crash occurs only in my mod.

Author of Tao Land Mod.

width=200 height=69 http://taoland.herbix.me/images/1/14/TaoLandLogo.png[/img]

Also, author of RenderTo

----

I'm not an English native speaker. I just try my best.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/29165-181710-discuss-about-intcache/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 8 hours ago8 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 16 hours ago16 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 16 hours ago16 hr
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · 21 hours ago21 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day

VictorEvers

Sign In

[1.8][1.7.10] Discuss about IntCache

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)