Random Coordinates Near Player Not Working Correctly

[Cephrus]

I have this code that executes each worldtick:

 

Random random = new Random();
	int randX = random.nextInt(16);
	//int randY = random.nextInt(256);
	int randZ = random.nextInt(16);
	int randY = EAToolkit.getTopBlock(world, randX, randZ);
	int j1 = random.nextInt();

	int i2 = MathHelper.floor_double(focusPlayer.posX);
	int k2 = MathHelper.floor_double(focusPlayer.posZ);
	byte byte0 = 7;
	for(int i3 = -byte0; i3 <= byte0; i3++)
	{
		for(int k3 = -byte0; k3 <= byte0; k3++)
		{
			int l3 = i3 * 16 + i2;
			int i4 = k3 * 16 + k2;
			j1 = j1 * 3 + 0x3c6ef35f;
			int j4 = j1 >> 2;
			int k4 = j4 & 0xf;
			int l4 = j4 >> 8 & 0xf;
			int i5 = k4 + l3;
			int j5 = l4 + i4;

			if(phase >= 1)
			{
				blockBuffer++;

				if(blockBuffer >= 60)
				{
					BlockPos blk = new BlockPos(randX, randY, randZ);
					Chunk chunk = world.getChunkFromChunkCoords(i5 + (int)focusPlayer.posX, j5 + (int)focusPlayer.posZ);
					Block block = chunk.getBlock(blk);

					if(block == Blocks.grass)
					{
						chunk.setBlockState(blk, Blocks.dirt.getDefaultState());
					}

					if(block == Blocks.leaves)
					{
						chunk.setBlockState(blk, Blocks.air.getDefaultState());
					}

					blockBuffer = 0;
				}
			}
		}
	}

 

It is supposed to get a random block near the player, and if it is either leaves or grass, change the block to air or dirt.

However, the code doesn't seem to be working. I have put debug System.out.println() calls in the code for the grass, and it does work, but no grass changes.

 

Any and all help is appreciated.

[jabelar]

The math you're doing is extremely crazy. Why are you doing all that? That one hexadecimal number you're adding is probably like way outside the entire game, it wouldn't be close to the player.

 

Why don't you just use the randX and randZ and add those to the player position. That's all you should need for random position near the player.

 

If you insist on doing that crazy math, put a system console statement after every line that prints out the value calculated and check that it is what you expect.

[Draco18s]

int l3 = i3 * 16 + i2;
int i4 = k3 * 16 + k2;
j1 = j1 * 3 + 0x3c6ef35f;
int j4 = j1 >> 2;
int k4 = j4 & 0xf;
int l4 = j4 >> 8 & 0xf;
int i5 = k4 + l3;
int j5 = l4 + i4;

 

Hold on.

 

Is that a pseudo-random number generator?

Why?  Why for the love of god did you write your own RNG and then supply it with inputs that were already random?

[Cephrus]

Substituting the RNG for randX and randZ also does nothing.

 

By adding a println() call to the grass if() statement produces more action with the RNG than randX and randZ.

But nothing happens in the world.

[jabelar]

I don't think you understood.

 

Also, the world already had a random number generator so no real need to create a new one each tick.

 

Next, you don't need to do anything with chunks. World is able to set blocks and get blocks directly from the world coordinates.

 

So I think your code should simply be (assumes you have event parameter from WorldTickEvent handler method):

 

      int playerPosX = MathHelper.floor_double(focusPlayer.posX);

      int playerPosY = MathHelper.floor_double(focusPlayer.posY);

      int playerPosZ = MathHelper.floor_double(focusPlayer.posZ);

      byte effectRange = 7;

      for(int xOffset = -effectRange; xOffset <= effectRange; xOffset++)

      {

          for(int zOffset = -effectRange; zOffset <= effectRange; zOffset++)

          {

            if(phase >= 1)

              {

                  blockBuffer++;

                 

                  if(blockBuffer >= 60)

                  {

                      BlockPos blockPos = new BlockPos(event.world.rand.nextInt(16)+playerPosX, playerPosY, event.world.rand.nextInt(16)+playerPosZ);

                      Block theBlock = event.world.getBlockState(blockPos).getBlock();

                     

                      if(theBlock == Blocks.grass)

                      {

                          event.world.setBlockState(blockPos, Blocks.dirt.getDefaultState());

                      }

                     

                      if(theBlock == Blocks.leaves)

                      {

                          event.world.setBlockState(blockPos, Blocks.air.getDefaultState());

                      }

                     

                      blockBuffer = 0;

                  }

              }

          }

      }