Search the Forums BEFORE making a new post.

[1.8] [SOLVED] Disabling Custom Ore Generation Using Configs

Posted April 22, 201510 yr

Can anyone help me with this problem I have?

Basically I want my ores to be configurable so you can choose whether to generate them or not and with the code I have at the moment (see below) this is not working as when I set it to false in the config it still generates the ore.

So if there's a certain way to do this then please let me know as this is beginning to bug me .

Ore Gen:

package common.industrialistechnologia.utility_libraries;

import java.util.Random;

import common.industrialistechnologia.initialization.core.BlocksCore;
import net.minecraft.block.Block;
import net.minecraft.init.Blocks;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;
import net.minecraftforge.fml.common.eventhandler.Event;
import net.minecraftforge.fml.common.eventhandler.Event.Result;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class WorldGenerationOres implements IWorldGenerator
{
// Which dimension to generate in by dimension ID (Nether -1, Overworld 0, End 1, etc)
@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider)
{
	switch (world.provider.getDimensionId())
	{
	case -1:
		//generateNether(world, random, chunkX * 16, chunkZ * 16);
		break;
	case 0:
		generateSurface(world, random, chunkX * 16, chunkZ * 16);
		break;
	case 1:
		//generateEnd(world, random, chunkX * 16, chunkZ * 16);
		break;
	}
}

private void generateSurface(World world, Random random, int x, int z) 
{
	this.addOreSpawnAmblygonite(BlocksCore.ore_amblygonite, world, random, x, z, 16, 16, 10+random.nextInt(14), 1, 18, 42, Blocks.stone);
	this.addOreSpawnApatite(BlocksCore.ore_apatite, world, random, x, z, 16, 16, 20+random.nextInt(30), 1, 70, 128, Blocks.stone);
	this.addOreSpawnCopper(BlocksCore.ore_bornite, world, random, x, z, 16, 16, 4+random.nextInt(6), 5, 25, 60, Blocks.stone);
	this.addOreSpawnCopper(BlocksCore.ore_chalcopyrite, world, random, x, z, 16, 16, 4+random.nextInt(6), 5, 25, 60, Blocks.stone);
	this.addOreSpawnCopper(BlocksCore.ore_copper, world, random, x, z, 16, 16, 4+random.nextInt(6), 2, 25, 60, Blocks.stone);
	this.addOreSpawnCopper(BlocksCore.ore_malachite, world, random, x, z, 16, 16, 4+random.nextInt(6), 4, 25, 60, Blocks.stone);
}

private void addOreSpawnAmblygonite(Block block, World world, Random random, int blockXPos, int blockZPos, int maxX, int maxZ, int maxVeinSize, int chanceToSpawn, int minY, int maxY, Block generateIn)
{
	for(int i = 0; i < chanceToSpawn; i++) 
	{
		int posX = blockXPos + random.nextInt(maxX);
		int posY = minY + random.nextInt(maxY - minY);
		int posZ = blockZPos + random.nextInt(maxZ);
		BlockPos blockPos = new BlockPos(posX, posY, posZ);
		if (ConfigurationHandler.enableGeneration = true)
		{
			(new WorldGenMinable(BlocksCore.ore_amblygonite.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
		}
	}
}

private void addOreSpawnApatite(Block block, World world, Random random, int blockXPos, int blockZPos, int maxX, int maxZ, int maxVeinSize, int chanceToSpawn, int minY, int maxY, Block generateIn) 
{	
	for(int i = 0; i < chanceToSpawn; i++) 
	{
		int posX = blockXPos + random.nextInt(maxX);
		int posY = minY + random.nextInt(maxY - minY);
		int posZ = blockZPos + random.nextInt(maxZ);
		BlockPos blockPos = new BlockPos(posX, posY, posZ);
		if (ConfigurationHandler.enableGeneration = true)
		{
			(new WorldGenMinable(BlocksCore.ore_apatite.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
		}else{
			if (ConfigurationHandler.enableGeneration = false)
					{
				(new WorldGenMinable(BlocksCore.ore_apatite.getDefaultState(), 0)).generate(world, random, blockPos);
					}
		}
	}
}

private void addOreSpawnCopper(Block block, World world, Random random, int blockXPos, int blockZPos, int maxX, int maxZ, int maxVeinSize, int chanceToSpawn, int minY, int maxY, Block generateIn) 
{
	for(int i = 0; i < chanceToSpawn; i++) 
	{
		int posX = blockXPos + random.nextInt(maxX);
		int posY = minY + random.nextInt(maxY - minY);
		int posZ = blockZPos + random.nextInt(maxZ);
		BlockPos blockPos = new BlockPos(posX, posY, posZ);
		if (ConfigurationHandler.enableGeneration = true)
		{
			(new WorldGenMinable(BlocksCore.ore_bornite.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
			(new WorldGenMinable(BlocksCore.ore_chalcopyrite.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
			(new WorldGenMinable(BlocksCore.ore_copper.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
			(new WorldGenMinable(BlocksCore.ore_malachite.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
		}
	}
}
}

Configuration Handler:

package common.industrialistechnologia.utility_libraries;

import net.minecraftforge.common.config.Configuration;
import net.minecraftforge.fml.client.event.ConfigChangedEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import java.io.File;
import common.industrialistechnologia.reference_libraries.ModInfo;

import java.io.File;

public class ConfigurationHandler
{
    public static Configuration configuration;
    public static String generation = "Generation";
public static boolean enableGeneration;

    public static void init(File configFile)
    {
        // Create the configuration object from the given configuration file
        if (configuration == null)
        {
            configuration = new Configuration(configFile);
            loadConfiguration();
        }
    }

    private static void loadConfiguration()
    {
    	enableGeneration = configuration.get(generation, "Enable Apatite Generation", true, "Enable Apatite generation").getBoolean(enableGeneration);

	configuration.addCustomCategoryComment(generation, "This section contains all settings regarding ore generation.");

        if (configuration.hasChanged())
        {
            configuration.save();
        }
    }

    @SubscribeEvent
    public void onConfigurationChangedEvent(ConfigChangedEvent.OnConfigChangedEvent event)
    {
        if (event.modID.equalsIgnoreCase(ModInfo.CORE_MOD_ID))
        {
            loadConfiguration();
        }
    }
}

Quote

April 22, 201510 yr

I'll give you a hint -- the bug is in this line :-)

if (ConfigurationHandler.enableGeneration = true)

Quote

April 22, 201510 yr

Author

I'll give you a hint -- the bug is in this line :-)
if (ConfigurationHandler.enableGeneration = true)

Thanks

I changed the code to this:

if (ConfigurationHandler.enableApatiteGeneration != false)
		{
			(new WorldGenMinable(BlocksCore.ore_apatite.getDefaultState(), maxVeinSize)).generate(world, random, blockPos);
		}else{
			(new WorldGenMinable(BlocksCore.ore_apatite.getDefaultState(), 0)).generate(world, random, blockPos);
		}

and changed the generation to false to see if any spawned and none did (checked an entire mountain biome and found none) and then set it back to true afterwards and found some instantly, so that seems to be working now

Quote

April 23, 201510 yr

= is assignment, == is comparison, and there's no need for explicit comparison with booleans, you can just do:

if(ConfigurationHandler.enableGeneration)

This checks if the boolean is true.

Quote

April 23, 201510 yr

Author

= is assignment, == is comparison, and there's no need for explicit comparison with booleans, you can just do:
if(ConfigurationHandler.enableGeneration)
This checks if the boolean is true.

Thanks for the help

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/29546-18-solved-disabling-custom-ore-generation-using-configs/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Orbital strike cannon fishing rod mod

@Astoxy The rods will break Ok that was a early build im just waiting for curse forge and modrinth to accept my mod btw here is v1.1.5
https://drive.google.com/file/d/1wa3-awKMEoxe2WUbxGZZDIxFo_QfLWCM/view?usp=sharing
v1.2.0 will be the final version

By FoxyWoxy · 1 hour ago1 hr
Orbital strike cannon fishing rod mod

mod works well it would be better if the fishing rod wasnt unbrekable tho hope u can make it for the newer versions @FoxyWoxy

By Astoxy · 2 hours ago2 hr
New Forum Design/Update: Issues and Suggestions

Hiho,

first of all I want to say that the new forum design looks really good.

However, there are currently two issues:

In the "Unread" section, the "Mark all as Read" feature seems to be missing - or am I just overlooking it somewhere?
Some threads don’t automatically get marked as read when you open them. So the post still shows up in "Unread," even though you’ve already viewed it.
Example Thread: https://forums.minecraftforge.net/topic/159415-cannot-find-client-log-entries/

Then I have a smaller suggestion, referring to the Text Editor:

It is possible to move out the "Inline Code"-Feature from the "More Formatting Options" and add it directly to the Text Editor Tool Bar?
Same for "Quote"-Feature inside the Create Section

These two features are used quite often (at least by me) - as far as I remember, they were also available in the old forum design.

@Paint_Ninja @LexManos

By TileEntity · Posted 4 hours ago4 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

That fixed it! it's still being weird and not actually printing anything to CMD but the logs look fine and eventually the gui generated looking normal. Thanks for your help I've done that on linux before but windows servers have always just worked with one click for some reason for me

By Linksapprentice · 7 hours ago7 hr
Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Make sure you are using Java 17 JDK

In the start script, replace the word "java" with the java 17 path (javaw.exe) and put it into quotation marks

By TileEntity · 10 hours ago10 hr

There are no registered users currently online

Sign In

[1.8] [SOLVED] Disabling Custom Ore Generation Using Configs

Featured Replies

Join the conversation

Posts

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Trying to boot MC Eternal 2 Server, works on linux not on Windows 11: Jvm args error

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)