Jump to content

Recommended Posts

Posted

Hi, i'm updating my code to 1.8 but i'm having some troubles with metadata blocks. After many tries i've figured out how to make them appear in inventory with the proper icon, but when i place them down they have no texture. I don't know how this happens, i also noticed that the code still search for a json file that refers to the name of the block without variant.

 

This is my block class

package mw.blocks;

import java.util.List;

import mw.blocks.itemblocks.ItemMarbleOre;
import mw.core.utils.Utils;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IStringSerializable;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class BlockMarbleOre extends Block
{
    public static final PropertyEnum VARIANT = PropertyEnum.create("variant", BlockMarbleOre.EnumType.class);

    public BlockMarbleOre()
    {
        super(Material.rock);
        this.setDefaultState(this.blockState.getBaseState().withProperty(VARIANT, BlockMarbleOre.EnumType.WHITE));
        this.setCreativeTab(CreativeTabs.tabBlock);
        Utils.setBlockInfo(this, "marble", 1.5F, 10.0F);
    }

    /**
     * Get the damage value that this Block should drop
     */
    public int damageDropped(IBlockState state)
    {
        return ((BlockMarbleOre.EnumType)state.getValue(VARIANT)).getMetadata();
    }

    /**
     * returns a list of blocks with the same ID, but different meta (eg: wood returns 4 blocks)
     */
    @SideOnly(Side.CLIENT)
    public void getSubBlocks(Item itemIn, CreativeTabs tab, List list)
    {
        BlockMarbleOre.EnumType[] aenumtype = BlockMarbleOre.EnumType.values();
        int i = aenumtype.length;

        for (int j = 0; j < i; ++j)
        {
            BlockMarbleOre.EnumType enumtype = aenumtype[j];
            list.add(new ItemStack(itemIn, 1, enumtype.getMetadata()));
        }
    }

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(VARIANT, BlockMarbleOre.EnumType.byMetadata(meta));
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        return ((BlockMarbleOre.EnumType)state.getValue(VARIANT)).getMetadata();
    }

    protected BlockState createBlockState()
    {
        return new BlockState(this, new IProperty[] {VARIANT});
    }

    public static enum EnumType implements IStringSerializable
    {
        WHITE(0, "white"),
        PINK(1, "pink");
        private static final BlockMarbleOre.EnumType[] META_LOOKUP = new BlockMarbleOre.EnumType[values().length];
        private final int meta;
        private final String name;
        private final String unlocalizedName;


        private EnumType(int meta, String name)
        {
            this(meta, name, name);
        }

        private EnumType(int meta, String name, String unlocalizedName)
        {
            this.meta = meta;
            this.name = name;
            this.unlocalizedName = unlocalizedName;
        }

        public int getMetadata()
        {
            return this.meta;
        }

        public String toString()
        {
            return this.name;
        }

        public static BlockMarbleOre.EnumType byMetadata(int meta)
        {
            if (meta < 0 || meta >= META_LOOKUP.length)
            {
                meta = 0;
            }

            return META_LOOKUP[meta];
        }

        public String getName()
        {
            return this.name;
        }

        public String getUnlocalizedName()
        {
            return this.unlocalizedName;
        }

        static
        {
            BlockMarbleOre.EnumType[] var0 = values();
            int var1 = var0.length;

            for (int var2 = 0; var2 < var1; ++var2)
            {
                BlockMarbleOre.EnumType var3 = var0[var2];
                META_LOOKUP[var3.getMetadata()] = var3;
            }
        }
    }
}

It's just a copy-paste of the BlockPlanks class (just for try)

 

This is the ItemBlock class, imported from the 1.7.10 code

package mw.blocks.itemblocks;

import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ItemMarbleOre extends ItemBlock{

private final static String[] subNames = {"white", "pink"};

public ItemMarbleOre(Block id)
{
	super(id);
	setHasSubtypes(true);
}

@Override
public int getMetadata (int metadata)
{
	return metadata;
}

@Override
public String getUnlocalizedName(ItemStack itemstack)
{
	return "tile." + subNames[itemstack.getItemDamage()] + "_" + "marble";
}
}

 

This is where i register the metadata block

package mw.core;

import mw.blocks.BlockMarbleOre;
import mw.blocks.itemblocks.ItemMarbleOre;
import net.minecraft.block.Block;
import net.minecraft.client.renderer.entity.RenderItem;
import net.minecraft.client.resources.model.ModelBakery;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class MWMetadataBlocks {

public static Block marble;

public static void addBlocks()
{
	marble = new BlockMarbleOre();
}

public static void registerBlocks(RenderItem renderItem)
{

	addBlock(marble, ItemMarbleOre.class, renderItem);

}

public static void addBlock(Block block, Class<? extends ItemBlock> itemblock, RenderItem renderItem)
{
	String name = block.getUnlocalizedName().substring(block.getUnlocalizedName().indexOf(".") + 1, block.getUnlocalizedName().length());

	GameRegistry.registerBlock(block, itemblock, name);


	if(block.equals(marble))
	{
		ModelBakery.addVariantName(Item.getItemFromBlock(block), new String[]{MW.MODID + ":" + "white_marble", MW.MODID + ":" + "pink_marble"});
		renderItem.getItemModelMesher().register(Item.getItemFromBlock(block), 0, new ModelResourceLocation(MW.MODID + ":" + "white_marble", "inventory"));
		renderItem.getItemModelMesher().register(Item.getItemFromBlock(block), 1, new ModelResourceLocation(MW.MODID + ":" + "pink_marble", "inventory"));
	}

}
}

 

The renderItem item is imported from the init method of the main mod file

 

This is the blockstate file for the white variant (the pink is the same but the name changed)

BlockState

{
"variants": {
	"normal": { "model": "mw:white_marble" }
}
}

Model/block

{
"parent": "block/cube_all",
"textures": {
	"all": "mw:blocks/white_marble"
}
}

Model/item

{
"parent": "mw:block/white_marble",
"display": {
	"thirdperson": {
		"rotation": [10, -45, 170],
		"translation": [0, 1.5, -2.75],
		"scale": [0.375, 0.375, 0.375]
	}
}
}

 

All the three files are named "white_marble"

 

When compiling i got this two errors

[13:08:03] [Client thread/ERROR] [FML]: Model definition for location mw:marble#variant=white not found
[13:08:03] [Client thread/ERROR] [FML]: Model definition for location mw:marble#variant=pink not found

 

And in game i have this as result

4hr1nr.png

 

Thanks in advice for all who will help me :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

your blockstate file needs to be something like this

"variants": {
"variant=white": { "model": "mw:white_marble" },
"variant=pink": {"model":"mw:pink_marble"}
}

unless you want to create a custom state map which is what minecraft does for the planks but you cant use the vanilla StateMap for variants due to the fact that there is no option for your modid so you need to create your own CustomSateMap

Did you really need to know?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • If you’ve lost crypto to a scam, don’t let shame or fear keep you silent. There are real experts out there who know how to fight back. Dexdert Net Recovery did the impossible for me, and they can do it for others too. Contact Dexdet Net Recovery For Help Visa Information Below:    
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.