Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.8] [SOLVED] Custom Potion Effect


DasNone
 Share

Recommended Posts

Hello everybody,

 

Just signed up but I have been lurking here for well over 2 years now. Now, my issue is following:

 

Whenever the potion is applied, it works as intended but as soon as it get cancelled out the functions won't get called (tested with the "System.out.println").

 

package net.dascraft.init;

import net.dascraft.Dascraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.event.entity.living.LivingEvent.LivingUpdateEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class DascraftEventHooks
{
@SubscribeEvent
public void onEntityUpdate(LivingUpdateEvent event)
{
	if (event.entityLiving.isPotionActive(Dascraft.protectionPotion))
	{
		if (event.entityLiving.worldObj.rand.nextInt(20) == 0)
		{
			if (event.entityLiving instanceof EntityPlayer)
			{
				EntityPlayer player = (EntityPlayer) event.entityLiving;
				player.capabilities.allowEdit = false;
				player.sendPlayerAbilities();
			}

			if (event.entityLiving.getActivePotionEffect(Dascraft.protectionPotion).getDuration() == 0)
			{
				event.entityLiving.removePotionEffect(Dascraft.protectionPotion.id);
				if (event.entityLiving instanceof EntityPlayer)
				{
					System.out.println("DOES IT WORK? YES IT DOES.");
					EntityPlayer player = (EntityPlayer) event.entityLiving;
					player.capabilities.allowEdit = true;
					player.sendPlayerAbilities();
					return;
				}
			}
		}
	}
}
}

 

I can't figure out for the life of me what's wrong with this code so I figured you might be able to help.

Link to comment
Share on other sites

I got it now, thank you diesieben07 for the fast reply and help. I didn't really take the route diesieben07 suggested going about it but the code below worked as well and because of that, issues may arise, only time will tell though.

 

Code for anyone interested:

package net.dascraft.init;

import net.dascraft.Dascraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.potion.PotionEffect;
import net.minecraftforge.event.entity.living.LivingEvent.LivingUpdateEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class DascraftEventHooks
{
@SubscribeEvent
public void onEntityUpdate(LivingUpdateEvent event)
{
	if (event.entityLiving.isPotionActive(Dascraft.protectionPotion))
	{
		if (event.entityLiving.worldObj.rand.nextInt(20) == 0)
		{
			if (event.entityLiving instanceof EntityPlayer)
			{
				EntityPlayer player = (EntityPlayer) event.entityLiving;
				player.capabilities.allowEdit = false;
				player.sendPlayerAbilities();
			}
		}

		PotionEffect effect = event.entityLiving.getActivePotionEffect(Dascraft.protectionPotion);

		if (effect.onUpdate(event.entityLiving) && effect.getDuration() == 1)
		{
			System.out.println("DOES IT WORK? YES IT DOES.");
			EntityPlayer player = (EntityPlayer) event.entityLiving;
			player.capabilities.allowEdit = true;
			player.sendPlayerAbilities();
			return;
		}
	}
}
}

Link to comment
Share on other sites

You should seriously consider switching that out, as your event handler needs to be run every tick for every living entity and not only when the entity has your potion effect.

 

Oh right, I'll get on it right away. I will come back for status later on.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Also note after updating you need to regenerate the gradle dependencies 
    • Use debugger to check which code is running and what the return values are
    • im trying to figure out how to change my mod's forge version but i cant seem to find the forge version in the build.gradle . build.gradle: buildscript { repositories { // These repositories are only for Gradle plugins, put any other repositories in the repository block further below maven { url = 'https://maven.minecraftforge.net' } mavenCentral() } dependencies { classpath group: 'net.minecraftforge.gradle', name: 'ForgeGradle', version: '5.1.+', changing: true } } apply plugin: 'net.minecraftforge.gradle' group = 'net.mikeyypants' version = '1.0-SNAPSHOT' java { archivesBaseName = 'TestMod' toolchain.languageVersion = JavaLanguageVersion.of(17) } minecraft { // The mappings can be changed at any time and must be in the following format. // Channel: Version: // snapshot YYYYMMDD Snapshot are built nightly. // stable # Stables are built at the discretion of the MCP team. // official MCVersion Official field/method names from Mojang mapping files // // You must be aware of the Mojang license when using the 'official' mappings. // See more information here: https://github.com/MinecraftForge/MCPConfig/blob/master/Mojang.md // // Use non-default mappings at your own risk. They may not always work. // Simply re-run your setup task after changing the mappings to update your workspace. mappings channel: 'official', version: '1.18' // accessTransformer = file('src/main/resources/META-INF/accesstransformer.cfg') // Default run configurations. // These can be tweaked, removed, or duplicated as needed. runs { client { workingDirectory project.file('run') // Recommended logging data for a userdev environment // The markers can be added/removed as needed separated by commas. // "SCAN": For mods scan. // "REGISTRIES": For firing of registry events. // "REGISTRYDUMP": For getting the contents of all registries. property 'forge.logging.markers', 'REGISTRIES' // Recommended logging level for the console // You can set various levels here. // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels property 'forge.logging.console.level', 'debug' mods { testmod { source sourceSets.main } } } server { workingDirectory project.file('run') // Recommended logging data for a userdev environment // The markers can be added/removed as needed separated by commas. // "SCAN": For mods scan. // "REGISTRIES": For firing of registry events. // "REGISTRYDUMP": For getting the contents of all registries. property 'forge.logging.markers', 'REGISTRIES' // Recommended logging level for the console // You can set various levels here. // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels property 'forge.logging.console.level', 'debug' mods { testmod { source sourceSets.main } } } data { workingDirectory project.file('run') // Recommended logging data for a userdev environment // The markers can be added/removed as needed separated by commas. // "SCAN": For mods scan. // "REGISTRIES": For firing of registry events. // "REGISTRYDUMP": For getting the contents of all registries. property 'forge.logging.markers', 'REGISTRIES' // Recommended logging level for the console // You can set various levels here. // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels property 'forge.logging.console.level', 'debug' // Specify the modid for data generation, where to output the resulting resource, and where to look for existing resources. args '--mod', 'testmod', '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') mods { testmod { source sourceSets.main } } } } } // Include resources generated by data generators. sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { // Put repositories for dependencies here // ForgeGradle automatically adds the Forge maven and Maven Central for you // If you have mod jar dependencies in ./libs, you can declare them as a repository like so: // flatDir { // dir 'libs' // } } dependencies { // Specify the version of Minecraft to use. If this is any group other than 'net.minecraft' it is assumed // that the dep is a ForgeGradle 'patcher' dependency, and its patches will be applied. // The userdev artifact is a special name and will get all sorts of transformations applied to it. minecraft 'net.minecraftforge:forge:1.18-38.0.8' // Real mod deobf dependency examples - these get remapped to your current mappings // compileOnly fg.deobf("mezz.jei:jei-${mc_version}:${jei_version}:api") // Adds JEI API as a compile dependency // runtimeOnly fg.deobf("mezz.jei:jei-${mc_version}:${jei_version}") // Adds the full JEI mod as a runtime dependency // implementation fg.deobf("com.tterrag.registrate:Registrate:MC${mc_version}-${registrate_version}") // Adds registrate as a dependency // Examples using mod jars from ./libs // implementation fg.deobf("blank:coolmod-${mc_version}:${coolmod_version}") // For more info... // http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html // http://www.gradle.org/docs/current/userguide/dependency_management.html } // Example for how to get properties into the manifest for reading at runtime. jar { manifest { attributes([ "Specification-Title" : "testmod", //"Specification-Vendor": "testmod authors", "Specification-Version" : "1", // We are version 1 of ourselves "Implementation-Title" : project.name, "Implementation-Version" : project.jar.archiveVersion, //"Implementation-Vendor": "testmod authors", "Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ") ]) } } jar.finalizedBy('reobfJar')  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.