ItemSmeltedEvent stack size 0 when shift-clicking

[Zetal]

 

  Reveal hidden contents

@SubscribeEvent

public void onSmelted(PlayerEvent.ItemSmeltedEvent event)

{

ItemStack stack = event.smelting;

                System.out.println(stack);

        }

 

 

Regular clicking when there are 3 stacks gives a stack size of 3.

Shiftclicking when there are 3 stacks gives a stack size of 0. How can I get the true stacksize?

[SCAREX]

I don't understand what you mean, the ItemSmeltedEvent is fired when the Item has been smelt, where do you see a shift-click ?

[Zetal]

ItemSmeltedEvent is called when a player takes the finished item out of the Furnace. They can do this by either clicking the item and picking it up on their cursor (this functions, and the stack size is reported correctly) or they can hold down shift and left-click the itemstack, which does not correctly report the stack size.

 

I'm using Forge 1.8, Build 1433.

[SCAREX]

I tested what you said, and I confirm : this is a bug. Another thing I found is that when you shift click, the event is fired 4 times but a simple click fires it 2 times (client and server I suppose).

[Zetal]

If anyone in Olympus (forge gods, hear me!) is interested in this issue, I believe it can be fixed in SlotFurnaceOutput at line 99 by changing

        this.field_75228_b = 0;

        net.minecraftforge.fml.common.FMLCommonHandler.instance().firePlayerSmeltedEvent(thePlayer, stack);

 

to

 

       stack.stacksize = this.field_75228_b;
       net.minecraftforge.fml.common.FMLCommonHandler.instance().firePlayerSmeltedEvent(thePlayer, stack);

       this.field_75228_b = 0;

[TheDoctorSoda]

You could always submit a PR or open an issue (assuming nobody has yet)

[LexManos]

Except that completely screws up the logic in ContainerFurnace.transferStackInSlot.

You should look into it more.

[Zetal]

I've looked into it as much as anyone can be expected to and I don't see how that would affect anything. "stack" is a parameter passed in, so changing it wouldn't affect anything outside of the method. In this case, another solution would be adding an 'amount' variable to the "firePlayerSmeltedEvent" method but simply setting the stacksize to the "field_75228_b" is the easier solution.

 

Thanks for the response. I'd appreciate an explanation, as extensive searching hasn't led to your conclusion.

[LexManos]

Try out this code:

public static class Main {
  private static class Foo {
    public String bar = "bar";
  }
  public static void main(String... args) {
    Foo foo = new Foo();
    System.out.println("Foo: " + foo.bar);
    buzz(foo);
    System.out.println("Foo? " + foo.bar);
  }
  public static void buzz(Foo foo){
    foo.bar = "wat?";
  }
}

 

Note: your change doesnt take into account machines/that double call thing.

[Zetal]

Well! You learn something new every day. Thank you for helping me clear that up!

 

Onwards! I don't see any reason to not just add a new variable to the ItemSmeltedEvent "amount" that takes in the "field_75228_b" variable. Would be a bit more work, but accomplish the same thing I had intended. And I'm almost positive it wouldn't affect anything, since "field_75228_b" is set to 0 immediately afterwards anyways.

[Zetal]

Well, anyway, is there a better way of getting the amount of something that has been smelted?