Doing more damage based on NBT

[Asweez]

I'm trying to make my item do more damage than normal based on its NBT. This is what I've been trying but it makes all the entities in the world freeze.

 

 

@SubscribeEvent
public void hitEntity(LivingHurtEvent event){
	System.out.println("Hit entity " + event.entityLiving.getHealth());			
	if(event.source instanceof EntityDamageSource){

		EntityDamageSource source = (EntityDamageSource) event.source;
		if(source.getEntity() instanceof EntityLivingBase){
			EntityLivingBase attackerEntity = (EntityLivingBase) source.getEntity();

			if(attackerEntity.getHeldItem() != null && attackerEntity.getHeldItem().getItem() == ItemManager.rpgSword){
				ItemStack is = attackerEntity.getHeldItem();
				int damage = is.stackTagCompound.getInteger("totalDamage")/25;
				event.entityLiving.attackEntityFrom(DamageSource.causeMobDamage(attackerEntity), damage);
			}

		}

	}

}

 

 

What am I doing wrong and how do I make my item do more damage based on NBT?

[Ernio]

1. NBTs can be null (1st check if stack has nbt)

2. If you have your own sword - do NOT use events. Events are for vanilla (and maybe other mods) only.

 

If it doesn't crash:

Make prints after each line - at which it stops?

 

 

[HenryRichard]

While I don't know how to fix this, I'm pretty sure that that's not how you use hitEntity. I believe it's used more like this:

@Override
public boolean hitEntity(ItemStack item, EntityLivingBase target, EntityLivingBase player)
    {
        target.worldObj.addWeatherEffect(new EntityLightningBolt(target.worldObj, target.posX, target.posY, target.posZ));
        item.damageItem(1, player);
        return true;
    }

(this code is for a lightning sword, but I think you get the idea)

[Asweez]

You want to override getAttributeModifiers and then change the damage attribute, like shown in the ItemSword class. Just choose the version of getAttributeModifiers that takes an ItemStack.

 

Awesome that worked thanks!