Jump to content

Recommended Posts

Posted

Hey guys, I found this piece of code in the BlockTorch class:

    public int getMetaFromState(IBlockState state)
    {
        byte b0 = 0;
        int i;

        switch (BlockTorch.SwitchEnumFacing.FACING_LOOKUP[((EnumFacing)state.getValue(FACING)).ordinal()])
        {
            case 1:
                i = b0 | 1;
                break;
            case 2:
                i = b0 | 2;
                break;
            case 3:
                i = b0 | 3;
                break;
            case 4:
                i = b0 | 4;
                break;
            case 5:
            case 6:
            default:
                i = b0 | 5;
        }

        return i;
    }

Wouldn't this do the exact same thing as:

    public int getMetaFromState(IBlockState state)
    {
        return BlockTorch.SwitchEnumFacing.FACING_LOOKUP[((EnumFacing)state.getValue(FACING)).ordinal()]
    }

?

Then why is this so big?

Posted

Hi

 

Well actually I think it wouldn't do the same thing...

            case 5:

            case 6:

            default:

                i = b0 | 5;

 

But most of the time when you find code like this that looks a bit strange, it's been autogenerated by the decompiler and probably looks very different in the native code.

 

-TGG

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.