Jump to content

Recommended Posts

Posted

Hi

I want to make an Entity (a Minecart) with a Inventory, but the inventory is always empty on Client side. I wrote a Sync Packet for my Entity but the Minecart does not keep the data.

 

Minecart Code:

public class ComputerCart extends EntityMinecart implements ISyncEntity, IInventory{

private boolean firstUpdate = true;
private int tier = -1;
private ItemStack[] inv = new ItemStack[20];

public ComputerCart(World p_i1712_1_) {
	super(p_i1712_1_);
}

public ComputerCart(World w, double x, double y, double z, Iterable<Pair<Integer, ItemStack>> components, int tier) {
	super(w,x,y,z);
	this.tier=tier;

	Iterator<Pair<Integer, ItemStack>> list = components.iterator();
	while(list.hasNext()){
		Pair<Integer, ItemStack> pair = list.next();
		if(pair.getKey() < 20 && pair.getValue() != null){
			inv[pair.getKey()] = pair.getValue();
		}
	}

}


public void readEntityFromNBT(NBTTagCompound nbt){
	super.readEntityFromNBT(nbt);
	this.loadInventory((NBTTagList) nbt.getTag("inventory"));
}

public void writeEntityToNBT(NBTTagCompound nbt){
	super.writeEntityToNBT(nbt);
	nbt.setTag("inventory", this.storeInventory());
}

private NBTTagList storeInventory(){
	NBTTagList tag = new NBTTagList();
	for(int i=0; i < inv.length; i+=1){
		NBTTagCompound invslot = new NBTTagCompound();
		NBTTagCompound invstack = new NBTTagCompound();
		invslot.setInteger("slot", i);
		if(inv[i] != null) inv[i].writeToNBT(invstack);
		invslot.setTag("stack", invstack);
		tag.appendTag(invslot);
	}
	return tag;
}

private void loadInventory(NBTTagList list){
	for(int i=0; i < list.tagCount(); i+=1){
		NBTTagCompound invslot = list.getCompoundTagAt(i);
		NBTTagCompound invstack = invslot.getCompoundTag("stack");
		int slot = invslot.getInteger("slot");
		if(slot<20){
			inv[slot] = ItemStack.loadItemStackFromNBT(invstack);
		}
	}
}

public void onUpdate(){
	if(this.firstUpdate){
		this.firstUpdate=false;
		if(!this.worldObj.isRemote)
		{	
			ModNetwork.sendToNearPlayers(new EntitySyncData(this.worldObj.provider.dimensionId, this.getEntityId()), this.posX, this.posY, this.posZ, this.worldObj);
		}
		else if(this.worldObj.isRemote){
			ModNetwork.channel.sendToServer(new EntitySyncRequest(this.worldObj.provider.dimensionId, this.getEntityId()));
		}
	}
}

@Override
public void writeSyncData(NBTTagCompound nbt) {
	nbt.setTag("inventory", this.storeInventory());
}

@Override
public void readSyncData(NBTTagCompound nbt) {
	this.loadInventory((NBTTagList) nbt.getTag("inventory"));

	int itemcount = 0;
	for(int i=0;i<this.inv.length;i+=1){
		if(this.inv[i]!=null) itemcount+=1;
	}
	OCMinecart.logger.log(Level.INFO, "ItemCount: "+itemcount+"  Remote: "+this.worldObj.isRemote);
}



@Override
public int getMinecartType() {
	return -1;
}

public static EntityMinecart create(World w, double x, double y, double z, Iterable<Pair<Integer, ItemStack>> components, int tier) {
	return new ComputerCart(w, x, y, z, components, tier);
}

public boolean interactFirst(EntityPlayer p){
	int itemcount = 0;
	for(int i=0;i<this.inv.length;i+=1){
		if(this.inv[i]!=null) itemcount+=1;
	}
	OCMinecart.logger.log(Level.INFO, "ItemCount: "+itemcount+"  Remote: "+this.worldObj.isRemote);
	return true;
}


@Override
public int getSizeInventory() {
	return inv.length;
}

@Override
public ItemStack getStackInSlot(int slot) {
	if(slot < inv.length) return inv[slot];
	return null;
}

@Override
public ItemStack decrStackSize(int p_70298_1_, int p_70298_2_) {
	return null;
}

@Override
public ItemStack getStackInSlotOnClosing(int p_70304_1_) {
	return null;
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack) {
	if(slot<20) this.inv[slot] = stack;
}

@Override
public String getInventoryName() {
	return null;
}

@Override
public int getInventoryStackLimit() {
	return 64;
}

@Override
public void markDirty() {
	// TODO Auto-generated method stub

}

@Override
public boolean isUseableByPlayer(EntityPlayer p_70300_1_) {
	return true;
}

@Override
public void openInventory() {

}

@Override
public void closeInventory() {

}

@Override
public boolean isItemValidForSlot(int p_94041_1_, ItemStack p_94041_2_) {
	return true;
}

}

 

The data from the Sync Packet are correct.

Output from the readSyncData() function:

[Client thread/INFO] [OC-Minecarts]: ItemCount: 3  Remote: false

I don't know why the world is not remote, but the Thread is running on Client Side.

 

Output on RightClick:

[Client thread/INFO] [OC-Minecarts]: ItemCount: 0  Remote: true
[server thread/INFO] [OC-Minecarts]: ItemCount: 3  Remote: false

Posted

don't do that.

 

Lookup tutorials on creating a block with inventory and guihandler.  just substitute the inventory from the block with inventory from the entity.

Long time Bukkit & Forge Programmer

Happy to try and help

Posted

don't do that.

 

Lookup tutorials on creating a block with inventory and guihandler.  just substitute the inventory from the block with inventory from the entity.

No, that is not good. You can use the entities ID instead of the GuiID.

In you GuiHandler, do if(world.getEntityByID(ID) instanceof yourEntityClass.class){

open GUI in CLIENT and CONTAINER in SERVER here

}

Posted

That is another way to do it, but what I said is fine.  Depending on what you are doing, there are advantages.

Long time Bukkit & Forge Programmer

Happy to try and help

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So i have a forge modded aternos server that worked just fine for a month untill today it suddenly crashes most of the time giving errors and idk which mod is causing the error or its smth else here is the crash log link https://mclo.gs/gGkzGKT
    • Struggling to decipher a crash report I'm getting in a custom modpack I'm tinkering with. The crash happens on startup, but weirdly, only some of the time. It seems to be related to Steves Carts, but weirdly it only started happening recently, and I can't identify if another mod is conflicting, or why it is only happening some of the time:   java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.player.Player.m_20202_()" because "player" is null at vswe.stevescarts.events.OverlayEventHandler.onRenderTick(OverlayEventHandler.java:24) ~[stevescarts-1.20.1-1.1.14.jar%23527!/:1.20.1-1.1.14] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.event.ForgeEventFactory.onRenderTickEnd(ForgeEventFactory.java:919) ~[forge-1.20.1-47.1.106-universal.jar%23581!/:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix-forge.mixins.json:perf.potential_spawns_alloc.ForgeEventFactoryMixin,pl:mixin:A} at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1148) ~[client-1.20.1-20230612.114412-srg.jar%23576!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%23576!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:218) ~[minecraft-1.20.1-client.jar:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:flywheel.mixins.json:ClientMainMixin,pl:mixin:A,pl:runtimedistcleaner:A}     Including some extra info in case any of it is relevant^. Appreciate any ideas/advice!    
    • Try the JVM argument in this post, just sub xmx/xms numbers for what you want/need allocated.  https://www.reddit.com/r/feedthebeast/s/lzmKUNZFrG I'm having the same issue with a huge modpack using the 3 culprits to your issue.  Let me know if this helps!
    • i have been trying to  lauch a modpack and it crashes in the lauching phase   
    • nope, even the log is the exact same, i also tried with the Dimensional doors just in case and nothing.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.