Moving a VehicleEntity and how to propperly set it up[Question for diesieben07]

Posted August 21, 201510 yr

Hey diesieben07, in another topic you said my code in the entity was totally broken - no i recognized it too. I removed the if(worldObj.isRemote) check on spawning and now it is totally buggy and glitchy. You know very much, you find mistakes even if you never saw the game running Well, anyway - you said this to me in that topic:

You will need packets of some sort to tell the server what's happening.

The naive way would be to just tell the server "ok, user started pressing <forward> now" and then later "ok, user stopped pressing <forward>".

But this sucks, because of latency. What Minecraft does is it just simulates the movement on the client and tells the server "hey, I moved to <x, y, z>". Of course the server then needs security checks to make sure the client doesn't cheat.

For horses Mojang actually took the naive/easier/whatever route and send key-states to the server, which makes them kinda choppy.

You choose what to do.

So, you said a kind off packets. does that mean i can do the whole thing in the onUpdate method?

Like

if(worldObj.isRemote){

clientPosX+=motionX;

clientPosY+=motionY;

clientPosZ+=motionZ;

}

if(!worldObj.isRemote){

posX=clientPosX;

posY=clientPosY;

posZ=clientPosZ;

}

Quote

August 21, 201510 yr

Author

Okay, so what are the securitychecks?

Quote

August 21, 201510 yr

Author

So basicly update the physics (let the vehicle fall down if not on ground etc)?

Quote

August 21, 201510 yr

Author

Oh, i recognized there already are some fields and methods for that in the entityclass:

@Override

@SideOnly(Side.CLIENT)

public void setVelocity(double p_70016_1_, double p_70016_3_, double p_70016_5_) {

this.velocityX = (float) (this.motionX = p_70016_1_);

this.velocityY = (float) (this.motionY = p_70016_3_);

this.velocityZ = (float) (this.motionZ = p_70016_5_);

}

also there is that in the onUpdate() method

this.prevPosX = this.posX;

this.prevPosY = this.posY;

this.prevPosZ = this.posZ;

can i just use this?

Quote

August 21, 201510 yr

Author

Oh, not to good

Quote

August 21, 201510 yr

Author

Oh, i recognized there already are some fields and methods for that in the entityclass:

Hidden

also there is that in the onUpdate() method

this.prevPosX = this.posX;

this.prevPosY = this.posY;

this.prevPosZ = this.posZ;

can i just use this?

Quote

August 21, 201510 yr

Author

So i have to creat a global variable vehiclesXPos etc and then add the motionX to it on client and send it to the server like this

if(!worldObj.isRemote){

this.setPosition(vehicleXPos, vehicleYPos, vehicleZPos);

}

Quote

August 21, 201510 yr

Author

lol what then?

Quote

August 21, 201510 yr

Author

Yay Okay, so in the packet i need a double for the positions, but there only is a possibility to save an integer/ItemStack etc to the buffer, no double. Do i have to parse the double to a String, save it as UTF8 String and then reparse it as double?

Quote

August 21, 201510 yr

Author

I didn't see a method for it, only BufferUtils.writeVarInt, maybe i didn't looked correctly. Well also i tried fixing the fact that now, when i press enter (which should mount the player to the entity) let's the player fall out of the world using packets.

But somehow the getEntityID does not work look:

IMessage:

package itsamysterious.mods.reallifemod.core.packets;

import io.netty.buffer.ByteBuf;

import itsamysterious.mods.reallifemod.core.vehicles.EntityVehicle;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraftforge.fml.common.network.ByteBufUtils;

import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

import net.minecraftforge.fml.common.registry.EntityRegistry;

public class MountVehicleMessage implements IMessage {

public int playerID;

public int vehicleId;

public MountVehicleMessage() {

}

public MountVehicleMessage(EntityVehicle v, EntityPlayer p){

this.playerID=p.getEntityId();

this.vehicleId=p.getEntityId();

}

@Override

public void fromBytes(ByteBuf buf) {

playerID = ByteBufUtils.readVarInt(buf,EntityRegistry.findGlobalUniqueEntityId());

vehicleId = ByteBufUtils.readVarInt(buf,EntityRegistry.findGlobalUniqueEntityId());

}

@Override

public void toBytes(ByteBuf buf) {

ByteBufUtils.writeVarInt(buf, vehicleId, vehicleId);

ByteBufUtils.writeVarInt(buf, playerID, playerID);

}

MessageHandler:

package itsamysterious.mods.reallifemod.core.packets;

import itsamysterious.mods.reallifemod.core.vehicles.EntityVehicle;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.world.World;

import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;

import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MountHandler implements IMessageHandler<MountVehicleMessage, MountVehicleMessage>{

@Override

public MountVehicleMessage onMessage(MountVehicleMessage message, MessageContext ctx) {

World world=ctx.getServerHandler().playerEntity.worldObj;

EntityPlayer p=(EntityPlayer)world.getEntityByID(message.playerID);

EntityVehicle v=(EntityVehicle)world.getEntityByID(message.vehicleId);

v.interactFirst(p);

return null;

}

I registered the message to the SERVER side, cuz i wan't that the server mounts the player or do i have to do sendToAll when i press RETURN in the entitys onUpdate() method?

Quote

August 21, 201510 yr

Author

Oh, thanks And i don't know what to use as maxValue, so i tried getting a bigger entityID than all the ids that exist doing getGlobalUniqueEntityID

Quote

August 21, 201510 yr

Author

Okay it crashes - with this error

Here is my Message:

package itsamysterious.mods.reallifemod.core.packets;

import io.netty.buffer.ByteBuf;

import itsamysterious.mods.reallifemod.core.vehicles.EntityVehicle;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraftforge.fml.common.network.ByteBufUtils;

import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

import net.minecraftforge.fml.common.registry.EntityRegistry;

public class MountVehicleMessage implements IMessage {

public int playerID;

public int vehicleId;

public MountVehicleMessage() {

}

public MountVehicleMessage(EntityVehicle v){

this.vehicleId=v.getEntityId();

}

@Override

public void fromBytes(ByteBuf buf) {

vehicleId = buf.readInt();

}

@Override

public void toBytes(ByteBuf buf) {

buf.writeInt(vehicleId);

}

Handler:

package itsamysterious.mods.reallifemod.core.packets;

import itsamysterious.mods.reallifemod.core.vehicles.EntityVehicle;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.world.World;

import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;

import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MountHandler implements IMessageHandler<MountVehicleMessage, MountVehicleMessage>{

@Override

public MountVehicleMessage onMessage(MountVehicleMessage message, MessageContext ctx) {

World world=ctx.getServerHandler().playerEntity.worldObj;

EntityVehicle v=(EntityVehicle)world.getEntityByID(message.vehicleId);

EntityPlayer p = world.getClosestPlayer(v.posX, v.posY, v.posZ, 5.0F);

v.interactFirst(p);

return null;

}

And where i call it:

if (Keyboard.isKeyDown(Keyboard.KEY_RETURN)) {

RealLifeMod.network.sendToServer(new MountVehicleMessage(this));

}

Quote

August 21, 201510 yr

Author

You just say it is wrong, but don't give a hint what is wrong or how i can fix it

Quote

August 21, 201510 yr

Author

Can you help me?

Quote

August 21, 201510 yr

ctx has the player, I think it is ctx.getPlayer()

also you don't need ctx to get the world, you can use something like this:

MinecraftServer.server.world (its a global static)

also take a look at this:

http://www.minecraftforge.net/forum/index.php/topic,20135.0.html

and this:

http://www.minecraftforge.net/forum/index.php/topic,33112.msg173479.html#msg173479

should help you understand the buffer stuff.

Current Project: Armerger

Planned mods: Light Drafter | Ore Swords

Looking for help getting a mod off the ground? Coding | Textures

Quote

August 21, 201510 yr

Author

I check if the entity is ridden by a player before i check if a key is pressed but oh... it will ,move if multiple cars are mounted! So, what to do to fix that?

Heres the error spoiler

[18:18:47] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:32]: Trying to render sign with type 'hexagon'!

[18:18:48] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:32]: Trying to render sign with type 'hexagon'!

[18:18:49] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:32]: Trying to render sign with type 'hexagon'!

[18:18:49] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:31]: Trying to render sign with type 'hexagon'!

[18:18:50] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:31]: Trying to render sign with type 'hexagon'!

[18:18:51] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:31]: Trying to render sign with type 'hexagon'!

[18:18:52] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:31]: Trying to render sign with type 'hexagon'!

[18:18:52] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:32]: Trying to render sign with type 'hexagon'!

[18:18:53] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.rendering.tileEntitys.RenderSign:renderTileEntityAt:32]: Trying to render sign with type 'hexagon'!

[18:18:55] [server thread/INFO]: Saving and pausing game...

[18:18:55] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:18:55] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:18:55] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:18:55] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:19:11] [server thread/INFO]: Saving and pausing game...

[18:19:11] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:19:11] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:19:11] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:19:11] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:19:29] [server thread/INFO]: Saving and pausing game...

[18:19:29] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:19:29] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:19:29] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:19:29] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:19:39] [server thread/INFO]: Saving and pausing game...

[18:19:39] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:19:39] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:19:39] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:19:39] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:19:42] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:19:43] [server thread/INFO]: Saving and pausing game...

[18:19:43] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:19:43] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:19:43] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:19:43] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:19:52] [server thread/INFO]: Saving and pausing game...

[18:19:52] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:19:52] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:19:53] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:19:53] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:20:07] [server thread/INFO]: Saving and pausing game...

[18:20:07] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:20:07] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:20:07] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:20:07] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:20:27] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.client.ClientProxy$1newItem:onItemRightClick:160]: Placing lamborghini

[18:20:27] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.client.ClientProxy$1newItem:onItemRightClick:160]: Placing lamborghini

[18:20:29] [Client thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.client.ClientProxy$1newItem:onItemRightClick:160]: Placing lamborghini

[18:20:29] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.client.ClientProxy$1newItem:onItemRightClick:160]: Placing lamborghini

[18:20:32] [server thread/INFO]: Saving and pausing game...

[18:20:32] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:20:32] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:20:32] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:20:32] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:21:11] [server thread/INFO]: Saving and pausing game...

[18:21:11] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:21:11] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:21:11] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:21:11] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:23:01] [server thread/INFO]: Saving and pausing game...

[18:23:01] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:23:01] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:23:01] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:23:01] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:25:05] [server thread/INFO]: Saving and pausing game...

[18:25:05] [server thread/INFO] [sTDOUT]: [itsamysterious.mods.reallifemod.core.lifesystem.RLMPlayerProps:saveNBTData:112]: Saved the data of ItsAMysterious to

[18:25:05] [server thread/INFO]: Saving chunks for level 'AutoTest'/Overworld

[18:25:05] [server thread/INFO]: Saving chunks for level 'AutoTest'/Nether

[18:25:05] [server thread/INFO]: Saving chunks for level 'AutoTest'/The End

[18:25:09] [Netty Server IO #1/ERROR] [FML]: SimpleChannelHandlerWrapper exception

java.lang.NullPointerException

at itsamysterious.mods.reallifemod.core.packets.MountHandler.onMessage(MountHandler.java:15) ~[MountHandler.class:?]

at itsamysterious.mods.reallifemod.core.packets.MountHandler.onMessage(MountHandler.java:1) ~[MountHandler.class:?]

at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:37) ~[simpleChannelHandlerWrapper.class:?]

at net.minecraftforge.fml.common.network.simpleimpl.SimpleChannelHandlerWrapper.channelRead0(SimpleChannelHandlerWrapper.java:17) ~[simpleChannelHandlerWrapper.class:?]

at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:103) ~[simpleChannelInboundHandler.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:338) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:324) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) [MessageToMessageDecoder.class:4.0.15.Final]

at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111) [MessageToMessageCodec.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:338) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:324) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:4.0.15.Final]

at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169) [EmbeddedChannel.class:4.0.15.Final]

at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.processPacket(FMLProxyPacket.java:88) [FMLProxyPacket.class:?]

at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:144) [NetworkManager.class:?]

at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:469) [NetworkManager.class:?]

at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:103) [simpleChannelInboundHandler.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:338) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:324) [DefaultChannelHandlerContext.class:4.0.15.Final]

at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.handleServerSideCustomPacket(NetworkDispatcher.java:412) [NetworkDispatcher.class:?]

at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:240) [NetworkDispatcher.class:?]

at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:50) [NetworkDispatcher.class:?]

at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:103) [simpleChannelInboundHandler.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:338) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:324) [DefaultChannelHandlerContext.class:4.0.15.Final]

at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [DefaultChannelPipeline.class:4.0.15.Final]

at io.netty.channel.local.LocalChannel.finishPeerRead(LocalChannel.java:312) [LocalChannel.class:4.0.15.Final]

at io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:44) [LocalChannel.class:4.0.15.Final]

at io.netty.channel.local.LocalChannel$6.run(LocalChannel.java:298) [LocalChannel$6.class:4.0.15.Final]

at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:354) [singleThreadEventExecutor.class:4.0.15.Final]

at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:353) [NioEventLoop.class:4.0.15.Final]

at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) [singleThreadEventExecutor$2.class:4.0.15.Final]

at java.lang.Thread.run(Unknown Source) [?:1.8.0_51]