Multimountable entity and other problems?

[ItsAMysteriousYT]

I have a car entity and i want to make it possible that more than one person mounts it. To do that i thought of creating a field of Type entitySeat and add new EntitySeats to it in the constructor of the Entity. But once i tried it it didn't even spawn the seats. I registered all the entities in the correct place and order with different id's, but it wouldn't work. Also i think ill need somebody to help me with the packetHandling for the driving mechanizm. Im thinking of a packet that takes in the id of the pressed key and sends it to the Server. On the server the entity in which the player of that message is sitting, should do the movement stuff, but i can't figure out how to excactly do it. So - here is the EntityClass and the ItemClass that spawns it:

EntityClass:

 

  Reveal hidden contents

 

package itsamysterious.mods.reallifemod.core.vehicles;

 

import org.lwjgl.input.Keyboard;

import org.lwjgl.util.vector.Vector3f;

 

import itsamysterious.mods.reallifemod.RealLifeMod;

import itsamysterious.mods.reallifemod.core.packets.MountVehicleMessage;

import itsamysterious.mods.reallifemod.core.sounds.SoundPlayer;

import net.minecraft.block.Block;

import net.minecraft.entity.Entity;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.util.AxisAlignedBB;

import net.minecraft.util.BlockPos;

import net.minecraft.world.World;

import net.minecraftforge.fml.relauncher.Side;

import net.minecraftforge.fml.relauncher.SideOnly;

 

public class EntityVehicle extends Entity {

private static final double g = 9.81;

private VehicleFile file;

public double backWheelRotation;

public double wheelRotL;

public double steeringangle;

private boolean isEmpty;

private boolean canDoStuff;

 

private EntitySeat[] seats;

private double vehicleX;

private double vehicleY;

private double vehicleZ;

private float vehicleYaw;

private float vehiclePitch;

private double velocityY;

private double velocityX;

private double velocityZ;

public double speed;

public double fuellevel;

private SoundPlayer player;

//Constants

private final double rollresistancecoeff_tarmac=0.013;

private final double rollresistancecoeff_betong=0.008;

private final double rollresistancecoeff_gravel=0.008;

private final double rollresistancecoeff_cobble=0.015;

private final double rollresistancecoeff_dirt=0.050;

private final double rollresistancecoeff_sand=0.3;

 

 

private float P;//Power Lever

private float Xb; // Brake pedal deflection

private float Xn; // Brake pedal deflection

 

private double F;//Propulsive fort

private double V;//Propulsive fort

 

 

public EntityVehicle(World world) {

super(world);

this.setSize(1, 2);

this.canDoStuff = false;

this.isEmpty = true;

this.preventEntitySpawning = true;

this.player=new SoundPlayer();

}

 

public EntityVehicle(World world, VehicleFile file, double x, double y, double z) {

this(world);

this.setFile(file);

this.seats = new EntitySeat[file.numDrivers];

this.createSeats(world);

this.setPosition(x, y, z);

this.canDoStuff = true;

}

 

private void createSeats(World w) {

for (int i = 0; i < this.seats.length; i++) {

System.out.println(seats.length);

this.seats = new EntitySeat(w);

w.spawnEntityInWorld(seats);

}

this.canDoStuff = true;

}

 

@Override

@SideOnly(Side.CLIENT)

public void setVelocity(double p_70016_1_, double p_70016_3_, double p_70016_5_) {

this.velocityX = (float) (this.motionX = p_70016_1_);

this.velocityY = (float) (this.motionY = p_70016_3_);

this.velocityZ = (float) (this.motionZ = p_70016_5_);

}

 

@Override

public void entityInit() {

this.dataWatcher.addObject(17, new Integer(0));

this.dataWatcher.addObject(18, new Integer(1));

this.dataWatcher.addObject(19, new Float(0.0F));

}

 

@Override

public void onUpdate() {

super.onUpdate();

this.prevPosX = this.posX;

this.prevPosY = this.posY;

this.prevPosZ = this.posZ;

 

if (this.canDoStuff) {

for (int i = 0; i < seats.length; i++) {

Vector3f f = this.file.ridersPositions.get(i);

this.seats.setPosition(this.posX + f.x, this.posY + f.y + 0.5, this.posZ + f.z);

}

}

 

// ------------------------------------------------------------------------------------------

 

if (Keyboard.isKeyDown(Keyboard.KEY_RETURN)) {

if(worldObj.isRemote)

RealLifeMod.network.sendToServer(new MountVehicleMessage(this));

}

 

//file.startsound.update();

//file.stopsound.update();

//file.throttlesound.update();

 

// ------------------------------------------------------------------------------------------

wheelRotL+=speed;

backWheelRotation+=speed;

this.move();

 

}

 

public void move() {

if(this.riddenByEntity!=null){

if (Keyboard.isKeyDown(Keyboard.KEY_A)) {

if(steeringangle < 30){

steeringangle += 3.5;

}

} else if (Keyboard.isKeyDown(Keyboard.KEY_D) ) {

if(steeringangle > -30){

steeringangle -= 3.5;

}

} else {

if (steeringangle > 0) {

steeringangle -= 2.5;

if (steeringangle > 0) {

steeringangle -= 2.5;

}

}

if (steeringangle < 0) {

steeringangle += 2.5;

if (steeringangle < 0) {

steeringangle += 2.5;

}

}

}

boolean pressedW;

if(Keyboard.isKeyDown(Keyboard.KEY_W)){

// Minecraft.getMinecraft().getSoundHandler().playSound(this.file.startsound);

riddenByEntity.playSound("reallifemod:lambo_throttles", 1.0f, 1.0f);

if(speed<file.maxSpeed){

speed+=file.acceleration*20;

 

}

if(P<30){

P+=2.5;

}

pressedW=true;

}else

{

 

if(P>5){

P-=0.5;

}else

P=0;

 

}

 

if(ticksExisted%3==0){

riddenByEntity.playSound("reallifemod:lambo_runs", 1.0f, 1.0f+(float)P*0.1f);

}

 

if(Keyboard.isKeyDown(Keyboard.KEY_S)){

if(speed>-file.maxReverseSpeed){

speed-=file.acceleration*1000/60/60*20;

}

}

 

if(Keyboard.isKeyDown(Keyboard.KEY_SPACE)){

if(speed<-5){

speed+=5;

}else

if(speed<0){

speed=0;

}

 

if(speed>5){

speed-=5;

}else{

speed=0;

}

}

 

double k=0;

double R=0;

if(steeringangle!=0){

R=file.dimensions.z/steeringangle;

k=1/R;

}

//double m = file.mass;

/*V=speed*1000/m;

double u= motionX;

double v= motionZ;//

V=Math.pow(((u*u)+(v*v)),0.5) ;

double ax=u-r*v;

double ay=v+r*u;

double Pw;

Vector2d F;

double Fa;

double W = m*g;

*/

 

double r=((speed*1000)/60/60/20)*k;

this.rotationYaw-=r;

this.motionX=-(speed*1000/60/60/20)*Math.sin(Math.toRadians(rotationYaw));

this.motionZ=(speed*1000/60/60/20)*Math.cos(Math.toRadians(rotationYaw));

if(worldObj.isRemote){

    this.vehicleX+=motionX;

    this.vehicleY+=motionY;

    this.vehicleZ+=motionZ;

    }else

    if(!worldObj.isRemote&&!this.isAirBorne){

    this.setPosition(vehicleX, vehicleY, vehicleZ);

    }

speed*=0.988888881;

}

}

@Override

public void readEntityFromNBT(NBTTagCompound tagCompund) {

 

}

 

@Override

public void writeEntityToNBT(NBTTagCompound tagCompound) {

 

}

 

@Override

public boolean interactFirst(EntityPlayer player) {

if (this.riddenByEntity == null&&!player.isDead) {

player.mountEntity(this);

return true;

}

else

return false;

}

 

@Override

public void updateRiderPosition() {

if (riddenByEntity != null) {

Vector3f pos=file.ridersPositions.get(0);

 

double k=0;

double R=0;

if(steeringangle!=0){

R=file.dimensions.z/steeringangle;

k=1/R;

}

double r=((speed*1000)/60/60/80)*k;

riddenByEntity.rotationYaw-=r;

}

riddenByEntity.setAir(0);

riddenByEntity.setPosition(posX, posY-0.6, posZ);

};

 

 

public VehicleFile getFile() {

return this.file;

}

 

public void setFile(VehicleFile file) {

this.file = file;

}

 

public void setDamageTaken(float p_70266_1_) {

this.dataWatcher.updateObject(19, Float.valueOf(p_70266_1_));

}

 

public float getDamageTaken() {

return this.dataWatcher.getWatchableObjectFloat(19);

}

 

public void setTimeSinceHit(int p_70265_1_) {

this.dataWatcher.updateObject(17, Integer.valueOf(p_70265_1_));

}

 

public int getTimeSinceHit() {

return this.dataWatcher.getWatchableObjectInt(17);

}

 

public void setForwardDirection(int p_70269_1_) {

this.dataWatcher.updateObject(18, Integer.valueOf(p_70269_1_));

}

 

public int getForwardDirection() {

return this.dataWatcher.getWatchableObjectInt(18);

}

 

@Override

protected boolean canTriggerWalking() {

return false;

}

 

@Override

public AxisAlignedBB getCollisionBox(Entity entityIn) {

return entityIn.getEntityBoundingBox();

}

 

@Override

public AxisAlignedBB getBoundingBox() {

return this.getEntityBoundingBox();

}

 

public boolean canRiderInteract() {

return true;

}

 

public boolean shouldDismountInWater(Entity rider) {

return true;

}

 

}

 

 

 

 

ItemClass(Its generated in code, thats why it is not public):

 

  Reveal hidden contents

 

class newItem extends Item {

public newItem() {

setUnlocalizedName(f.vehicleName);

setCreativeTab(RealLifeMod.Cars);

GameRegistry.registerItem(this, getUnlocalizedName().substring(5));

}

 

@Override

public ItemStack onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn) {

System.out.println("Placing " + f.vehicleName);

EntityVehicle vehicle = new EntityVehicle(worldIn, f,

Minecraft.getMinecraft().objectMouseOver.getBlockPos().getX(),

Minecraft.getMinecraft().objectMouseOver.getBlockPos().getY(),

Minecraft.getMinecraft().objectMouseOver.getBlockPos().getZ());

if (worldIn.getBlockState(Minecraft.getMinecraft().objectMouseOver.getBlockPos())

.getBlock() == Blocks.air) {

worldIn.spawnEntityInWorld(vehicle);

}

return itemStackIn;

}

}

 

 

 

[ItsAMysteriousYT]

Please help, im struggling on this really long

[Elix_x]

Let's begin with problems:

 

  On 8/23/2015 at 4:21 PM, ItsAMysteriousOfficial said:

 
  if (Keyboard.isKeyDown(Keyboard.KEY_A)) {
  if (Keyboard.isKeyDown(Keyboard.KEY_D) ) {
  if(Keyboard.isKeyDown(Keyboard.KEY_W)){
  if(Keyboard.isKeyDown(Keyboard.KEY_S)){
  if(Keyboard.isKeyDown(Keyboard.KEY_SPACE)){

Wow... Apearenly you really don't know that there's no keyboard on server...

 

  Quote

  
      if (Keyboard.isKeyDown(Keyboard.KEY_RETURN)) {
         if(worldObj.isRemote)
         RealLifeMod.network.sendToServer(new MountVehicleMessage(this));
      }

Really? First you check for key press and then you check for client...

 

  Quote

 
                  Minecraft.getMinecraft().objectMouseOver.getBlockPos().getX(),
                  Minecraft.getMinecraft().objectMouseOver.getBlockPos().getY(),
                  Minecraft.getMinecraft().objectMouseOver.getBlockPos().getZ())

Seriously? You have onItemUse, and you use this???

 

In total, you need to

-Know what is server stuff and what is client stuff... Go and learn it RIGHT NOW!

-Know how to use packets... No, seriously, until you learn packets good enough do not try to do client server sync needed stuff... Plenty o tutorials...

-Know what key handler is and how to use it... Again, Plenty o tutorials...

 

 

[ItsAMysteriousYT]

Yea, omg why did i check the key first am i stupid? And can't i just check if its client and then simulate the movement on client(eg with other variables) and send it to the server with a packet?

[Elix_x]

  On 8/24/2015 at 8:31 AM, ItsAMysteriousOfficial said:

Yea, omg why did i check the key first am i stupid? And can't i just check if its client and then simulate the movement on client(eg with other variables) and send it to the server with a packet?

Bad idea - opens big doors to cheaters... You should send packets to server describing which action user wants to perform (send packet each time key state changes and not each tick while it's pressed)... Also, i highly recomend making keys configurable using key handler (so don't send key W pressed, but check if move froward key has changed and then send packet to server saying that move forward state changed)...

[ItsAMysteriousYT]

Okay, so is it smart to create a packet taking in the keys id and the entity and then in the packethandler it updates the position?

[Elix_x]

  On 8/24/2015 at 12:46 PM, ItsAMysteriousOfficial said:

Okay, so is it smart to create a packet taking in the keys id and the entity and then in the packethandler it updates the position?

Better would be to send where player wants to go and check for key presses per client. Like that, if players use arrow keys instead of WASD to move, they will be able to configure it personally.

Also, no need to send player or vehicle: from context of message (that you get in your handler along with message), you can get player that sent that message. And from player you can get entity it's riding or entity it's ridden by...

Then best option would be to create directional fields in tile entity and change those from packet. Then depending on those fields, in update method, you move your entity...

Oh and last thing: on client before sending a packet, check that player rides your entity, to save performance ...

[ItsAMysteriousYT]

Okay wait - what? Why do i use tileentity to store data? Hasn't an entity got fields for that?

 

[Elix_x]

  On 8/24/2015 at 3:21 PM, ItsAMysteriousOfficial said:

Okay wait - what? Why do i use tileentity to store data? Hasn't an entity got fields for that?

Typo... In entity ...

[ItsAMysteriousYT]

So with  a variable in the entity and then send a packet with the new positon and update it on server?