[1.7.10] Why can't access variable changes from inside !this.worldObj.isRemote

[IvanTune]

Hello!

 

I was just wondering why I can't access the changes done to the variable cookTime when it is inside a !this.worldObj.isRemote if statement.

If I remove the !this.worldObj.isRemote I am able to get changes done to it and all is fine.

 

What happens is that with that if statement in there, I dont get access to the code saying "this.cookTime++;", the cookTime variable only works when I am right clicking inside the gui (this is only for when I try to access it with sysout to console), when I leave the gui the variable freezes.

 

Do I need the !this.worldObj.isRemote in the code below, or is it ok if I remove it? Or does code like that have to be done ONLY on server?

 

 

I'm new to java and still learning, sorry if it is obvious, thanks.

 

TileEntityCustomFurnace

public void updateEntity() {
	boolean flag = this.burnTime > 0;
	boolean flag1 = false;

	if (this.burnTime > 0) {
		this.burnTime--;
	}

	if (!this.worldObj.isRemote) {
		if (this.burnTime == 0 && this.canSmelt()) {
			this.currentItemBurnTime = this.burnTime = getItemBurnTime(this.slots[1]);

			if (this.burnTime > 0) {
				flag1 = true;

				if (this.slots[1] != null) {
					this.slots[1].stackSize--;

					if (this.slots[1].stackSize == 0) {
						this.slots[1] = this.slots[1].getItem().getContainerItem(this.slots[1]);

					}

				}
			}

		}

		if (this.isBurning() && this.canSmelt()) {
			this.cookTime++;

			if (this.cookTime == this.furnaceSpeed) {
				this.cookTime = 0;
				this.smeltItem();
				flag1 = true;
			}
		} else {
			this.cookTime = 0;
		}

		if (flag != this.burnTime > 0) {
			flag1 = true;
			BlockCustomFurnace.updateCustomFurnaceBlock(this.burnTime > 0, this.worldObj, this.xCoord, this.yCoord,
					this.zCoord);

		}
	}

	if (flag1) {
		this.markDirty();
	}

}

[Failender]

only do changes on important stuff on server side (!worldObj.isRemote) . if u need those values on client side sync them. (packets or Containers got an additional way of syncing when they are opened)

[IvanTune]

Thanks for reply!

I googled syncing client and server and got receiveClientEvent and addBlockEvent.

Am I doing anything right or am I way off? I got kinda stuck now, all I need is the cookTime variable, hmm.

 

TileEntityCustomFurnace

         public int eventData;
 private int ticksSinceSync;
 private int field_145974_k;

    @Override
    public boolean receiveClientEvent(int eventID, int eventData)
    {
        if (eventID == 1)
        {
            this.eventData = eventData;
            return true;
        }
       else
        {
            return super.receiveClientEvent(eventID, eventData);
        }
    }

public void updateEntity() {
	boolean flag = this.hasPower();
	boolean flag1 = false;

	if (++this.field_145974_k % 20 * 4 == 0){
		worldObj.addBlockEvent(xCoord, yCoord, zCoord, ModBlocks.blockCustomFurnaceIdle, 1, this.cookTime);
	 }
	if(this.hasPower() && this.isMacerating()){
		this.power--;


	}

	if (!this.worldObj.isRemote) {
		if (this.hasItemPower(this.slots[1]) && this.power <= (this.maxPower - this.getItemPower(this.slots[1]))) {
			this.power += getItemPower(this.slots[1]);

			if(this.slots[1] != null){

				flag1 = true;

				this.slots[1].stackSize--;

				if(this.slots[1].stackSize == 0){
					this.slots[1] = this.slots[1].getItem().getContainerItem(this.slots[1]);

				}
			}

		}

		if (this.hasPower() && this.canMacerate()) {
			this.cookTime++;

			//System.out.println(this.isActive);

			if (this.cookTime== this.maceratingSpeed) {
				this.cookTime = 0;

				this.macerateItem();
				flag1 = true;
			}
		} else {
			this.cookTime = 0;

		}


         	if (flag != this.cookTime > 0)
        	{
            	flag1 = true;
            		BlockCustomMacerator.updateCustomMaceratorBlock(this.cookTime > 0, this.worldObj, this.xCoord, this.yCoord, this.zCoord);
        		}


	}

	if (flag1) {
		this.markDirty();
	}

}

[Failender]

http://i.imgur.com/IppKJ.jpg%3Ffb[/img]

[Failender]

Look how vanilla synchronizes the furnace.. ContainerFurnace

[Draco18s]

Vanilla has unique packets for every tile entity and is not appropriate for mod added tile entities.

[IvanTune]

Shouldn't cookTime be updated on client when I have container like this?

 

public void addCraftingToCrafters(ICrafting icrafting){
	super.addCraftingToCrafters(icrafting);
	icrafting.sendProgressBarUpdate(this, 0, this.customMacerator.cookTime);
	icrafting.sendProgressBarUpdate(this, 1, this.customMacerator.power);
}

public void detectAndSendChanges(){
	super.detectAndSendChanges();

	for(int i = 0; i < this.crafters.size(); i++){
		ICrafting icrafting = (ICrafting) this.crafters.get(i);

		if(this.lastCookTime != this.customMacerator.cookTime){
			icrafting.sendProgressBarUpdate(this, 0, this.customMacerator.cookTime);
		}

		if(this.lastBurnTime != this.customMacerator.power){
			icrafting.sendProgressBarUpdate(this, 1, this.customMacerator.power);
		}

	}

	this.lastCookTime = this.customMacerator.cookTime;
	this.lastBurnTime = this.customMacerator.power;

}

@SideOnly(Side.CLIENT)
public void updateProgressBar(int slot, int newValue){
	if(slot == 0) this.customMacerator.cookTime = newValue;
	if(slot == 1) this.customMacerator.power = newValue;

}

 

[Failender]

that looks fine

[IvanTune]

If cookTime only updates when I am inside the gui is problem still with the container?

 

TileEntity

public boolean isActive() {
	System.out.println(this.cookTime);
	return this.cookTime > 0;
}

 

BlockClass

  @Override
  @SideOnly(Side.CLIENT)
public void randomDisplayTick(World world, int x, int y, int z, Random random) {

	TileEntityCustomMacerator te = (TileEntityCustomMacerator) world.getTileEntity(x, y, z);

	if (te.isActive()) { stuff }

 

[Failender]

I dont know what ur question is tbh.

[larsgerrits]

Yes, the Container packets are only send when the gui is open. And as diesieben07 said, if you need the data outside of the gui, you need custom packets instead of the Container packets.