[Solved] [1.8] onBlockPlacedBy and onBlockPlaced Not Working

[LordMastodon]

I've created a block, and it's supposed to set its block bounds when it's placed. I put in the code for it to set them, but when I placed the block, nothing happened. I put in debug code for it to print when those methods are called, but the debug code isn't called either. Here's my block class:

 

 

  Reveal hidden contents

package lordmastodon.miscal.block;


import java.util.Random;


import lordmastodon.miscal.Miscal;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.state.BlockState;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockPos;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumWorldBlockLayer;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;


public class LightationBlock extends Block {
   
   public static final PropertyDirection FACING = PropertyDirection.create("facing");
    public static final PropertyBool LIT_UP = PropertyBool.create("lit");


    private float pixel = 1F/16F;
    
   public LightationBlock() {
      super(Material.iron);
      
      this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH).withProperty(LIT_UP, Boolean.valueOf(false)));
   }
   
   @Override
   public Item getItemDropped(IBlockState state, Random rand, int fortune) {
      return Item.getItemFromBlock(MiscalBlocks.lightation);
   }
   
   @Override
   public boolean canPlaceBlockOnSide(World worldIn, BlockPos pos, EnumFacing side) {
      return worldIn.isSideSolid(pos.offset(side.getOpposite()), side, true);
   }
   
   @Override
   public boolean canPlaceBlockAt(World world, BlockPos pos) {
      EnumFacing[] anenumfacing = EnumFacing.values();
      int i  = anenumfacing.length;
      
      for (int j = 0; j < i; j++) {
         EnumFacing enumfacing = anenumfacing[j];
         
         if (world.isSideSolid(pos.offset(enumfacing), enumfacing.getOpposite(), true)) {
            return true;
         }
      }
      
      return false;
   }
   
   @Override
   public IBlockState onBlockPlaced(World world, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer) {
        Miscal.modLogger.debug("Placed Block");
      
      return world.isSideSolid(pos.offset(facing.getOpposite()), facing, true) ? this.getDefaultState().withProperty(FACING, facing).withProperty(LIT_UP, Boolean.valueOf(false)) : this.getDefaultState().withProperty(FACING, EnumFacing.DOWN).withProperty(LIT_UP, Boolean.valueOf(false));
    }
   
   @Override
   public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
      setBlockBoundsBasedOnFacing(worldIn, pos);
      
      Miscal.modLogger.debug("Placed Block");
   }
   
   @Override
   public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumFacing side, float hitX, float hitY, float hitZ) {
      if (!world.isRemote) {
         boolean litUp = (Boolean) state.getValue(LIT_UP);
         
         if(!litUp) {
            world.setBlockState(pos, state.withProperty(LIT_UP, Boolean.valueOf(true)));
            
            setBlockBoundsBasedOnFacing(world, pos);
         } else {
            world.setBlockState(pos, state.withProperty(LIT_UP, Boolean.valueOf(false)));
            
            setBlockBoundsBasedOnFacing(world, pos);
         }
      }
      
      world.notifyNeighborsOfStateChange(pos, this);
        world.notifyNeighborsOfStateChange(pos.offset(((EnumFacing) state.getValue(FACING)).getOpposite()), this);
      
      return true;
   }
   
   //Switches light value when blockstate changes
   @Override
   public int getLightValue(IBlockAccess world, BlockPos pos) {
      int lightValue = 0;
      
      boolean litUp = (Boolean) world.getBlockState(pos).getValue(LIT_UP);


         if (litUp) {
            lightValue = 15;
      } else {
         lightValue = 0;
      }
   
      return lightValue;
   }
   
   @Override
   public IBlockState getStateFromMeta(int meta) {
      boolean lit = false;
      EnumFacing facing = EnumFacing.NORTH;
      
      switch (meta) {
      case 0:
         lit = false;
         break;
      case 1:
         lit = true;
         break;
      case 2:
         facing = EnumFacing.NORTH;
         break;
      case 3:
         facing = EnumFacing.EAST;
         break;
      case 4:
         facing = EnumFacing.SOUTH;
         break;
      case 5:
         facing = EnumFacing.WEST;
         break;
      case 6:
         facing = EnumFacing.UP;
         break;
      case 7:
         facing = EnumFacing.DOWN;
         break;
      }
      
      return this.getDefaultState().withProperty(LIT_UP, Boolean.valueOf(lit)).withProperty(FACING, facing);
   }
   
   
   public void setBlockBoundsBasedOnFacing(IBlockAccess world, BlockPos pos) {
      boolean litUp = (Boolean) world.getBlockState(pos).getValue(LIT_UP);
      EnumFacing facing = (EnumFacing) world.getBlockState(pos).getValue(FACING);
      
      if (facing == EnumFacing.NORTH) {
         if (litUp) {
            this.setBlockBounds(0F * pixel, 5F * pixel, 5F * pixel, 2F * pixel, 11F * pixel, 11F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.WEST) {
         if (litUp) {
            this.setBlockBounds(5F * pixel, 5F * pixel, 0F * pixel, 11F * pixel, 2F * pixel, 11F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.SOUTH) {
         if (litUp) {
            this.setBlockBounds(16F * pixel, 11F * pixel, 11F * pixel, 13F * pixel, 5F * pixel, 5F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.EAST) {
         if (litUp) {
            this.setBlockBounds(11F * pixel, 11F * pixel, 16F * pixel, 5F * pixel, 13F * pixel, 5F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.UP) {
         if (litUp) {
            this.setBlockBounds(5F * pixel, 0F * pixel, 5F * pixel, 11F * pixel, 2F * pixel, 11F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      } else if (facing == EnumFacing.DOWN) {
         if (litUp) {
            this.setBlockBounds(11F * pixel, 16F * pixel, 11F * pixel, 5F * pixel, 13F * pixel, 5F * pixel);
         } else {
            this.setBlockBounds(16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel, 16F * pixel);
         }
      }
      
      Miscal.modLogger.debug("Set Block Bounds to " + toString(facing));
   }
   
   private String toString(EnumFacing facing) {
      return facing.getName();
   }
   
   @Override
   public int getMetaFromState(IBlockState state) {
      if((EnumFacing) state.getValue(FACING) == EnumFacing.NORTH) {
         return 0;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.WEST) {
         return 1;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.SOUTH) {
         return 2;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.EAST) {
         return 3;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.UP) {
         return 4;
      } else if ((EnumFacing) state.getValue(FACING) == EnumFacing.DOWN) {
         return 5;
      } else if ((Boolean) state.getValue(LIT_UP) == false) {
         return 6;
      } else {
         return 7;
      }
   }
   
   @Override
   @SideOnly(Side.CLIENT)
   public IBlockState getStateForEntityRender(IBlockState state) {
      return this.getDefaultState().withProperty(LIT_UP, Boolean.valueOf(false)).withProperty(FACING, Integer.valueOf(0));
   }
   
   @Override
   protected BlockState createBlockState() {
      return new BlockState(this, new IProperty[] {LIT_UP, FACING});
   }
   
   @Override
   public int getRenderType() {
      return 3; 
   }
   
   @Override
   public boolean isOpaqueCube() {
      return false;
   }
   
   @SideOnly(Side.CLIENT)
   @Override
   public EnumWorldBlockLayer getBlockLayer() {
      return EnumWorldBlockLayer.CUTOUT_MIPPED;
   }
   
   @Override
   public boolean isFullCube() {
      return false;
   }
   
   @Override
   public int isProvidingWeakPower(IBlockAccess worldIn, BlockPos pos, IBlockState state, EnumFacing side) {
        return (Boolean) state.getValue(LIT_UP) ? 15 : 0;
    }


   @Override
    public int isProvidingStrongPower(IBlockAccess worldIn, BlockPos pos, IBlockState state, EnumFacing side){
        return (Boolean) state.getValue(LIT_UP) ? 0 : (state.getValue(FACING) == side ? 15 : 0);
    }
    
   @Override
    public boolean canProvidePower() {
        return true;
    }
   
}

 

 

Any help? Thanks in advance!

 

 

EDIT 1

 

 

Never mind. It seems that they ARE working, but Logger.debug is not. No clue why that is.

[Cerandior]

You probably waiting for help but i would like to know what propertydirection is . I have used forgedirections before but this?

[LordMastodon]

It uses EnumFacing. It's how you switch the block's direction when it's placed and things like that. It's basically NORTH, WEST, SOUTH, EAST, UP, DOWN.

[ItsAMysteriousYT]

OnBlockPlacedBy doesn't work for me either - i try setting rotation of a tileentity with it. Probably this is a forge bug?

[LordMastodon]

I don't know. It seems to be working for my other block, but there I use onBlockAdded so I don't know if that's important.

[LordMastodon]

UPDATE

 

onBlockAdded

doesn't seem to be working either. There also seems to be an odd bug that results in the block having no bounding box when I place it, but when I close Minecraft and reload the world the block has a full bounding box until I place a new block, and then the bounding boxes of every single instance of that block disappears. When I right-click the block when it has a bounding box the box disappears as well.

[Choonster]

  On 9/4/2015 at 12:40 PM, LordMastodon said:

EDIT 1

 

 

Never mind. It seems that they ARE working, but Logger.debug is not. No clue why that is.

 

Are you looking at the IDE's console or the log file itself? Messages with a

Level

less specific than

INFO

(i.e.

DEBUG

,

TRACE

or

ALL

) won't be written to the standard output (i.e. the IDE's console), but will be written to the log file.

[LordMastodon]

Why is that? Can I change it?

[Choonster]

  On 9/8/2015 at 8:45 PM, LordMastodon said:

Why is that? Can I change it?

 

It's controlled by the log4j2.xml file inside the Forge JAR. You can probably change it by removing

level="INFO"

from line 54.

[LordMastodon]

It's not letting me edit the file in eclipse.

[LordMastodon]

OK, thanks.