[1.8] IEEP Variables kept through death?

[statphantom]

I need help making IExtendedEntityProperties to persist through death, I have read a LOT of tutorials on this, read up about packet handling however none are working for me or I am just not understanding it.

 

I have created a class that implements IGuiHandler that stores the data in a map as a NBTTagCompound, and have saved it through onLivingDeathEvent and load it through onEntityJoinWorld however I can't find a proper way to 'sync' the data from the server with the client and... well W.E. else needs to be done in this area.

 

can someone help? this is what I have so far.

 

Proxy to store the data:

 

package statslevelmod;

import java.util.HashMap;
import java.util.Map;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;

public class DeathProxy implements IGuiHandler{

private static final Map<String, NBTTagCompound> extendedEntityData = new HashMap<String, NBTTagCompound>();

public void registerRenderers(){}

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world,	int x, int y, int z) {
	return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world,	int x, int y, int z) {
	return null;
}

public static void storeEntityData(String name, NBTTagCompound compound) {
	extendedEntityData.put(name, compound);
}

public static NBTTagCompound getEntityData(String name) {
	return extendedEntityData.remove(name);
}
}

 

 

Event Handlers:

 

package statslevelmod;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.Entity;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemAxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemTool;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.client.event.RenderGameOverlayEvent;
import net.minecraftforge.event.entity.EntityEvent.EntityConstructing;
import net.minecraftforge.event.entity.EntityJoinWorldEvent;
import net.minecraftforge.event.entity.living.LivingDeathEvent;
import net.minecraftforge.event.entity.player.PlayerEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent.Action;
import net.minecraftforge.event.world.BlockEvent.HarvestDropsEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class LevelEventHandler {

@SubscribeEvent
public void onEntityConstructing(EntityConstructing event) {

	if (event.entity instanceof EntityPlayer && PlayerVariables.get((EntityPlayer) event.entity) == null) {
		PlayerVariables.register((EntityPlayer) event.entity);
	}
}

@SubscribeEvent
public void onEntityJoinWorld(EntityJoinWorldEvent event) {
	if (!event.entity.worldObj.isRemote && event.entity instanceof EntityPlayer) {
		NBTTagCompound playerData = DeathProxy.getEntityData(((EntityPlayer) event.entity).getName());
		if (playerData != null) {
			((PlayerVariables)(event.entity.getExtendedProperties(PlayerVariables.EXT_PROP_NAME))).loadNBTData(playerData);
		}
	}
}

@SubscribeEvent
public void onLivingDeathEvent(LivingDeathEvent event) {
	if (!event.entity.worldObj.isRemote && event.entity instanceof EntityPlayer) {

		NBTTagCompound playerdata = new NBTTagCompound();
		((PlayerVariables)(event.entity.getExtendedProperties(PlayerVariables.EXT_PROP_NAME))).saveNBTData(playerdata);
		DeathProxy.storeEntityData(((EntityPlayer) event.entity).getName(), playerdata);
		PlayerVariables.saveProxyData((EntityPlayer) event.entity);
	}
}
}

 

 

My IEEP class

 

package statslevelmod;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ChatComponentStyle;
import net.minecraft.util.ChatComponentText;
import net.minecraft.util.ChatStyle;
import net.minecraft.util.EnumChatFormatting;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;

public class PlayerVariables implements IExtendedEntityProperties{

public final static String EXT_PROP_NAME = "PlayerVariables";

private final EntityPlayer player;

private final double baseexp = 80;
private final double factor = 1.18;

public final static String gatheringname = "Gathering";
public final static String miningname = "Mining";
public final static String agilityname = "Agility";

private double gatheringexp, miningexp, agilityexp;
private int gatheringlvl, mininglvl, agilitylvl;

public PlayerVariables(EntityPlayer user) {
	player = user;

	gatheringexp = 0;
	miningexp = 0;
	agilityexp = 0;
	gatheringlvl = 0;
	mininglvl = 0;
	agilitylvl = 0;
}

public void addGatheringExp(double exp) {
	if (gatheringlvl == 0) {
		gatheringlvl = 1;
	} else {
		gatheringexp += exp;
		double expneeded = (baseexp *(Math.pow((gatheringlvl + 1), factor)));
		while (gatheringexp > expneeded) {
			gatheringlvl += 1;
			gatheringexp -= expneeded;
			ChatComponentText text = new ChatComponentText("DING! Congradulations you are now level " + gatheringlvl + " in " + gatheringname + "!");
			ChatStyle style = new ChatStyle();
			style.setUnderlined(true);
			style.setColor(EnumChatFormatting.GOLD);
			text.setChatStyle(style);
			this.player.addChatComponentMessage(text);
		}
	}
}

public void addMiningExp(double exp) {
	if (mininglvl == 0) {
		mininglvl = 1;
	} else {
		miningexp += exp;
		double expneeded = (baseexp *(Math.pow((mininglvl + 1), factor)));
		while (miningexp > expneeded) {
			mininglvl += 1;
			miningexp -= expneeded;
			ChatComponentText text = new ChatComponentText("DING! Congradulations you are now level " + mininglvl + " in " + miningname + "!");
			ChatStyle style = new ChatStyle();
			style.setUnderlined(true);
			style.setColor(EnumChatFormatting.GOLD);
			text.setChatStyle(style);
			this.player.addChatComponentMessage(text);
		}
	}
}

public void addAgilityExp(double exp) {
	if (agilitylvl == 0) {
		agilitylvl = 1;
	} else {
		agilityexp += exp;
		double expneeded = (baseexp *(Math.pow((mininglvl + 1), factor)));
		while (agilityexp > expneeded) {
			agilitylvl += 1;
			agilityexp -= expneeded;
			ChatComponentText text = new ChatComponentText("DING! Congradulations you are now level " + agilitylvl + " in " + agilityname + "!");
			ChatStyle style = new ChatStyle();
			style.setUnderlined(true);
			style.setColor(EnumChatFormatting.GOLD);
			text.setChatStyle(style);
			this.player.addChatComponentMessage(text);
		}
	}
}

public double getGatheringExp(){
	return gatheringexp;
}

public double getMiningExp(){
	return miningexp;
}

public double getAgilityExp(){
	return agilityexp;
}

public int getGatheringlvl(){
	return gatheringlvl;
}

public int getMininglvl(){
	return mininglvl;
}

public int getAgilitylvl(){
	return agilitylvl;
}

public static final void register(EntityPlayer player)
{
	player.registerExtendedProperties(PlayerVariables.EXT_PROP_NAME, new PlayerVariables(player));
}

public static final PlayerVariables get(EntityPlayer player)
{
	return (PlayerVariables) player.getExtendedProperties(EXT_PROP_NAME);
}

public static void saveProxyData(EntityPlayer player) {
	PlayerVariables playerData = PlayerVariables.get(player);
	NBTTagCompound savedData = new NBTTagCompound();
	playerData.saveNBTData(savedData);
	DeathProxy.storeEntityData(getSaveKey(player), savedData);
}

private static String getSaveKey(EntityPlayer player) {
	return player.getName() + ":" + EXT_PROP_NAME;
}

@Override
public void saveNBTData(NBTTagCompound compound) {

	NBTTagCompound properties = new NBTTagCompound();

	properties.setInteger("gatheringlvl", this.gatheringlvl);
	properties.setInteger("mininglvl", this.mininglvl);
	properties.setInteger("agilitylvl", this.agilitylvl);
	properties.setDouble("gatheringexp", this.gatheringexp);
	properties.setDouble("miningexp", this.miningexp);
	properties.setDouble("agilityexp", this.agilityexp);

	compound.setTag(EXT_PROP_NAME, properties);
}

@Override
public void loadNBTData(NBTTagCompound compound) {

	NBTTagCompound properties = (NBTTagCompound) compound.getTag(EXT_PROP_NAME);

	this.gatheringlvl = properties.getInteger("gatheringlvl");
	this.mininglvl = properties.getInteger("mininglvl");
	this.agilitylvl = properties.getInteger("agilitylvl");
	this.gatheringexp = properties.getDouble("gatheringexp");
	this.miningexp = properties.getDouble("miningexp");
	this.agilityexp = properties.getDouble("agilityexp");

	System.out.println("Loaded NBT Data");
}

@Override
public void init(Entity entity, World world) {
	// TODO Auto-generated method stub

}

}

 

 

Thanks for any information

[Choonster]

Use

PlayerEvent.Clone

to clone IEEP data from the old instance of a player to the new one after they respawn. You shouldn't need to store the data in any kind of proxy, and there's no point in implementing

IGuiHandler

unless you're actually using the class as your GUI handler.

[statphantom]

Use

PlayerEvent.Clone

to clone IEEP data from the old instance of a player to the new one after they respawn. You shouldn't need to store the data in any kind of proxy, and there's no point in implementing

IGuiHandler

unless you're actually using the class as your GUI handler.

 

how do you store the old instance?

 

PS: I have noticed that this is working already but if I add a client GUI display of these variables they don't sync up

[Ernio]

how do you store the old instance?

 

You don't. The old school was to store data in static maps. Not anymore since 1.5 or something around. Now you use (as mentioned before) Clone event.

 

@SubscribeEvent
public void onPlayerClonning(PlayerEvent.Clone event)
{
ExtendedPlayer epNew = ExtendedPlayer.get(event.entityPlayer);
ExtendedPlayer epOld = ExtendedPlayer.get(event.original);
epOld.copyTo(epNew); // method that copies fields from old to new
}

 

PS: I have noticed that this is working already but if I add a client GUI display of these variables they don't sync up

 

For each EntityPlayer (considering you are doing it properly) there is one IEEP instance. Server and client holds different instances for EntityPlayers!

 

PlayerEvent.Clone is SERVER event. It is not fired on client, thus any data on client is lost.

You need to send all data from Clone event to given player, preferably at the end of it. In example above I have player.sync() called at the end of #copyTo(player) method.

[statphantom]

great.... now I need to go through all my code and delete the ~100 lines of coding I did to get it working and just do that.

 

can you show me your copyTo(ExtendedPlayer player) and sync() methods please?

 

I have been using saveNBTData and loadNBTData to get the data and no sync method. the sync() was what was annoying me. using clone do I still need these NBT methods?

 

ps: shouldn't we call opnew.copyFrom(epOld) ? or does it not really matter.

[Failender]

ExtendedPlayer epNew = ExtendedPlayer.get(event.entityPlayer);
ExtendedPlayer epOld = ExtendedPlayer.get(event.original);
NBTTagCompound comp = new NBTTagCompound();
epNew.writeToNBT(comp);
epOld.readFromNBT(comp);

 

This will copy every variable u are reading in ur nbt stuff

 

[statphantom]

ExtendedPlayer epNew = ExtendedPlayer.get(event.entityPlayer);
ExtendedPlayer epOld = ExtendedPlayer.get(event.original);
NBTTagCompound comp = new NBTTagCompound();
epNew.writeToNBT(comp);
epOld.readFromNBT(comp);

 

This will copy every variable u are reading in ur nbt stuff

 

with epNew and epOld switched? cause that to me looks like it will write nothing to epNew and then get the data from epOld

[Failender]

eeeeehm. that was a test to see if u are paying attention. you passed?

[delpi]

ROFL