Jump to content

[1.7.10] [SOLVED] Strange crash with ShapedOreRecipe


Elix_x

Recommended Posts

Hello everybody!

I met another strange problem today, so:

-In my mod, user can full configure recipe in config file using string array.

-String array using translator gets translated in to ShapedOreRecipe or ShapelessOreRecipe (depending on how user configured recipe).

-I'm registering 8 recipes using this method.

-For some reason, it crashes... And for unknown reason, at end of Object[], there's null item added:

Invalid shaped ore recipe: I, G G, IBI, I, ingotIron, G, paneGlass, B, blockIron, [b]1xitem.null@0[/b]

-Full crash report:

[15:32:45] [Client thread/ERROR] [FML]: Fatal errors were detected during the transition from INITIALIZATION to POSTINITIALIZATION. Loading cannot continue
[15:32:45] [Client thread/ERROR] [FML]: 
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHI	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) 
UCHI	FML{7.10.99.99} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar) 
UCHI	Forge{10.13.4.1492} [Minecraft Forge] (forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar) 
UCHI	CodeChickenCore{1.0.6.43} [CodeChicken Core] (minecraft.jar) 
UCHI	NotEnoughItems{1.0.4.105} [Not Enough Items] (NotEnoughItems-1.7.10-1.0.4.105-universal.jar) 
UCHI	excore{1.1.3} [EXCore] (bin) 
UCHE	powerofbreathing{1.0} [Power Of Breathing] (bin) 
UCHI	colourfullblocks{1.0.1} [Colourfull Blocks] (ColorfulBlocks-LATEST-1.7.10.jar) 
[15:32:45] [Client thread/ERROR] [FML]: The following problems were captured during this phase
[15:32:45] [Client thread/ERROR] [FML]: Caught exception from powerofbreathing
java.lang.RuntimeException: Invalid shaped ore recipe: I, G G, IBI, I, ingotIron, G, paneGlass, B, blockIron, 1xitem.null@0
at net.minecraftforge.oredict.ShapedOreRecipe.<init>(ShapedOreRecipe.java:82) ~[forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar:?]
at code.elix_x.excore.utils.recipes.RecipeStringTranslator.fromString(RecipeStringTranslator.java:47) ~[bin/:?]
at code.elix_x.mods.powerofbreathing.config.ConfigurationManager.init(ConfigurationManager.java:120) ~[bin/:?]
at code.elix_x.mods.powerofbreathing.PowerOfBreathingBase.init(PowerOfBreathingBase.java:186) ~[bin/:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_25]
at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532) ~[forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_25]
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) ~[guava-17.0.jar:?]
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) ~[guava-17.0.jar:?]
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) ~[guava-17.0.jar:?]
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) ~[guava-17.0.jar:?]
at com.google.common.eventbus.EventBus.post(EventBus.java:275) ~[guava-17.0.jar:?]
at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212) ~[forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar:?]
at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190) ~[forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_25]
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) ~[guava-17.0.jar:?]
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) ~[guava-17.0.jar:?]
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) ~[guava-17.0.jar:?]
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) ~[guava-17.0.jar:?]
at com.google.common.eventbus.EventBus.post(EventBus.java:275) ~[guava-17.0.jar:?]
at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119) [LoadController.class:?]
at cpw.mods.fml.common.Loader.initializeMods(Loader.java:737) [Loader.class:?]
at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311) [FMLClientHandler.class:?]
at net.minecraft.client.Minecraft.startGame(Minecraft.java:597) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:942) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:164) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_25]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source) [start/:?]
at GradleStart.main(Unknown Source) [start/:?]
[15:32:45] [Client thread/INFO] [sTDOUT]: [net.minecraft.client.Minecraft:displayCrashReport:388]: ---- Minecraft Crash Report ----
// Daisy, daisy...

Time: 20.10.15 15:32
Description: Initializing game

java.lang.RuntimeException: Invalid shaped ore recipe: I, G G, IBI, I, ingotIron, G, paneGlass, B, blockIron, 1xitem.null@0
at net.minecraftforge.oredict.ShapedOreRecipe.<init>(ShapedOreRecipe.java:82)
at code.elix_x.excore.utils.recipes.RecipeStringTranslator.fromString(RecipeStringTranslator.java:47)
at code.elix_x.mods.powerofbreathing.config.ConfigurationManager.init(ConfigurationManager.java:120)
at code.elix_x.mods.powerofbreathing.PowerOfBreathingBase.init(PowerOfBreathingBase.java:186)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)
at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)
at cpw.mods.fml.common.Loader.initializeMods(Loader.java:737)
at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311)
at net.minecraft.client.Minecraft.startGame(Minecraft.java:597)
at net.minecraft.client.Minecraft.run(Minecraft.java:942)
at net.minecraft.client.main.Main.main(Main.java:164)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)
at GradleStart.main(Unknown Source)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
at net.minecraftforge.oredict.ShapedOreRecipe.<init>(ShapedOreRecipe.java:82)
at code.elix_x.excore.utils.recipes.RecipeStringTranslator.fromString(RecipeStringTranslator.java:47)
at code.elix_x.mods.powerofbreathing.config.ConfigurationManager.init(ConfigurationManager.java:120)
at code.elix_x.mods.powerofbreathing.PowerOfBreathingBase.init(PowerOfBreathingBase.java:186)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)
at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
at com.google.common.eventbus.EventBus.post(EventBus.java:275)
at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)
at cpw.mods.fml.common.Loader.initializeMods(Loader.java:737)
at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:311)
at net.minecraft.client.Minecraft.startGame(Minecraft.java:597)

-- Initialization --
Details:
Stacktrace:
at net.minecraft.client.Minecraft.run(Minecraft.java:942)
at net.minecraft.client.main.Main.main(Main.java:164)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at net.minecraftforge.gradle.GradleStartCommon.launch(Unknown Source)
at GradleStart.main(Unknown Source)

-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Windows 7 (amd64) version 6.1
Java Version: 1.8.0_25, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 816557224 bytes (778 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)
JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1492 8 mods loaded, 8 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHI	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) 
UCHI	FML{7.10.99.99} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar) 
UCHI	Forge{10.13.4.1492} [Minecraft Forge] (forgeSrc-1.7.10-10.13.4.1492-1.7.10.jar) 
UCHI	CodeChickenCore{1.0.6.43} [CodeChicken Core] (minecraft.jar) 
UCHI	NotEnoughItems{1.0.4.105} [Not Enough Items] (NotEnoughItems-1.7.10-1.0.4.105-universal.jar) 
UCHI	excore{1.1.3} [EXCore] (bin) 
UCHE	powerofbreathing{1.0} [Power Of Breathing] (bin) 
UCHI	colourfullblocks{1.0.1} [Colourfull Blocks] (ColorfulBlocks-LATEST-1.7.10.jar) 
GL info: ' Vendor: 'ATI Technologies Inc.' Version: '4.4.13084 Compatibility Profile Context 14.301.1001.0' Renderer: 'AMD Radeon HD 8570D'
Launched Version: 1.7.10
LWJGL: 2.9.1
OpenGL: AMD Radeon HD 8570D GL version 4.4.13084 Compatibility Profile Context 14.301.1001.0, ATI Technologies Inc.
GL Caps: Using GL 1.3 multitexturing.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Anisotropic filtering is supported and maximum anisotropy is 16.
Shaders are available because OpenGL 2.1 is supported.

Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: []
Current Language: English (US)
Profiler Position: N/A (disabled)
Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
Anisotropic Filtering: Off (1)
[15:32:45] [Client thread/INFO] [sTDOUT]: [net.minecraft.client.Minecraft:displayCrashReport:398]: #@!@# Game crashed! Crash report saved to: #@!@# C:\my\mcmodding\mods\power of breathing\eclipse\.\crash-reports\crash-2015-10-20_15.32.45-client.txt
AL lib: (EE) alc_cleanup: 1 device not closed
Java HotSpot(TM) 64-Bit Server VM warning: Using incremental CMS is deprecated and will likely be removed in a future release

-Before continuing, here's translator code: https://gist.github.com/elix-x/3bdb448ae1d5bbf120d3

-For gist you see, it crashes on line 34.

-I debugged with breakpoint on line 29 of gist and on line 31 of ShapedOreRecipe, and here's what i got in variables:

--Gist:29:oyGTjdM.png

--ShapedOreRecipe:31:tq3UbzC.png

-As you can see, there's no

1xitem.null@0

on end of array nor when it completes method translation, nor when it enters new ShapedOreRecipe.

-Minecraft crashes right after this breakpoint is past.

Do you have any ideas why this is happening?

 

Thanks for help!

If you have any questions - just ask!

Link to comment
Share on other sites

The exception on line 82 of

ShapedOreRecipe

is thrown when the length of the full shape string isn't equal to the width (the length of the last individual shape string) times the height (the number of individual shape strings).

 

All shape strings must be the same length. Shape strings are whitespace-sensitive, so

"I"

isn't the same as

" I "

.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

The exception on line 82 of

ShapedOreRecipe

is thrown when the length of the full shape string isn't equal to the width (the length of the last individual shape string) times the height (the number of individual shape strings).

 

All shape strings must be the same length. Shape strings are whitespace-sensitive, so

"I"

isn't the same as

" I "

.

I know this... And why it's "I" and not " I " returned, if in config file i have this:

   S:"air bottle frame" <
         I 
        G G
        IBI
        I
        oreDict:ingotIron
        G
        oreDict:paneGlass
        B
        oreDict:blockIron
     >

Wait, what? Does Configuration.class ignores spaces or trims string when reading string array?

 

EDIT: It does... But WHY? And how can i go around it? Because in this case... I don't even know... It's impossible to configure recipes using .cfg???

Link to comment
Share on other sites

Use a different character.

Read from the cfg file and then replace '_' (or whatever) with ' '.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Use a different character.

Read from the cfg file and then replace '_' (or whatever) with ' '.

It may work, but still not the best idea. If we use rare character, then user will not be able to find it. If we use '_' for example, then if i replace it in every string of array, i may affect items that are named using this character. And it will be useless, when recipe is shapeless...

Meanwhile, i use same translation code for another mod, whose recipes are configured via json, and json keeps spaces in strings...

Thanks, anyways...

Link to comment
Share on other sites

Use a different character.

Read from the cfg file and then replace '_' (or whatever) with ' '.

It may work, but still not the best idea. If we use rare character, then user will not be able to find it. If we use '_' for example, then if i replace it in every string of array, i may affect items that are named using this character. And it will be useless, when recipe is shapeless...

Meanwhile, i use same translation code for another mod, whose recipes are configured via json, and json keeps spaces in strings...

Thanks, anyways...

 

1) Use _, no one is going to be affected strangely.  You just have to make sure to document the config file correctly.

2) Only do the replacement on the recipe portion.  This is at most the first 3 strings.

3) Shapeless recipes won't matter, their construction is different, they only have inputs and a result.

4) Yes, json does preserve whitespace, the Forge config files were never meant to handle this sort of data.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Use a different character.

Read from the cfg file and then replace '_' (or whatever) with ' '.

It may work, but still not the best idea. If we use rare character, then user will not be able to find it. If we use '_' for example, then if i replace it in every string of array, i may affect items that are named using this character. And it will be useless, when recipe is shapeless...

Meanwhile, i use same translation code for another mod, whose recipes are configured via json, and json keeps spaces in strings...

Thanks, anyways...

 

1) Use _, no one is going to be affected strangely.  You just have to make sure to document the config file correctly.

2) Only do the replacement on the recipe portion.  This is at most the first 3 strings.

3) Shapeless recipes won't matter, their construction is different, they only have inputs and a result.

4) Yes, json does preserve whitespace, the Forge config files were never meant to handle this sort of data.

Yeah, i can find end of recipe portion using way i already use (find first string with single character, here's begining of definitions) and replace all '_' to ' ' in there without problems. Yes, shapeless recipes don't have recipe part, nor definition part... And i already have a method to check whether or not recipe is shaped...

That's why i like json, but for this project (and few others), i'd like to keep configurations in one place.

 

Using '_' will definetly work, but is not best idea ever... I'll probably go with that, but i still accept other ideas too...

Link to comment
Share on other sites

Yeah, i can find end of recipe portion using way i already use (find first string with single character, here's begining of definitions)

 

That's a crappy method.

 

   #Use _ to represent spaces (no item) in recipes.
   S:"quarterstaff" <
        S
        S
        S
        S
        oreDict:itemStick
     >

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Yeah, i can find end of recipe portion using way i already use (find first string with single character, here's begining of definitions)

 

That's a crappy method.

 

   #Use _ to represent spaces (no item) in recipes.
   S:"quarterstaff" <
        S
        S
        S
        S
        oreDict:itemStick
     >

It's in short. Of course, i don't simply find first string with one character, i also check next string for item stack validity:

			int i;
		for(i = 0; i < srecipe.length; i++){
			if(srecipe[i].length() == 1 && ItemStackStringTranslator.isValidItemstackAdvanced(srecipe[i + 1])) break;
		}
		return i;

Link to comment
Share on other sites

Cough, cough... WHAT?

I tried using '_' and for some reason, in config file, in String[], '_' are replaced by ' '. They are kept in

[default: ]

however, that's why i know that to this point my code is correct...

    # Configure recipe for air bottle frame. [default: [_I_], [G G], [iBI], [i], [oreDict:ingotIron], [G], [oreDict:paneGlass], [b], [oreDict:blockIron]]
    S:"air bottle frame" <
         I 
        G G
        IBI
        I
        oreDict:ingotIron
        G
        oreDict:paneGlass
        B
        oreDict:blockIron

Link to comment
Share on other sites

What happens if you use quotes (single or double) to demarcate your recipe strings inside the cfg file?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

What happens if you use quotes (single or double) to demarcate your recipe strings inside the cfg file?

Do you mean put " in begining and end of each string of array?

Pretty good idea... Technically any caracter to mark begining and end will work, but quotes are commonly used... And then in code replace them with nothing, before converting to recipe...

I'll try it...

Link to comment
Share on other sites

Since the cfg environment is slightly hostile toward normal recipe formulation, you'll just need to impose a restriction on recipes entered this way. Set aside one character to be translated into a space internally, and tell users to never use that character to represent an ingredient. Zero is a good place-holder. See if numeral '0' (zero) will work.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Since the cfg environment is slightly hostile toward normal recipe formulation, you'll just need to impose a restriction on recipes entered this way. Set aside one character to be translated into a space internally, and tell users to never use that character to represent an ingredient. Zero is a good place-holder. See if numeral '0' (zero) will work.

0 does not work too...

I think it's time to check all characters one by one...

 

EDIT: Can't think of "uncommon" character that won't be used in recipe and is accepted by config. Any more ideas???

Link to comment
Share on other sites

I fixed it!

Problem was that configuration gives me array that it will save (and not copy of it as i thought). So when my utils replaced '_' to ' ' in this array, array without '_' was saved...

So you have to copy it before applying any modifications to it.

Thanks to everybody who helped!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.