[1.8] [SOLVED] Hardness according to meta

[Koward]

Hi.

I wanted a custom hardness for my blocks. But when I break the block, instant crash.

All this blockstates thing is starting to look like a joke for me. Is it just good for anything but textures and models ?

This is the problem function, in my custom Block class. I don't get it. Everything I did here is really simple, I can't see why it can't work.

@Override
public float getBlockHardness(World world, BlockPos pos) {
	int meta = this.getMetaFromState(world.getBlockState(pos));
	switch (meta) {
	case 0:
		this.setHardness(3.0F);
	case 1:
		this.setHardness(4.5F);
	default:
		this.setHardness(1.5F);
	}
	return this.blockHardness;
}

[coolAlias]

Don't call #setHardness each time - there is only one instance of your Block, so each time you call that method EVERY one of your blocks in the world will change its hardness.

 

Instead, just return the value you want based on the meta, e.g. case 0: return 3.0F;

 

As for the crash, where is the crash report?

[Koward]

Now it crashed immediately.

Here is the console of the session :

http://hastebin.com/efuguvariz.vhdl

 

I'm thinking to redesign the block as multiple blocks made of one class registered multiple times. The way vanilla Ores work, for example. It seems more suited when you want to define behaviours and not just simple "graphical" properties.

[jeffryfisher]

No need for a crash report. I ran into this one myself last week. Vanilla Minecraft has a bug on the client side that calls getHardness *after* breaking a block (it's doing some stat calculation the wrong way). By that time, the block has already been replaced by air.

 

Therefore, whenever *anyone* wants a block's effective mining hardness to vary according to metadata, the getHardness function must test for air and give the default hardness if that's so. Proceed with fetching metadata only if your own block type is still at pos.

 

Here's my Override:

  @Override
  public float getBlockHardness (World w, BlockPos pos) {
    float default_h = super.blockHardness;
    IBlockState bs = w.getBlockState (pos);                    // Vanilla code has a client side bug
    boolean alreadyBroken = (bs.getBlock () == Blocks.air);

    if (alreadyBroken) return default_h;                // Check for vanilla code bug and escape before...

    switch (this.getMetaFromState (bs)) {      // This would crash client-side after player breaks the wall
      case 8:
        return 5.0F;    // Iron wall
      case 9:           // Red Sandstone
      case 10:          // Chiseled Red Sandstone
      case 11:          // Glass
      case 12:          // Glowstone
      case 13:          // Sea-lantern
        return 1.0F;
      case 14:
      case 15:
        return 3.0F;    // diamond & emerald
      default:
        return default_h;
    }
  }

 

PS: I tried to report the bug to Mojang, but because none of the vanilla block types fall into the trap (yet), Mojang deleted the report instead of leaving a note to fix it when convenient. They'll suffer later, probably when it's *not* convenient.

[Koward]

Thanks jeffry, I would have never found that bug on my own.

[coolAlias]

Ah yes, 1.8 - I had the same problem months ago when I updated and, after fixing it in a similar fashion to the above, totally forgot about it

PS: I tried to report the bug to Mojang, but because none of the vanilla block types fall into the trap (yet), Mojang deleted the report instead of leaving a note to fix it when convenient. They'll suffer later, probably when it's *not* convenient.

I've had the same experience - I reported one in 1.7.2 along with the fix for it, just a simple change x to y in the coordinates passed (they were passing x, x, z to getExplosionResistance). SIX months later, they close it saying it is no longer relevant because Blocks changed so much in 1.8. But in that time, they had 8 or so versions of 1.7 in which it could have been fixed -.-

 

Anyway, I no longer report bugs to them...

[Draco18s]

Anyway, I no longer report bugs to them...

 

Quite.

Took them freaking ages to fix the "save/load causes fireballs to get frozen in midair" bug.  As in, I reported it back in 1.6 and it got fixed in the last month.

 

And they still haven't fixed the "slabs on top of ice" issue ("floor Ypos, then subtract 1" rather than "ceiling Ypos, then subtract 1").