In my mod I have a furnace which will a base item and an additional item but when I try to change the resulting nbt of the item I cant becuase one of the methods is void and my method for recipes isnt void. Is there another way to change the nbt data? Here is my code

 

ForgeRecipes

package com.ashindigo.alloycraft.lib;

import com.ashindigo.alloycraft.AlloycraftItems;

import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ForgeRecipes {

public ForgeRecipes() {

}

public static ItemStack getSmeltingResult(Item item, Item item2) {
	return getOutput(item, item2);
}

public static ItemStack getOutput(Item item, Item item2) {
	// TODO get nbt setup
	if (item == Items.iron_ingot && item2 == AlloycraftItems.alloy || item == AlloycraftItems.alloy && item2 == Items.iron_ingot) {
		return new ItemStack(AlloycraftItems.alloy, 2);
	}
	return null;

}
}

 

ForgeTileEntity

package com.ashindigo.alloycraft.tileentites;

import com.ashindigo.alloycraft.blocks.ForgeBlock;
import com.ashindigo.alloycraft.lib.ForgeRecipes;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;

public class ForgeTileEntity extends TileEntity implements ISidedInventory {

private ItemStack slots[];

public int dualPower;
public int dualCookTime;
public static final int maxPower = 10000;
public static final int smeltingSpeed = 100;

private static final int[] slots_top = new int[] {0, 1};
private static final int[] slots_bottom = new int[] {3};
private static final int[] slots_side = new int[] {2};

private String customName;

public ForgeTileEntity() {
	slots = new ItemStack[4];
}

@Override
public int getSizeInventory() {
	return slots.length;
}

@Override
public ItemStack getStackInSlot(int i) {
	return slots[i];
}

@Override
public ItemStack getStackInSlotOnClosing(int i) {
	if (slots[i] != null) {
		ItemStack itemstack = slots[i];
		slots[i] = null;
		return itemstack;
	}else{
		return null;
	}
}

@Override
public void setInventorySlotContents(int i, ItemStack itemstack) {
	slots[i] = itemstack;
	if (itemstack != null && itemstack.stackSize > getInventoryStackLimit()) {
		itemstack.stackSize = getInventoryStackLimit();
	}
}

@Override
public int[] getAccessibleSlotsFromSide(int i) {
	return i == 0 ? slots_bottom : (i == 1 ? slots_top : slots_side);
}




@Override
public int getInventoryStackLimit() {
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer player) {
	if (worldObj.getTileEntity(xCoord, yCoord, zCoord) != this) {
		return false;
	}else{
		return player.getDistanceSq((double)xCoord + 0.5D, (double)yCoord + 0.5D, (double)zCoord + 0.5D) <= 64;
	}
}

public void openInventory() {}
public void closeInventory() {}

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack) {
	return i == 2 ? false : (i == 1 ? hasItemPower(itemstack) : true);
}

public boolean hasItemPower(ItemStack itemstack) {
	return getItemPower(itemstack) > 0;
}

private static int getItemPower (ItemStack itemstack) {
	if (itemstack == null) {
		return 0;
	}else{
		Item item = itemstack.getItem();

		if (item == Items.coal) return 50;
		if (item == Item.getItemFromBlock(Blocks.coal_block)) return 450;

		return 0;
	}
}

public ItemStack decrStackSize(int i, int j) {
	if (slots[i] != null) {
		if (slots[i].stackSize <= j) {
			ItemStack itemstack = slots[i];
			slots[i] = null;
			return itemstack;
		}

		ItemStack itemstack1 = slots[i].splitStack(j);

		if (slots[i].stackSize == 0) {
			slots[i] = null;
		}

		return itemstack1;
	}else{
		return null;
	}
}

public void readFromNBT (NBTTagCompound nbt) {
	super.readFromNBT(nbt);
	NBTTagList list = nbt.getTagList("Items", 10);
	slots = new ItemStack[getSizeInventory()];

	for (int i = 0; i < list.tagCount(); i++) {
		NBTTagCompound nbt1 = (NBTTagCompound)list.getCompoundTagAt(i);
		byte b0 = nbt1.getByte("Slot");

		if (b0 >= 0 && b0 < slots.length) {
			slots[b0] = ItemStack.loadItemStackFromNBT(nbt1);
		}
	}

	dualPower = nbt.getShort("PowerTime");
	dualCookTime = nbt.getShort("CookTime");
}

public void writeToNBT(NBTTagCompound nbt) {
	super.writeToNBT(nbt);
	nbt.setShort("PowerTime", (short)dualPower);
	nbt.setShort("CookTime", (short)dualCookTime);
	NBTTagList list = new NBTTagList();

	for (int i = 0; i < slots.length; i++) {
		if (slots[i] != null) {
			NBTTagCompound nbt1 = new NBTTagCompound();
			nbt1.setByte("Slot", (byte)i);
			slots[i].writeToNBT(nbt1);
			list.appendTag(nbt1);
		}
	}

	nbt.setTag("Items", list);
}


@Override
public String getInventoryName() {
	return "Alloy Furnace";
}

@Override
public boolean canInsertItem(int var1, ItemStack itemstack, int var3) {
	return this.isItemValidForSlot(var1, itemstack);
}

@Override
public boolean canExtractItem(int i, ItemStack itemstack, int j) {
	return j != 0 || i != 1 || itemstack.getItem() == Items.bucket;
}

@Override
public boolean hasCustomInventoryName() {
	return this.customName != null && this.customName.length() > 0;
}

public int getSmeltingProgressScaled(int i) {
	return (dualCookTime * i) / this.smeltingSpeed;
}

public int getPowerRemainingScaled(int i) {
	return (dualPower * i) / maxPower;
}

private boolean canSmelt() {

	if (slots[0] == null || slots[1] == null) {
		return false;
	}

	ItemStack itemstack = ForgeRecipes.getSmeltingResult(slots[0].getItem(), slots[1].getItem());

	if (itemstack == null) {
		return false;
	}

	if (slots[3] == null) {
		return true;
	}

	if (!slots[3].isItemEqual(itemstack)) {
		return false;
	}

	if (slots[3].stackSize < getInventoryStackLimit() && slots[3].stackSize < slots[3].getMaxStackSize()) {
		return true;
	}else{
		return slots[3].stackSize < itemstack.getMaxStackSize();
	}
}

private void mashItem() {
	if (canSmelt()) {
		ItemStack itemstack = ForgeRecipes.getSmeltingResult(slots[0].getItem(), slots[1].getItem());

		if (slots[3] == null) {
			slots[3] = itemstack.copy();
		}else if (slots[3].isItemEqual(itemstack)) {
			slots[3].stackSize += itemstack.stackSize;
		}

		for (int i = 0; i < 2; i++) {
			if (slots[i].stackSize <= 0) {
				slots[i] = new ItemStack(slots[i].getItem().setFull3D());
			}else{
				slots[i].stackSize--;
			}

			if (slots[i].stackSize <= 0){
				slots[i] = null;
			}
		}
	}
}

public boolean hasPower() {
	return dualPower > 0;
}

public boolean isSmelting() {
	return this.dualCookTime > 0;
}

public void updateEntity() {
	boolean flag = this.hasPower();
	boolean flag1= false;

	if(hasPower() && this.isSmelting()) {
		this.dualPower--;
	}

	if(!worldObj.isRemote) {
		if (this.hasItemPower(this.slots[2]) && this.dualPower < (this.maxPower - this.getItemPower(this.slots[2]))) {
			this.dualPower += getItemPower(this.slots[2]);

			if(this.slots[2] != null) {
				flag1 = true;

				this.slots[2].stackSize--;

				if(this.slots[2].stackSize == 0) {
					this.slots[2] = this.slots[2].getItem().getContainerItem(this.slots[2]);
				}
			}
		}

		if (hasPower() && canSmelt()) {
			dualCookTime++;

			if (this.dualCookTime == this.smeltingSpeed) {
				this.dualCookTime = 0;
				this.mashItem();
				flag1 = true;
			}
		}else{
			dualCookTime = 0;
		}

		if (flag != this.isSmelting()) {
			flag1 = true;
			ForgeBlock.updateBlockState(this.isSmelting(), this.worldObj, this.xCoord, this.yCoord, this.zCoord);
		}
	}

	if (flag1) {
		this.markDirty();
	}
    }

}

Sorry I probably should have worded it better its late. But the method ive been trying to set nbt with is this

 

return new ItemStack(AlloycraftItems.alloy, 2).stackTagCompound.setInteger("", 5);

 

but I can't use it because I can't return a void statement which is the .setInteger method. I was wondering if there is an alternate way to change the nbt data from the result.

Also, stackTagCompound is null by default. You need to create one, then add attributes.

You should learn what local variables are.

Your method does not need to have one line that just returns something. Store the ItemStack, modify it, then return it.

 

So I changed my code to use local variables but I cant convert from ItemStack to void.

 

ForgeRecipes

package com.ashindigo.alloycraft.lib;

import com.ashindigo.alloycraft.AlloycraftItems;

import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ForgeRecipes {

public ForgeRecipes() {

}

public static ItemStack getSmeltingResult(Item item, Item item2) {
	return getOutput(item, item2);
}

public static ItemStack getOutput(Item item, Item item2) {
	// TODO get nbt setup
	if (item == Items.iron_ingot && item2 == AlloycraftItems.alloy || item == AlloycraftItems.alloy && item2 == Items.iron_ingot) {
		ItemStack itemstack = new ItemStack(AlloycraftItems.alloy, 2);
		itemstack = itemstack.getTagCompound().setInteger("", 5)
		return itemstack;
	}
	return null;

}
}

ItemStacks have their tag compounds as null by default; You'll have to use the setTagCompound(new NBTTagCompound()) to allow you to store data on it.

if (!itemstack.hasTagCompound())
   itemstack.setTagCompound(new NBTTagCompound());
itemstack.getTagCompound().setInteger("", 5);

Please learn basic Java before modding Minecraft.

if (!itemstack.hasTagCompound())
   itemstack.setTagCompound(new NBTTagCompound());
itemstack.getTagCompound().setInteger("", 5);

Please learn basic Java before modding Minecraft.

 

Thank you for the help guys I got it working now and I guess I should reread some java guides too.