Search the Forums BEFORE making a new post.

[1.8.8] Structure generation generating in wrong Y coordenet

Posted December 27, 20159 yr

I'm working on making a structure but it keeps generating at the world height and not at the ground level, I have tried a lot of times but they just don't generate right.

package com.moreoresmod.main.worldgeneration.structure;

import java.util.List;
import java.util.Random;

import com.google.common.collect.Lists;
import com.moreoresmod.main.entitys.EntityDungonProtector;
import com.moreoresmod.main.init.MoreOresModBiomes;
import com.moreoresmod.main.init.MoreOresModBlocks;
import com.moreoresmod.main.init.MoreOresModItems;

import net.minecraft.block.BlockChest;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityChest;
import net.minecraft.tileentity.TileEntityMobSpawner;
import net.minecraft.util.BlockPos;
import net.minecraft.util.WeightedRandomChestContent;
import net.minecraft.world.World;
import net.minecraft.world.biome.BiomeGenBase;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraftforge.common.ChestGenHooks;
import net.minecraftforge.fml.common.IWorldGenerator;

public class Structures implements IWorldGenerator {

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
	if(world.provider.getDimensionId() == 0){
		if(world.getBiomeGenForCoords(new BlockPos(chunkX*16, 64, chunkZ*16)).equals(MoreOresModBiomes.otherlyworldBiome)){
			//generateTeleporterStructure(random,chunkX,chunkZ,world);
		}
	}else if(world.provider.getDimensionId() == 2){
		generateOtherlyworldDungen(random, chunkX, chunkZ, world);
	}


}

private void generateTeleporterStructure(Random random, int chunkX, int chunkZ, World world){
	int startX = chunkX * 16 + random.nextInt(16);
	int startY = world.getActualHeight() - 256 + random.nextInt(50);
	int startZ = chunkZ * 16 + random.nextInt(16);
	BlockPos pos = new BlockPos(startX,startY,startZ);
	world.setBlockState(pos, Blocks.bedrock.getDefaultState());
	int width = random.nextInt(5) *2 + 10;
	int length = width*2;
	int height = 7;
	for (int x=0; x<width; x++) {
		for (int z=0; z<length; z++) {
			for (int y=0; y<height; y++) {
				BlockPos bpos = pos.add(x, y, z);
				if (x==0 || x==width-1 || y==0 || y== height-1 || z==0 || z== length-1) 
					world.setBlockState(bpos, Blocks.bedrock.getDefaultState());
				else world.setBlockState(bpos, Blocks.air.getDefaultState());
			}
		}
	}
	int doorX = width /2;
	int chestZ = length-2;

	//door
	world.setBlockState(pos.add(doorX-1,1,0), Blocks.air.getDefaultState());
	world.setBlockState(pos.add(doorX-1,2,0), Blocks.air.getDefaultState());
	world.setBlockState(pos.add(doorX,1,0), Blocks.air.getDefaultState());
	world.setBlockState(pos.add(doorX,2,0), Blocks.air.getDefaultState());

	//chest
	world.setBlockState(pos.add(doorX, 1, chestZ), Blocks.chest.getDefaultState());
	world.setBlockState(pos.add(doorX-1, 1, chestZ), Blocks.chest.getDefaultState());

}

private void generateOtherlyworldDungen(Random rand, int chunkX, int chunkZ,World world){
	int startX = chunkX * 16 + rand.nextInt(50);
	int startY = world.getActualHeight() - 1;
	int startZ = chunkZ * 16 + rand.nextInt(50);



	while(world.getBlockState(new BlockPos(startX,startY,startZ)) == Blocks.air){
		startY--;
	}

	if(world.getBlockState(new BlockPos(startX,startY,startZ)) != Blocks.air){

		BlockPos pos = new BlockPos(startX, startY, startZ);

		for(int x = pos.getX() - 5; x == pos.getX() + 5; x++){
			for(int z = pos.getZ() - 5; z == pos.getX() + 5; z++){
				int y = pos.getY();

				world.setBlockState(new BlockPos(x, y, z), MoreOresModBlocks.otherlyworld_brick.getDefaultState());

			}
		}

		BlockPos spawner1 = pos.add(-3, 0, -3);

		 world.setBlockState(spawner1, Blocks.mob_spawner.getDefaultState(), 2);
             TileEntity tileentity1 = world.getTileEntity(spawner1);

             if (tileentity1 instanceof TileEntityMobSpawner)
             {
                  ((TileEntityMobSpawner)tileentity1).getSpawnerBaseLogic().setEntityName("Darkness");
             }
             
             BlockPos spawner2 = pos.add(3, 0, -3);

		 world.setBlockState(spawner2, Blocks.mob_spawner.getDefaultState(), 2);
             TileEntity tileentity2 = world.getTileEntity(spawner2);

             if (tileentity2 instanceof TileEntityMobSpawner)
             {
                  ((TileEntityMobSpawner)tileentity2).getSpawnerBaseLogic().setEntityName("Darkness");
             }
             
             BlockPos spawner3 = pos.add(-3, 0, 3);
  			
		 world.setBlockState(spawner3, Blocks.mob_spawner.getDefaultState(), 2);
             TileEntity tileentity3 = world.getTileEntity(spawner3);

             if (tileentity3 instanceof TileEntityMobSpawner)
             {
                  ((TileEntityMobSpawner)tileentity3).getSpawnerBaseLogic().setEntityName("Darkness");
             }

             BlockPos spawner4 = pos.add(3, 0, 3);
   			
		 world.setBlockState(spawner4, Blocks.mob_spawner.getDefaultState(), 2);
             TileEntity tileentity4 = world.getTileEntity(spawner4);

             if (tileentity4 instanceof TileEntityMobSpawner)
             {
                  ((TileEntityMobSpawner)tileentity4).getSpawnerBaseLogic().setEntityName("Darkness");
             }
             
	}

}

}

[\code]

Quote

December 27, 20159 yr

Well your generateOtherlyworldDungen method uses:

int startY = world.getActualHeight() - 1;

Why don't you use World#getHeightValue(x, z)? That will give you the actual ground level for those coordinates.

http://i.imgur.com/NdrFdld.png[/img]

Quote

December 27, 20159 yr

Author

It appears in 1.8.8 forge they removed world.getHeightValue Is there another way?

Quote

December 27, 20159 yr

It appears in 1.8.8 forge they removed world.getHeightValue Is there another way?

The method you want is

World#getHeight(BlockPos)

in 1.8+.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/35511-188-structure-generation-generating-in-wrong-y-coordenet/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 3 hours ago3 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 11 hours ago11 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 12 hours ago12 hr
Help with file conversion

This is really helpful

By Brialeblanc · 17 hours ago17 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 23 hours ago23 hr

Ugdhar

Sign In

[1.8.8] Structure generation generating in wrong Y coordenet

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)