Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

FML ignores @Mod annotations on Modloader classes.

JRoush

By JRoush
in Modder Support

 Share

Recommended Posts

JRoush Tree Puncher

JRoush

Posted
Posted

I would like to offer dual support for FML/Modloader.  I don't have a compelling reason to break Modloader compatibility since quite a few people still use it and I don't actually need any FML or Forge features.  That may change at some point, though, and I'd like to get a head start by providing a proper interface to FML.

 

The problem is that FML checks if a mod is ModLoader compatible before it checks annotations, and thus my mod gets treated like a legacy Modloader class even though I provide an FML-specific interface.  Most Forge mods don't have this problem because they aren't still using Modloader-compatible classes.  I can see how that would be the "preferred" solution, but as I said I have no real reason to ditch Modloader yet.

 

I could simply put the annotations on another class and make that my FML interface, but that would not stop FML from finding the Modloader class as well.  There appears to be no way to deactivate a mod, or for a mod to deactivate/hide itself, so ultimately I'd be stuck with two registered mod classes (unnecessary and ugly).

 

Would it be possible to alter the ModContainerFactory priorities so that FML annotations are checked first?  Is this the correct place to ask?  Should I be submitting a pull request somewhere, or is it sufficiently obvious what would need to be changed?

 

EDIT:  I have been able to work around this problem by having two separate mod classes, one for Modloader and one for FML.  I said this was "unnecessary and ugly" above, and it is, but apparently making one class the parent of the other in the mod metadata collapses the two into a single entry in the in-game mod list.  That was the only side effect of having two mod classes that was visible to the player, so fixing it made having two separate classes an acceptable solution.

Link to comment
Share on other sites
keepcalm Diamond Finder

keepcalm

Posted
Posted

You can submit a pull request at https://github.com/cpw/FML. That's probably the easiest way.

Protip: try and find answers yourself before asking on the forum.

It's pretty likely that there is an answer.

 

Was I helpful? Give me a thank you!

 

 

width=635 height=903http://bit.ly/HZ03zy[/img]

 

 

Tired of waiting for mods to port to bukkit?

use BukkitForge! (now with a working version of WorldEdit!)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • jmjm
      Internal Exception:java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1657.method_37908()"because"player"is null

      By jmjm · Posted

      so i just got this crash report and i dont mod a lot so i literally have no idea what to do to fix this
    • KevinManEc
      Skipped Language

      By KevinManEc · Posted

      Hello, I was trying to play a MOD in my preferred language, but I see that only some items are translated, and I go to debug and I get this information (the only thing that is translated is the bestiary):   [14sep.2024 17:14:36.415] [Render thread/WARN] [net.minecraft.client.resources.language.ClientLanguage/]: Skipped language file: mowziesmobs:lang/es_es.json (com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Expected name at line 394 column 2 path $.config.mowziesmobs.ice_crystal_attack_multiplier) [14sep.2024 17:14:36.421] [Render thread/WARN] [net.minecraft.client.resources.language.ClientLanguage/]: Skipped language file: iceandfire:lang/es_es.json (com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Unterminated object at line 1349 column 4 path $.iceandfire.sound.subtitle.dragonflute)   Is that the reason why everything is not translated? , and is there any way to fix it? Thanks
    • Shipwrecker
      [1.20.1] Can't figure out how to get EntityRendererProvider.Context - Difficulty getting custom player model to render

      By Shipwrecker · Posted

      I got my model to render from the models renderToBuffer method. But still not quite what I want. I want to render the model from my renderer's render method. I feel that having access to the renderer and its methods will open some doors for me later down the line. //EntityRendererProvider.Context pContext = ; I want this //ToaPlayerRenderer render = new ToaPlayerRenderer(pContext, false); // if I can get the above line to work, having the methods from the renderer class would be incredibly helpful down the line RenderType rendertype = model.renderType(p.getSkinTextureLocation()); // this should be something like render.getTextureLocation() VertexConsumer vertexconsumer = buffer.getBuffer(rendertype); model.renderToBuffer(stack, vertexconsumer, paLights, 1, 1, 1, 1, 1); // I don't want the render to happen here since it doesn't use the renderer //model.render(p, 1f, pTicks, stack, buffer, paLights); I want to render the model using this It is certainly getting closer though. Probably. I am still worried that even if pContext is initialized this new instance of the renderer class will still hit me with the classic and all too familiar "can't use static method in non-static context"
    • Theral9
      ServerF

      By Theral9 · Posted

      server  
    • Sora666
      PartEntity Issues

      By Sora666 · Posted

      Hello, I am learning how to create Multipart Entities and I tried creating a PartEntity based on the EnderDragonPart code. However, when I tested summoning the entity in the game, the PartEntity appeared at position x 0, y 0, z 0 within the game. I tried to make it follow the main entity, and after testing again, the part entity followed the main entity but seemed to teleport back to x 0, y 0, z 0 every tick (I'm just guessing). I don't know how to fix this can someone help me? My github https://github.com/SteveKK666/Forge-NewWorld-1.20.1/tree/master/src/main/java/net/kk/newworldmod/entity/custom Illustration  https://drive.google.com/file/d/157SPvyQCE8GcsRXyQQkD4Dyhalz6LjBn/view?usp=drive_link Sorry for my English; I’m not very good at it. 

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept