[1.8.9] Change recipe output based on day/night

[LogicTechCorp]

How would I change a recipe output based on whether it is day or night? I am using a custom crafting table and I state whether the recipe requires day or night based on a boolean in the add recipe parameters.

[Choonster]

One way to do this would be to create a custom recipe interface that extends

IRecipe

. In this interface, you can provide an overload of

getCraftingResult

that either takes the

World

(the world that the recipe is being crafted in) or a

boolean

(is it day in that world?). You can then use this method instead of

getCraftingResult(InventoryCrafting)

for any recipe that implements the interface.

 

Another way would be to have separate lists of day and night recipes and use the appropriate list for the current time.

[LogicTechCorp]

It works but with one problem, the output of the recipe does not visually appear but you can still click on the slot to get the output.

[Choonster]

I'd have to see your code to help you any further. Post it using Gist/GitHub or a similar site.

[LogicTechCorp]

Here you go:

 

https://github.com/LogicTechCorp/SoulMagic/tree/master/src/main/java/soulmagic/inventory

 

https://github.com/LogicTechCorp/SoulMagic/tree/master/src/main/java/soulmagic/item/crafting

[Choonster]

The server has the correct item in the output slot, but the client doesn't. I suspect something is wrong with your

Container

, but I don't know what.

[LogicTechCorp]

I think I have found the problem. Its a !world.isRemote check. If I remove it the recipes no longer function correctly, only the daytime recipes work regardless of the time.

 

Edit: If I remove the check the wrong item is shown but you still get the correct output.

[jabelar]

In these sort of cases, you need to learn how to debug yourself. It is your code and any such problem will be specific to your code. So it is important to learn how to be self-sufficient.

 

Here is my suggestion -- trace the execution of your code carefully and confirm that every step of the code does exactly what you expect. You can do this through debug mode in Eclipse, but I prefer to use console statements since then you can just play the game and still monitor what is happening.

 

So with console statements I put a System.out.println (or you can use logger) statement in every method to confirm that the method is being called. Then in every conditional statement (like an if statement) I print out the fields that are being tested to make sure the value is correct. Lastly, any code related to the bug, I put a print out of the relevant fields.

 

When you do that, you've very quickly figure out where things are going wrong. Computers are entirely logical, so there is simply some step along the way where your code isn't doing the logic you expect. Look for that.

[LogicTechCorp]

Still haven't figured it out but when I change the crafting manager from my custom one to the vanilla one the recipes come out correctly. So I assume the issue must becoming from my custom crafting manager but I am not 100% sure.

[jabelar]

Again you need to go through every line of the related code and trace the execution. So if you think something is supposed to be in a slot, print out what the computer thinks is in the slot, if you think it should have found a recipe match, print out whether it found a match or not, and so on. I'm sure that if you just trace through you will find that you made some simple mistake (like wrong slot number assignment, or something).

[LogicTechCorp]

Thank you Jabelar.

 

I change the recipe output based on world.isDaytime(). It appears that it is always daytime on the client but the server time is correct. Could this be causing my issues?

 

[10:46:19] [Client thread/INFO]: [CHAT] Set the time to 13000
[10:46:29] [Client thread/INFO]: [soulmagic.item.crafting.SoulMagicCraftingManager:findMatchingRecipe:42]: isDaytime = true
[10:46:29] [server thread/INFO]: [soulmagic.item.crafting.SoulMagicCraftingManager:findMatchingRecipe:42]: isDaytime = false

 

[10:48:00] [Client thread/INFO]: [soulmagic.item.crafting.SoulMagicCraftingManager:findMatchingRecipe:43]: 8xtile.spectral_glass@0
[10:48:00] [server thread/INFO]: [soulmagic.item.crafting.SoulMagicCraftingManager:findMatchingRecipe:43]: 8xtile.spectral_glass@1

[jeffryfisher]

1) I think the server should be the authority on what gets made. The client should dutifully display correct info to a player. If the client doesn't have good data, then the server must send it.

 

2) Don't forget about the End and Nether. They don't have day-night cycles, so you should think about how you want your custom crafting device to behave in those places. Do want your table to be inert? To explode? To act randomly like a clock or compass? To magically follow the day-night value of the overworld? If the day/night function doesn't default to what you envision, then you'll want to take steps.

 

3) I don't trust isDaytime(). IIRC, it is based on light value, in which a thunderstorm can turn day into night. In my own mods, I do modulo arithmetic on WorldTime:

 

  protected int signal(World w) {
    long wt = w.provider.getWorldTime ();

    if (w.provider.getHasNoSky () ||            // No sky means Nether or End (no moon phase)
        (wt % 24000) < 12000) {                 // Time of day 0..11999 is daytime (moon not up)
      return 0;
    } else {... 

[LogicTechCorp]

Thank you it seems to have fixed my problem but I have another issue. When I pick up the output, the items in the crafting grid decrement correctly then they decrement to 0 and the items that were in the crafting grid are thrown back into the players inventory.

 

[Draco18s]

Your recipe needs to subtract 1 from the item stacks, then if the stack size is zero, set the slot to null.